automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Xu, Rosen" <rosen.xu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw52100 [PATCH v3 04/14] drivers/net/ipn3ke: add IPN3KE representor of PMD driver
Date: Tue,  2 Apr 2019 15:57:56 +0200 (CEST)	[thread overview]
Message-ID: <20190402135756.B60DC5688@dpdk.org> (raw)
In-Reply-To: <1554213434-60684-5-git-send-email-rosen.xu@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52100

_coding style issues_


CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#216: FILE: drivers/net/ipn3ke/ipn3ke_representor.c:129:
+	dev->data->mac_addrs->addr_bytes[ETHER_ADDR_LEN-1] =
 	                                               ^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < ETHER_MIN_MTU'
#846: FILE: drivers/net/ipn3ke/ipn3ke_representor.c:759:
+	if ((mtu < ETHER_MIN_MTU) ||
+		(frame_size > IPN3KE_MAC_FRAME_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > IPN3KE_MAC_FRAME_SIZE_MAX'
#846: FILE: drivers/net/ipn3ke/ipn3ke_representor.c:759:
+	if ((mtu < ETHER_MIN_MTU) ||
+		(frame_size > IPN3KE_MAC_FRAME_SIZE_MAX))

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#853: FILE: drivers/net/ipn3ke/ipn3ke_representor.c:766:
+		IPN3KE_AFU_PMD_ERR(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#860: FILE: drivers/net/ipn3ke/ipn3ke_representor.c:773:
+		IPN3KE_AFU_PMD_ERR(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#994: FILE: drivers/net/ipn3ke/ipn3ke_representor.c:907:
+		IPN3KE_AFU_PMD_ERR(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1021: FILE: drivers/net/ipn3ke/ipn3ke_representor.c:934:
+		IPN3KE_AFU_PMD_ERR(

total: 0 errors, 0 warnings, 7 checks, 1006 lines checked

           reply	other threads:[~2019-04-02 13:57 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1554213434-60684-5-git-send-email-rosen.xu@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190402135756.B60DC5688@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=rosen.xu@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).