From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 62E8DA0679 for ; Tue, 2 Apr 2019 15:58:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CCC2D548B; Tue, 2 Apr 2019 15:58:01 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id BACB44C9F; Tue, 2 Apr 2019 15:58:00 +0200 (CEST) In-Reply-To: <1554213434-60684-6-git-send-email-rosen.xu@intel.com> References: <1554213434-60684-6-git-send-email-rosen.xu@intel.com> To: test-report@dpdk.org Cc: "Xu, Rosen" Message-Id: <20190402135800.BACB44C9F@dpdk.org> Date: Tue, 2 Apr 2019 15:58:00 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw52101 [PATCH v3 05/14] drivers/net/ipn3ke: add IPN3KE TM of PMD driver X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/52101 _coding style issues_ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->tm_id != RTE_TM_NODE_ID_NULL' #444: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:339: + if ((n->tm_id != RTE_TM_NODE_ID_NULL) || + (n->parent_node_id != RTE_TM_NODE_ID_NULL) || + (n->parent_node != NULL) || + (n->n_children > 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node_id != RTE_TM_NODE_ID_NULL' #444: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:339: + if ((n->tm_id != RTE_TM_NODE_ID_NULL) || + (n->parent_node_id != RTE_TM_NODE_ID_NULL) || + (n->parent_node != NULL) || + (n->n_children > 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node != NULL' #444: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:339: + if ((n->tm_id != RTE_TM_NODE_ID_NULL) || + (n->parent_node_id != RTE_TM_NODE_ID_NULL) || + (n->parent_node != NULL) || + (n->n_children > 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->n_children > 0' #444: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:339: + if ((n->tm_id != RTE_TM_NODE_ID_NULL) || + (n->parent_node_id != RTE_TM_NODE_ID_NULL) || + (n->parent_node != NULL) || + (n->n_children > 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->tm_id == RTE_TM_NODE_ID_NULL' #451: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:346: + if ((n->tm_id == RTE_TM_NODE_ID_NULL) || + ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) && + (n->parent_node_id == RTE_TM_NODE_ID_NULL)) || + ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) && + (n->parent_node == NULL))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT' #451: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:346: + if ((n->tm_id == RTE_TM_NODE_ID_NULL) || + ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) && + (n->parent_node_id == RTE_TM_NODE_ID_NULL)) || + ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) && + (n->parent_node == NULL))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node_id == RTE_TM_NODE_ID_NULL' #451: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:346: + if ((n->tm_id == RTE_TM_NODE_ID_NULL) || + ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) && + (n->parent_node_id == RTE_TM_NODE_ID_NULL)) || + ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) && + (n->parent_node == NULL))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT' #451: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:346: + if ((n->tm_id == RTE_TM_NODE_ID_NULL) || + ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) && + (n->parent_node_id == RTE_TM_NODE_ID_NULL)) || + ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) && + (n->parent_node == NULL))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node == NULL' #451: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:346: + if ((n->tm_id == RTE_TM_NODE_ID_NULL) || + ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) && + (n->parent_node_id == RTE_TM_NODE_ID_NULL)) || + ((level_of_node_id != IPN3KE_TM_NODE_LEVEL_PORT) && + (n->parent_node == NULL))) { CHECK:BRACES: braces {} should be used on all arms of this statement #462: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:357: + if (IPN3KE_BIT_ISSET(state_mask, n->node_state)) { [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #469: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:364: + } else CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'node == NULL' #498: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:393: + if (node_id == RTE_TM_NODE_ID_NULL || + (node == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rate >= r->low' #805: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:700: + if ((rate >= r->low) && + (rate <= r->high)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rate <= r->high' #805: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:700: + if ((rate >= r->low) && + (rate <= r->high)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->shaper_profile_id != RTE_TM_SHAPER_PROFILE_ID_NONE' #1295: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1190: + if ((params->shaper_profile_id != RTE_TM_SHAPER_PROFILE_ID_NONE) && + (params->shaper_profile_id != node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->shaper_profile_id != node_id' #1295: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1190: + if ((params->shaper_profile_id != RTE_TM_SHAPER_PROFILE_ID_NONE) && + (params->shaper_profile_id != node_id)) CHECK:BRACES: braces {} should be used on all arms of this statement #1320: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1215: + if (parent_node_id != RTE_TM_NODE_ID_NULL) { [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #1331: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1226: + } else CHECK:BRACES: braces {} should be used on all arms of this statement #1510: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1405: + if (n->parent_node_id != RTE_TM_NODE_ID_NULL) { [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #1530: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1425: + } else CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node_id == RTE_TM_NODE_ID_NULL' #1607: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1502: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_COS) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != IPN3KE_TM_NODE_LEVEL_COS' #1607: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1502: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_COS) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->tm_id != tm_id' #1607: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1502: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_COS) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node == NULL' #1607: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1502: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_COS) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node->node_state == IPN3KE_TM_NODE_STATE_CONFIGURED_DEL' #1607: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1502: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_COS) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node->node_state == IPN3KE_TM_NODE_STATE_IDLE' #1607: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1502: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_COS) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->shaper_profile.valid == 0' #1607: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1502: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_COS) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != IPN3KE_TM_NODE_LEVEL_COS' #1626: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1521: + if ((n->level != IPN3KE_TM_NODE_LEVEL_COS) || + (n->n_children != 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->n_children != 0' #1626: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1521: + if ((n->level != IPN3KE_TM_NODE_LEVEL_COS) || + (n->n_children != 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node_id == RTE_TM_NODE_ID_NULL' #1647: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1542: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_VT) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != IPN3KE_TM_NODE_LEVEL_VT' #1647: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1542: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_VT) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->tm_id != tm_id' #1647: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1542: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_VT) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node == NULL' #1647: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1542: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_VT) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node->node_state == IPN3KE_TM_NODE_STATE_CONFIGURED_DEL' #1647: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1542: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_VT) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parent_node->node_state == IPN3KE_TM_NODE_STATE_IDLE' #1647: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1542: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_VT) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->shaper_profile.valid == 0' #1647: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1542: + if ((n->parent_node_id == RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_VT) || + (n->tm_id != tm_id) || + (parent_node == NULL) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_CONFIGURED_DEL)) || + (parent_node && + (parent_node->node_state == + IPN3KE_TM_NODE_STATE_IDLE)) || + (n->shaper_profile.valid == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != IPN3KE_TM_NODE_LEVEL_VT' #1666: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1561: + if ((n->level != IPN3KE_TM_NODE_LEVEL_VT) || + (n->n_children != 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->n_children != 0' #1666: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1561: + if ((n->level != IPN3KE_TM_NODE_LEVEL_VT) || + (n->n_children != 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node_id != RTE_TM_NODE_ID_NULL' #1684: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1579: + if (n && + ((n->parent_node_id != RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_PORT) || + (n->tm_id != tm_id) || + (n->parent_node != NULL) || + (n->shaper_profile.valid == 0))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != IPN3KE_TM_NODE_LEVEL_PORT' #1684: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1579: + if (n && + ((n->parent_node_id != RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_PORT) || + (n->tm_id != tm_id) || + (n->parent_node != NULL) || + (n->shaper_profile.valid == 0))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->tm_id != tm_id' #1684: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1579: + if (n && + ((n->parent_node_id != RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_PORT) || + (n->tm_id != tm_id) || + (n->parent_node != NULL) || + (n->shaper_profile.valid == 0))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node != NULL' #1684: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1579: + if (n && + ((n->parent_node_id != RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_PORT) || + (n->tm_id != tm_id) || + (n->parent_node != NULL) || + (n->shaper_profile.valid == 0))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->shaper_profile.valid == 0' #1684: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:1579: + if (n && + ((n->parent_node_id != RTE_TM_NODE_ID_NULL) || + (n->level != IPN3KE_TM_NODE_LEVEL_PORT) || + (n->tm_id != tm_id) || + (n->parent_node != NULL) || + (n->shaper_profile.valid == 0))) { CHECK:BRACES: braces {} should be used on all arms of this statement #2171: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:2066: + if (hw->acc_tm) [...] + else if (rpst->i40e_pf_eth) { [...] + } else [...] CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i40e_pf_eth->dev_ops->tm_ops_get == NULL' #2175: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:2070: + if ((i40e_pf_eth->dev_ops->tm_ops_get == NULL) || + (i40e_pf_eth->dev_ops->tm_ops_get(i40e_pf_eth, + &ops) != 0) || + (ops == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ops == NULL' #2175: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:2070: + if ((i40e_pf_eth->dev_ops->tm_ops_get == NULL) || + (i40e_pf_eth->dev_ops->tm_ops_get(i40e_pf_eth, + &ops) != 0) || + (ops == NULL)) CHECK:BRACES: Unbalanced braces around else statement #2181: FILE: drivers/net/ipn3ke/ipn3ke_tm.c:2076: + } else total: 0 errors, 0 warnings, 47 checks, 2131 lines checked