From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: [dpdk-test-report] |WARNING| pw52347 [RFC] eal: make rte_rand() MT safe
Date: Fri, 5 Apr 2019 15:47:26 +0200 (CEST) [thread overview]
Message-ID: <20190405134726.720821B501@dpdk.org> (raw)
In-Reply-To: <20190405134542.28618-1-mattias.ronnblom@ericsson.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52347
_coding style issues_
ERROR:OPEN_BRACE: open brace '{' following struct go on the same line
#138: FILE: lib/librte_eal/common/rte_random.c:14:
+struct rte_rand_data
+{
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#147: FILE: lib/librte_eal/common/rte_random.c:23:
+ unsigned i;
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#150: FILE: lib/librte_eal/common/rte_random.c:26:
+ /* give the different lcores a different seed, to avoid a
+ situation where they generate the same sequence */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#150: FILE: lib/librte_eal/common/rte_random.c:26:
+ situation where they generate the same sequence */
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#168: FILE: lib/librte_eal/common/rte_random.c:44:
+ unsigned lcore_id;
total: 1 errors, 4 warnings, 163 lines checked
parent reply other threads:[~2019-04-05 13:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190405134542.28618-1-mattias.ronnblom@ericsson.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405134726.720821B501@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).