From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C368BA0679 for ; Fri, 5 Apr 2019 15:47:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD3951B4F4; Fri, 5 Apr 2019 15:47:29 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 720821B501; Fri, 5 Apr 2019 15:47:26 +0200 (CEST) In-Reply-To: <20190405134542.28618-1-mattias.ronnblom@ericsson.com> References: <20190405134542.28618-1-mattias.ronnblom@ericsson.com> To: test-report@dpdk.org Cc: =?utf-8?q?Mattias_R=C3=B6nnblom?= Message-Id: <20190405134726.720821B501@dpdk.org> Date: Fri, 5 Apr 2019 15:47:26 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw52347 [RFC] eal: make rte_rand() MT safe X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/52347 _coding style issues_ ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #138: FILE: lib/librte_eal/common/rte_random.c:14: +struct rte_rand_data +{ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #147: FILE: lib/librte_eal/common/rte_random.c:23: + unsigned i; WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #150: FILE: lib/librte_eal/common/rte_random.c:26: + /* give the different lcores a different seed, to avoid a + situation where they generate the same sequence */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #150: FILE: lib/librte_eal/common/rte_random.c:26: + situation where they generate the same sequence */ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #168: FILE: lib/librte_eal/common/rte_random.c:44: + unsigned lcore_id; total: 1 errors, 4 warnings, 163 lines checked