automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw52348 [PATCH v3] meter: replace color definitions with rte_color values
Date: Fri,  5 Apr 2019 15:55:48 +0200 (CEST)	[thread overview]
Message-ID: <20190405135548.D2B281B513@dpdk.org> (raw)
In-Reply-To: <20190405135441.40049-1-jasvinder.singh@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52348

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#776: FILE: drivers/net/softnic/rte_eth_softnic_flow.c:1628:
+				softnic_table_action_policer(m->params.action[RTE_COLOR_GREEN]);

WARNING:LONG_LINE: line over 90 characters
#778: FILE: drivers/net/softnic/rte_eth_softnic_flow.c:1630:
+				softnic_table_action_policer(m->params.action[RTE_COLOR_YELLOW]);

WARNING:LONG_LINE: line over 90 characters
#780: FILE: drivers/net/softnic/rte_eth_softnic_flow.c:1632:
+				softnic_table_action_policer(m->params.action[RTE_COLOR_RED]);

WARNING:LONG_LINE: line over 90 characters
#1070: FILE: examples/qos_meter/rte_policer.c:19:
+	if ((pre_meter > RTE_COLOR_RED) || (post_meter > RTE_COLOR_RED) || (pre_meter > post_meter)) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1070: FILE: examples/qos_meter/rte_policer.c:19:
+	if ((pre_meter > RTE_COLOR_RED) || (post_meter > RTE_COLOR_RED) || (pre_meter > post_meter)) {
 		return -2;
 	}

WARNING:LONG_LINE: line over 90 characters
#1103: FILE: examples/qos_meter/rte_policer.h:27:
+policer_run(struct rte_phb *phb_table, uint32_t phb_table_index, enum rte_color pre_meter, enum rte_color post_meter)

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1811: FILE: lib/librte_sched/rte_sched.h:208:
+	struct rte_red_params red_params[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE][RTE_COLORS]; /**< RED parameters */

total: 0 errors, 7 warnings, 1546 lines checked

           reply	other threads:[~2019-04-05 13:55 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20190405135441.40049-1-jasvinder.singh@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190405135548.D2B281B513@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).