From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw52545 [RFC v2 01/14] net: add rte prefix to arp structures
Date: Wed, 10 Apr 2019 10:33:34 +0200 (CEST) [thread overview]
Message-ID: <20190410083334.E0ABB532C@dpdk.org> (raw)
In-Reply-To: <20190410083218.17531-2-olivier.matz@6wind.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52545
_coding style issues_
ERROR:SPACING: space prohibited before that close parenthesis ')'
#55: FILE: app/test-pmd/icmpecho.c:41:
+ switch (arp_opcode ) {
WARNING:LONG_LINE: line over 90 characters
#224: FILE: app/test/test_link_bonding.c:4549:
+ arp_pkt = (struct rte_arp_hdr *)((char *)eth_pkt + sizeof(struct ether_hdr));
WARNING:LONG_LINE: line over 90 characters
#278: FILE: app/test/test_link_bonding.c:4670:
+ arp_pkt = (struct rte_arp_hdr *)((char *)eth_pkt + sizeof(struct ether_hdr));
CHECK:SPACING: No space is necessary after a cast
#317: FILE: drivers/net/bonding/rte_eth_bond_alb.c:84:
+ arp = (struct rte_arp_hdr *) ((char *) (eth_h + 1) + offset);
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#408: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:569:
+#define MODE6_DEBUG(info, src_ip, dst_ip, eth_h, arp_opcode, port, burstnumber) \
rte_log(RTE_LOG_DEBUG, bond_logtype, \
"%s port:%d SrcMAC:%02X:%02X:%02X:%02X:%02X:%02X SrcIP:%s " \
"DstMAC:%02X:%02X:%02X:%02X:%02X:%02X DstIP:%s %s %d
", \
WARNING:LONG_LINE: line over 90 characters
#448: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1130:
+ pkt_size = sizeof(struct ether_hdr) + sizeof(struct rte_arp_hdr)
WARNING:LONG_LINE: line over 90 characters
#642: FILE: examples/bond/main.c:385:
+ arp_hdr = (struct rte_arp_hdr *)((char *)(eth_hdr + 1) + offset);
WARNING:LONG_LINE: line over 90 characters
#646: FILE: examples/bond/main.c:387:
+ if (arp_hdr->arp_opcode == rte_cpu_to_be_16(ARP_OP_REQUEST)) {
WARNING:LONG_LINE: line over 90 characters
#647: FILE: examples/bond/main.c:388:
+ arp_hdr->arp_opcode = rte_cpu_to_be_16(ARP_OP_REPLY);
total: 2 errors, 6 warnings, 599 lines checked
parent reply other threads:[~2019-04-10 8:33 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190410083218.17531-2-olivier.matz@6wind.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410083334.E0ABB532C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).