From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id AB146A0096
	for <public@inbox.dpdk.org>; Wed, 10 Apr 2019 10:33:37 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 57F45532C;
	Wed, 10 Apr 2019 10:33:37 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id E0ABB532C; Wed, 10 Apr 2019 10:33:34 +0200 (CEST)
In-Reply-To: <20190410083218.17531-2-olivier.matz@6wind.com>
References: <20190410083218.17531-2-olivier.matz@6wind.com>
To: test-report@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Message-Id: <20190410083334.E0ABB532C@dpdk.org>
Date: Wed, 10 Apr 2019 10:33:34 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw52545 [RFC v2 01/14] net: add rte
	prefix to arp structures
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52545

_coding style issues_


ERROR:SPACING: space prohibited before that close parenthesis ')'
#55: FILE: app/test-pmd/icmpecho.c:41:
+	switch (arp_opcode ) {

WARNING:LONG_LINE: line over 90 characters
#224: FILE: app/test/test_link_bonding.c:4549:
+			arp_pkt = (struct rte_arp_hdr *)((char *)eth_pkt + sizeof(struct ether_hdr));

WARNING:LONG_LINE: line over 90 characters
#278: FILE: app/test/test_link_bonding.c:4670:
+			arp_pkt = (struct rte_arp_hdr *)((char *)eth_pkt + sizeof(struct ether_hdr));

CHECK:SPACING: No space is necessary after a cast
#317: FILE: drivers/net/bonding/rte_eth_bond_alb.c:84:
+	arp = (struct rte_arp_hdr *) ((char *) (eth_h + 1) + offset);

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#408: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:569:
+#define MODE6_DEBUG(info, src_ip, dst_ip, eth_h, arp_opcode, port, burstnumber) \
 	rte_log(RTE_LOG_DEBUG, bond_logtype,				\
 		"%s port:%d SrcMAC:%02X:%02X:%02X:%02X:%02X:%02X SrcIP:%s " \
 		"DstMAC:%02X:%02X:%02X:%02X:%02X:%02X DstIP:%s %s %d
", \

WARNING:LONG_LINE: line over 90 characters
#448: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1130:
+				pkt_size = sizeof(struct ether_hdr) + sizeof(struct rte_arp_hdr)

WARNING:LONG_LINE: line over 90 characters
#642: FILE: examples/bond/main.c:385:
+				arp_hdr = (struct rte_arp_hdr *)((char *)(eth_hdr + 1) + offset);

WARNING:LONG_LINE: line over 90 characters
#646: FILE: examples/bond/main.c:387:
+					if (arp_hdr->arp_opcode == rte_cpu_to_be_16(ARP_OP_REQUEST)) {

WARNING:LONG_LINE: line over 90 characters
#647: FILE: examples/bond/main.c:388:
+						arp_hdr->arp_opcode = rte_cpu_to_be_16(ARP_OP_REPLY);

total: 2 errors, 6 warnings, 599 lines checked