From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C25D2A0096 for ; Wed, 10 Apr 2019 10:33:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 84CC8559A; Wed, 10 Apr 2019 10:33:41 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 0486E532C; Wed, 10 Apr 2019 10:33:40 +0200 (CEST) In-Reply-To: <20190410083218.17531-5-olivier.matz@6wind.com> References: <20190410083218.17531-5-olivier.matz@6wind.com> To: test-report@dpdk.org Cc: Olivier Matz Message-Id: <20190410083340.0486E532C@dpdk.org> Date: Wed, 10 Apr 2019 10:33:40 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw52547 [RFC v2 04/14] net: add rte prefix to ether functions X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/52547 _coding style issues_ WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #24: - rename is_valid_assigned_ether_addr() as rte_is_valid_assigned_ether_addr(). WARNING:LONG_LINE: line over 90 characters #292: FILE: app/test-pmd/icmpecho.c:401: + rte_ether_addr_copy(&arp_h->arp_data.arp_sha, &arp_h->arp_data.arp_tha); WARNING:LONG_LINE: line over 90 characters #433: FILE: app/test/test_link_bonding.c:4552: + if (!rte_is_same_ether_addr(slave_mac1, &arp_pkt->arp_data.arp_sha)) { WARNING:LONG_LINE: line over 90 characters #439: FILE: app/test/test_link_bonding.c:4557: + if (!rte_is_same_ether_addr(slave_mac2, &arp_pkt->arp_data.arp_sha)) { WARNING:LONG_LINE: line over 90 characters #457: FILE: app/test/test_link_bonding.c:4673: + if (!rte_is_same_ether_addr(slave_mac1, &arp_pkt->arp_data.arp_sha)) { WARNING:LONG_LINE: line over 90 characters #463: FILE: app/test/test_link_bonding.c:4678: + if (!rte_is_same_ether_addr(slave_mac2, &arp_pkt->arp_data.arp_sha)) { WARNING:LONG_LINE: line over 90 characters #860: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:697: + rte_is_same_ether_addr(&agg->partner.system, &port->partner.system) == 1 WARNING:LONG_LINE: line over 90 characters #909: FILE: drivers/net/bonding/rte_eth_bond_alb.c:104: + !rte_is_same_ether_addr(&client_info->cli_mac, &arp->arp_data.arp_sha) || WARNING:LONG_LINE: line over 90 characters #940: FILE: drivers/net/bonding/rte_eth_bond_alb.c:158: + if (!rte_is_broadcast_ether_addr(&arp->arp_data.arp_tha)) { WARNING:LONG_LINE: line over 90 characters #947: FILE: drivers/net/bonding/rte_eth_bond_alb.c:164: + rte_ether_addr_copy(&client_info->app_mac, &arp->arp_data.arp_sha); WARNING:LONG_LINE: line over 90 characters #1018: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1031: + if (rte_is_same_ether_addr(ðer_hdr->s_addr, &primary_slave_addr)) WARNING:LONG_LINE: line over 90 characters #1019: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1032: + rte_ether_addr_copy(&active_slave_addr, ðer_hdr->s_addr); CHECK:SPACING: No space is necessary after a cast #1132: FILE: drivers/net/e1000/em_ethdev.c:296: + rte_ether_addr_copy((struct rte_ether_addr *) hw->mac.addr, WARNING:LONG_LINE: line over 90 characters #1145: FILE: drivers/net/e1000/igb_ethdev.c:843: + rte_ether_addr_copy((struct rte_ether_addr *)hw->mac.addr, ð_dev->data->mac_addrs[0]); CHECK:SPACING: No space is necessary after a cast #1165: FILE: drivers/net/e1000/igb_ethdev.c:1060: + rte_ether_addr_copy((struct rte_ether_addr *) hw->mac.perm_addr, CHECK:SPACING: No space is necessary after a cast #1298: FILE: drivers/net/enic/enic_main.c:1676: + rte_ether_addr_copy((struct rte_ether_addr *) enic->mac_addr, CHECK:SPACING: No space is necessary after a cast #1389: FILE: drivers/net/i40e/i40e_ethdev.c:1470: + rte_ether_addr_copy((struct rte_ether_addr *) hw->mac.addr, CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around pf->dev_addr #1416: FILE: drivers/net/i40e/i40e_ethdev.c:4128: + if (add && rte_is_same_ether_addr(new_mac, &(pf->dev_addr))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around pf->dev_addr #1434: FILE: drivers/net/i40e/i40e_ethdev.c:4157: + if (rte_is_same_ether_addr(&(pf->dev_addr), new_mac)) ERROR:SPACING: space required before the open parenthesis '(' #1696: FILE: drivers/net/i40e/i40e_pf.c:890: + if(rte_is_zero_ether_addr(mac) || CHECK:SPACING: No space is necessary after a cast #1877: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1225: + rte_ether_addr_copy((struct rte_ether_addr *) hw->mac.perm_addr, CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line #2582: FILE: drivers/net/virtio/virtio_ethdev.c:1167: struct virtio_net_ctrl_mac *tbl + = rte_is_multicast_ether_addr(addr) ? mc : uc; CHECK:SPACING: No space is necessary after a cast #2604: FILE: drivers/net/virtio/virtio_ethdev.c:1665: + rte_ether_addr_copy((struct rte_ether_addr *) hw->mac_addr, CHECK:SPACING: No space is necessary after a cast #2632: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:314: + rte_ether_addr_copy((struct rte_ether_addr *) hw->perm_addr, WARNING:LONG_LINE: line over 90 characters #2654: FILE: examples/bond/main.c:390: + rte_ether_addr_copy(ð_hdr->s_addr, ð_hdr->d_addr); WARNING:LONG_LINE: line over 90 characters #2657: FILE: examples/bond/main.c:392: + rte_ether_addr_copy(&arp_hdr->arp_data.arp_sha, &arp_hdr->arp_data.arp_tha); WARNING:LONG_LINE: line over 90 characters #2661: FILE: examples/bond/main.c:395: + rte_ether_addr_copy(&d_addr, &arp_hdr->arp_data.arp_sha); WARNING:LONG_LINE: line over 90 characters #2670: FILE: examples/bond/main.c:410: + rte_ether_addr_copy(ð_hdr->s_addr, ð_hdr->d_addr); total: 1 errors, 17 warnings, 2754 lines checked