From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B2351A0096 for ; Wed, 10 Apr 2019 11:02:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AAFDD5B2C; Wed, 10 Apr 2019 11:02:32 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id EECD25B3E; Wed, 10 Apr 2019 11:02:30 +0200 (CEST) In-Reply-To: <20190410083218.17531-6-olivier.matz@6wind.com> References: <20190410083218.17531-6-olivier.matz@6wind.com> To: test-report@dpdk.org Cc: Olivier Matz Message-Id: <20190410090230.EECD25B3E@dpdk.org> Date: Wed, 10 Apr 2019 11:02:30 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw52560 [RFC v2 05/14] net: add rte prefix to ether defines X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/52560 _coding style issues_ WARNING:LONG_LINE: line over 90 characters #1300: FILE: app/test/test_link_bonding.c:3989: + (struct rte_ether_addr *)dst_mac_0, RTE_ETHER_TYPE_IPv4, 0, 0); WARNING:LONG_LINE: line over 90 characters #1305: FILE: app/test/test_link_bonding.c:3993: + (struct rte_ether_addr *)dst_mac_0, RTE_ETHER_TYPE_IPv4, 0, 0); WARNING:LONG_LINE: line over 90 characters #1431: FILE: app/test/test_link_bonding.c:4767: + if (vlan_pkt->eth_proto != rte_cpu_to_be_16(RTE_ETHER_TYPE_VLAN)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #1803: FILE: drivers/net/atlantic/atl_ethdev.c:1271: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen' #1803: FILE: drivers/net/atlantic/atl_ethdev.c:1271: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'new_mtu < RTE_ETHER_MIN_MTU' #2757: FILE: drivers/net/cxgbe/cxgbe_ethdev.c:284: + if ((new_mtu < RTE_ETHER_MIN_MTU) || (new_mtu > dev_info.max_rx_pktlen)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'new_mtu > dev_info.max_rx_pktlen' #2757: FILE: drivers/net/cxgbe/cxgbe_ethdev.c:284: + if ((new_mtu < RTE_ETHER_MIN_MTU) || (new_mtu > dev_info.max_rx_pktlen)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->pkt_len > RTE_ETHER_MAX_LEN' #2999: FILE: drivers/net/cxgbe/sge.c:1148: + if (!((m->ol_flags & PKT_TX_TCP_SEG) || (m->pkt_len > RTE_ETHER_MAX_LEN))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #3121: FILE: drivers/net/dpaa2/dpaa2_ethdev.c:1100: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > DPAA2_MAX_RX_PKT_LEN)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > DPAA2_MAX_RX_PKT_LEN' #3121: FILE: drivers/net/dpaa2/dpaa2_ethdev.c:1100: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > DPAA2_MAX_RX_PKT_LEN)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #3238: FILE: drivers/net/e1000/em_ethdev.c:1778: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen' #3238: FILE: drivers/net/e1000/em_ethdev.c:1778: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) CHECK:SPACING: No space is necessary after a cast #3273: FILE: drivers/net/e1000/em_rxtx.c:1018: + (uint16_t) (data_len - RTE_ETHER_CRC_LEN); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #3445: FILE: drivers/net/e1000/igb_ethdev.c:4486: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen' #3445: FILE: drivers/net/e1000/igb_ethdev.c:4486: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) WARNING:LONG_LINE: line over 90 characters #3533: FILE: drivers/net/e1000/igb_pf.c:406: + if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame < RTE_ETHER_MIN_LEN' #3533: FILE: drivers/net/e1000/igb_pf.c:406: + if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN' #3533: FILE: drivers/net/e1000/igb_pf.c:406: + if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)) CHECK:SPACING: No space is necessary after a cast #3559: FILE: drivers/net/e1000/igb_rxtx.c:1160: + (uint16_t) (data_len - RTE_ETHER_CRC_LEN); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #3991: FILE: drivers/net/i40e/i40e_ethdev.c:11999: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > I40E_FRAME_SIZE_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > I40E_FRAME_SIZE_MAX' #3991: FILE: drivers/net/i40e/i40e_ethdev.c:11999: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > I40E_FRAME_SIZE_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #4078: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2682: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > I40E_FRAME_SIZE_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > I40E_FRAME_SIZE_MAX' #4078: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2682: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > I40E_FRAME_SIZE_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #4738: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4958: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen' #4738: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4958: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #4756: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:6360: + if ((mtu < RTE_ETHER_MIN_MTU) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN' #4756: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:6360: + if ((mtu < RTE_ETHER_MIN_MTU) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)) WARNING:LONG_LINE: line over 90 characters #4907: FILE: drivers/net/ixgbe/ixgbe_pf.c:558: + if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame < RTE_ETHER_MIN_LEN' #4907: FILE: drivers/net/ixgbe/ixgbe_pf.c:558: + if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN' #4907: FILE: drivers/net/ixgbe/ixgbe_pf.c:558: + if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vlan > RTE_ETHER_MAX_VLAN_ID' #4969: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:479: + if ((vlan > RTE_ETHER_MAX_VLAN_ID) || (vf_mask == 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf_mask == 0' #4969: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:479: + if ((vlan > RTE_ETHER_MAX_VLAN_ID) || (vf_mask == 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #5004: FILE: drivers/net/liquidio/lio_ethdev.c:448: + if ((mtu < RTE_ETHER_MIN_MTU) || (mtu > pf_mtu)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu > pf_mtu' #5004: FILE: drivers/net/liquidio/lio_ethdev.c:448: + if ((mtu < RTE_ETHER_MIN_MTU) || (mtu > pf_mtu)) { WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t' should also have an identifier name #5082: FILE: drivers/net/mlx4/mlx4.h:204: +int mlx4_get_mac(struct mlx4_priv *priv, uint8_t (*mac)[RTE_ETHER_ADDR_LEN]); WARNING:BRACES: braces {} are not necessary for single statement blocks #5130: FILE: drivers/net/mlx4/mlx4_flow.c:259: + for (i = 0; i < RTE_ETHER_ADDR_LEN; ++i) { eth->val.dst_mac[i] &= eth->mask.dst_mac[i]; } WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t' should also have an identifier name #5169: FILE: drivers/net/mlx5/mlx5.h:404: +int mlx5_get_mac(struct rte_eth_dev *dev, uint8_t (*mac)[RTE_ETHER_ADDR_LEN]); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #5716: FILE: drivers/net/nfp/nfp_net.c:1489: + if ((mtu < RTE_ETHER_MIN_MTU) || ((uint32_t)mtu > hw->max_mtu)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU' #5954: FILE: drivers/net/qede/qede_ethdev.c:2232: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen' #5954: FILE: drivers/net/qede/qede_ethdev.c:2232: + if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) { WARNING:LONG_LINE: line over 90 characters #6585: FILE: drivers/net/virtio/virtio_ethdev.c:1838: + eth_dev->data->mac_addrs = rte_zmalloc("virtio", VIRTIO_MAX_MAC_ADDRS * RTE_ETHER_ADDR_LEN, 0); WARNING:LONG_LINE_COMMENT: line over 90 characters #7461: FILE: examples/performance-thread/l3fwd-thread/main.c:2978: + /* if no max-pkt-len set, use the default value RTE_ETHER_MAX_LEN */ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #7763: FILE: lib/librte_ethdev/rte_ethdev.c:1228: + (unsigned)RTE_ETHER_MIN_LEN); total: 0 errors, 11 warnings, 6686 lines checked