From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw52561 [RFC v2 03/14] net: add rte prefix to ether structures
Date: Wed, 10 Apr 2019 11:02:37 +0200 (CEST) [thread overview]
Message-ID: <20190410090237.5EE1B5B3C@dpdk.org> (raw)
In-Reply-To: <20190410083218.17531-4-olivier.matz@6wind.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52561
_coding style issues_
WARNING:LONG_LINE: line over 90 characters
#1302: FILE: app/test/packet_burst_generator.c:296:
+ eth_hdr_size = sizeof(struct rte_ether_hdr) + sizeof(struct rte_vlan_hdr);
WARNING:LONG_LINE: line over 90 characters
#1693: FILE: app/test/test_link_bonding.c:1271:
+ (struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_1,
WARNING:LONG_LINE: line over 90 characters
#1698: FILE: app/test/test_link_bonding.c:1275:
+ (struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_0,
WARNING:LONG_LINE: line over 90 characters
#1734: FILE: app/test/test_link_bonding.c:2033:
+ (struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_0,
WARNING:LONG_LINE: line over 90 characters
#1761: FILE: app/test/test_link_bonding.c:2567:
+ (struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_0,
WARNING:LONG_LINE: line over 90 characters
#1770: FILE: app/test/test_link_bonding.c:2582:
+ (struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_1,
WARNING:LONG_LINE: line over 90 characters
#1797: FILE: app/test/test_link_bonding.c:3405:
+ (struct rte_ether_addr *)src_mac, (struct rte_ether_addr *)dst_mac_0,
WARNING:LONG_LINE: line over 90 characters
#1826: FILE: app/test/test_link_bonding.c:3989:
+ (struct rte_ether_addr *)dst_mac_0, ETHER_TYPE_IPv4, 0, 0);
WARNING:LONG_LINE: line over 90 characters
#1831: FILE: app/test/test_link_bonding.c:3992:
+ (struct rte_ether_addr *)test_params->default_slave_mac,
WARNING:LONG_LINE: line over 90 characters
#1832: FILE: app/test/test_link_bonding.c:3993:
+ (struct rte_ether_addr *)dst_mac_0, ETHER_TYPE_IPv4, 0, 0);
WARNING:LONG_LINE: line over 90 characters
#1927: FILE: app/test/test_link_bonding.c:4548:
+ eth_pkt = rte_pktmbuf_mtod(pkts_sent[pkt_idx], struct rte_ether_hdr *);
WARNING:LONG_LINE: line over 90 characters
#1928: FILE: app/test/test_link_bonding.c:4549:
+ arp_pkt = (struct rte_arp_hdr *)((char *)eth_pkt + sizeof(struct rte_ether_hdr));
WARNING:LONG_LINE: line over 90 characters
#2010: FILE: app/test/test_link_bonding.c:4669:
+ eth_pkt = rte_pktmbuf_mtod(pkts_sent[pkt_idx], struct rte_ether_hdr *);
WARNING:LONG_LINE: line over 90 characters
#2011: FILE: app/test/test_link_bonding.c:4670:
+ arp_pkt = (struct rte_arp_hdr *)((char *)eth_pkt + sizeof(struct rte_ether_hdr));
WARNING:LONG_LINE: line over 90 characters
#2054: FILE: app/test/test_link_bonding.c:4761:
+ eth_pkt = rte_pktmbuf_mtod(pkts_sent[pkt_idx], struct rte_ether_hdr *);
ERROR:SPACING: space prohibited before that close parenthesis ')'
#2306: FILE: app/test/test_sched.c:87:
+ vlan1 = (struct rte_vlan_hdr *)(ð_hdr->ether_type );
WARNING:LONG_LINE: line over 90 characters
#2307: FILE: app/test/test_sched.c:88:
+ vlan2 = (struct rte_vlan_hdr *)((uintptr_t)ð_hdr->ether_type + sizeof(struct rte_vlan_hdr));
WARNING:LONG_LINE: line over 90 characters
#2308: FILE: app/test/test_sched.c:89:
+ eth_hdr = (struct rte_ether_hdr *)((uintptr_t)ð_hdr->ether_type + 2 *sizeof(struct rte_vlan_hdr));
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#2308: FILE: app/test/test_sched.c:89:
+ eth_hdr = (struct rte_ether_hdr *)((uintptr_t)ð_hdr->ether_type + 2 *sizeof(struct rte_vlan_hdr));
^
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name
#2818: FILE: drivers/net/ark/ark_global.h:79:
+ void (*mac_addr_set)(struct rte_eth_dev *, struct rte_ether_addr *, void *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_ether_addr *' should also have an identifier name
#2818: FILE: drivers/net/ark/ark_global.h:79:
+ void (*mac_addr_set)(struct rte_eth_dev *, struct rte_ether_addr *, void *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#2818: FILE: drivers/net/ark/ark_global.h:79:
+ void (*mac_addr_set)(struct rte_eth_dev *, struct rte_ether_addr *, void *);
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#3276: FILE: drivers/net/bonding/rte_eth_bond_alb.c:75:
+void bond_mode_alb_arp_recv(struct rte_ether_hdr *eth_h, uint16_t offset,
struct bond_dev_private *internals) {
WARNING:LONG_LINE: line over 90 characters
#3320: FILE: drivers/net/bonding/rte_eth_bond_alb.c:166:
+ client_info->vlan_count = offset / sizeof(struct rte_vlan_hdr);
WARNING:LONG_LINE: line over 90 characters
#3615: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1130:
+ pkt_size = sizeof(struct rte_ether_hdr) + sizeof(struct rte_arp_hdr)
WARNING:LONG_LINE: line over 90 characters
#3616: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1131:
+ + client_info->vlan_count * sizeof(struct rte_vlan_hdr);
WARNING:LONG_LINE: line over 90 characters
#3625: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1162:
+ eth_h = rte_pktmbuf_mtod(slave_bufs[i][j], struct rte_ether_hdr *);
WARNING:LONG_LINE: line over 90 characters
#3634: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1179:
+ eth_h = rte_pktmbuf_mtod(update_bufs[i][j], struct rte_ether_hdr *);
CHECK:SPACING: No space is necessary after a cast
#3978: FILE: drivers/net/e1000/em_ethdev.c:296:
+ ether_addr_copy((struct rte_ether_addr *) hw->mac.addr,
WARNING:LONG_LINE: line over 90 characters
#4050: FILE: drivers/net/e1000/igb_ethdev.c:843:
+ ether_addr_copy((struct rte_ether_addr *)hw->mac.addr, ð_dev->data->mac_addrs[0]);
CHECK:SPACING: No space is necessary after a cast
#4068: FILE: drivers/net/e1000/igb_ethdev.c:1060:
+ ether_addr_copy((struct rte_ether_addr *) hw->mac.perm_addr,
CHECK:SPACING: No space is necessary after a cast
#4341: FILE: drivers/net/enic/enic_main.c:1676:
+ ether_addr_copy((struct rte_ether_addr *) enic->mac_addr,
CHECK:SPACING: No space is necessary after a cast
#4500: FILE: drivers/net/i40e/i40e_ethdev.c:1470:
+ ether_addr_copy((struct rte_ether_addr *) hw->mac.addr,
CHECK:SPACING: No space is necessary after a cast
#4501: FILE: drivers/net/i40e/i40e_ethdev.c:1471:
+ (struct rte_ether_addr *) hw->mac.perm_addr);
CHECK:SPACING: No space is necessary after a cast
#5406: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1225:
+ ether_addr_copy((struct rte_ether_addr *) hw->mac.perm_addr,
CHECK:SPACING: No space is necessary after a cast
#5424: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1564:
+ struct rte_ether_addr *perm_addr = (struct rte_ether_addr *) hw->mac.perm_addr;
CHECK:SPACING: No space is necessary after a cast
#5488: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:6065:
+ struct rte_ether_addr *perm_addr = (struct rte_ether_addr *) hw->mac.perm_addr;
CHECK:SPACING: No space is necessary after a cast
#6980: FILE: drivers/net/virtio/virtio_ethdev.c:1665:
+ ether_addr_copy((struct rte_ether_addr *) hw->mac_addr,
CHECK:SPACING: No space is necessary after a cast
#7024: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:314:
+ ether_addr_copy((struct rte_ether_addr *) hw->perm_addr,
WARNING:LONG_LINE: line over 90 characters
#7901: FILE: examples/ipv4_multicast/main.c:277:
+ ethdr = (struct rte_ether_hdr *)rte_pktmbuf_prepend(pkt, (uint16_t)sizeof(*ethdr));
WARNING:LONG_LINE: line over 90 characters
#7915: FILE: examples/ipv4_multicast/main.c:309:
+ iphdr = (struct ipv4_hdr *)rte_pktmbuf_adj(m, (uint16_t)sizeof(struct rte_ether_hdr));
total: 3 errors, 28 warnings, 8783 lines checked
parent reply other threads:[~2019-04-10 9:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190410083218.17531-4-olivier.matz@6wind.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410090237.5EE1B5B3C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).