From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-test-report] |WARNING| pw52644 [RFC PATCH] cmdline: add prefix to numeric type enums
Date: Thu, 11 Apr 2019 12:43:00 +0200 (CEST) [thread overview]
Message-ID: <20190411104300.111164F9C@dpdk.org> (raw)
In-Reply-To: <20190411104118.3221-1-bruce.richardson@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52644
_coding style issues_
ERROR:CODE_INDENT: code indent should use tabs where possible
#294: FILE: app/test-pmd/cmdline.c:3093:
+ TOKEN_NUM_INITIALIZER(struct cmd_config_dcb, num_tcs, RTE_UINT8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#294: FILE: app/test-pmd/cmdline.c:3093:
+ TOKEN_NUM_INITIALIZER(struct cmd_config_dcb, num_tcs, RTE_UINT8);$
WARNING:LONG_LINE: line over 90 characters
#697: FILE: app/test-pmd/cmdline.c:6371:
+ TOKEN_NUM_INITIALIZER(struct cmd_set_burst_tx_retry_result, retry_num, RTE_UINT32);
ERROR:CODE_INDENT: code indent should use tabs where possible
#3613: FILE: examples/qos_sched/cmdline.c:116:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3613: FILE: examples/qos_sched/cmdline.c:116:
+ RTE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3622: FILE: examples/qos_sched/cmdline.c:191:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3622: FILE: examples/qos_sched/cmdline.c:191:
+ RTE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3642: FILE: examples/qos_sched/cmdline.c:245:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3642: FILE: examples/qos_sched/cmdline.c:245:
+ RTE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3649: FILE: examples/qos_sched/cmdline.c:251:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3649: FILE: examples/qos_sched/cmdline.c:251:
+ RTE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3665: FILE: examples/qos_sched/cmdline.c:308:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3665: FILE: examples/qos_sched/cmdline.c:308:
+ RTE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3672: FILE: examples/qos_sched/cmdline.c:314:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3672: FILE: examples/qos_sched/cmdline.c:314:
+ RTE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3679: FILE: examples/qos_sched/cmdline.c:320:
+ RTE_UINT8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3679: FILE: examples/qos_sched/cmdline.c:320:
+ RTE_UINT8);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3686: FILE: examples/qos_sched/cmdline.c:326:
+ RTE_UINT8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3686: FILE: examples/qos_sched/cmdline.c:326:
+ RTE_UINT8);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3702: FILE: examples/qos_sched/cmdline.c:385:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3702: FILE: examples/qos_sched/cmdline.c:385:
+ RTE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3709: FILE: examples/qos_sched/cmdline.c:391:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3709: FILE: examples/qos_sched/cmdline.c:391:
+ RTE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3716: FILE: examples/qos_sched/cmdline.c:397:
+ RTE_UINT8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3716: FILE: examples/qos_sched/cmdline.c:397:
+ RTE_UINT8);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3732: FILE: examples/qos_sched/cmdline.c:452:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3732: FILE: examples/qos_sched/cmdline.c:452:
+ RTE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3739: FILE: examples/qos_sched/cmdline.c:458:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3739: FILE: examples/qos_sched/cmdline.c:458:
+ RTE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3755: FILE: examples/qos_sched/cmdline.c:511:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3755: FILE: examples/qos_sched/cmdline.c:511:
+ RTE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3762: FILE: examples/qos_sched/cmdline.c:517:
+ RTE_UINT8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3762: FILE: examples/qos_sched/cmdline.c:517:
+ RTE_UINT8);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3778: FILE: examples/qos_sched/cmdline.c:568:
+ RTE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3778: FILE: examples/qos_sched/cmdline.c:568:
+ RTE_UINT32);$
ERROR:SPACING: space prohibited after that open parenthesis '('
#3884: FILE: lib/librte_cmdline/cmdline_parse_num.c:262:
+ if ( nd.type == RTE_INT8 && res1 <= INT8_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3884: FILE: lib/librte_cmdline/cmdline_parse_num.c:262:
+ if ( nd.type == RTE_INT8 && res1 <= INT8_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3889: FILE: lib/librte_cmdline/cmdline_parse_num.c:266:
+ else if ( nd.type == RTE_INT16 && res1 <= INT16_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3889: FILE: lib/librte_cmdline/cmdline_parse_num.c:266:
+ else if ( nd.type == RTE_INT16 && res1 <= INT16_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3889: FILE: lib/librte_cmdline/cmdline_parse_num.c:266:
}
+ else if ( nd.type == RTE_INT16 && res1 <= INT16_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3894: FILE: lib/librte_cmdline/cmdline_parse_num.c:270:
+ else if ( nd.type == RTE_INT32 && res1 <= INT32_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3894: FILE: lib/librte_cmdline/cmdline_parse_num.c:270:
+ else if ( nd.type == RTE_INT32 && res1 <= INT32_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3894: FILE: lib/librte_cmdline/cmdline_parse_num.c:270:
}
+ else if ( nd.type == RTE_INT32 && res1 <= INT32_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3899: FILE: lib/librte_cmdline/cmdline_parse_num.c:274:
+ else if ( nd.type == RTE_INT64 && res1 <= INT64_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3899: FILE: lib/librte_cmdline/cmdline_parse_num.c:274:
+ else if ( nd.type == RTE_INT64 && res1 <= INT64_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3899: FILE: lib/librte_cmdline/cmdline_parse_num.c:274:
}
+ else if ( nd.type == RTE_INT64 && res1 <= INT64_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3904: FILE: lib/librte_cmdline/cmdline_parse_num.c:278:
+ else if ( nd.type == RTE_UINT8 && res1 <= UINT8_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3904: FILE: lib/librte_cmdline/cmdline_parse_num.c:278:
+ else if ( nd.type == RTE_UINT8 && res1 <= UINT8_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3904: FILE: lib/librte_cmdline/cmdline_parse_num.c:278:
}
+ else if ( nd.type == RTE_UINT8 && res1 <= UINT8_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3909: FILE: lib/librte_cmdline/cmdline_parse_num.c:282:
+ else if (nd.type == RTE_UINT16 && res1 <= UINT16_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3909: FILE: lib/librte_cmdline/cmdline_parse_num.c:282:
}
+ else if (nd.type == RTE_UINT16 && res1 <= UINT16_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3914: FILE: lib/librte_cmdline/cmdline_parse_num.c:286:
+ else if ( nd.type == RTE_UINT32 && res1 <= UINT32_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3914: FILE: lib/librte_cmdline/cmdline_parse_num.c:286:
+ else if ( nd.type == RTE_UINT32 && res1 <= UINT32_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3914: FILE: lib/librte_cmdline/cmdline_parse_num.c:286:
}
+ else if ( nd.type == RTE_UINT32 && res1 <= UINT32_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3919: FILE: lib/librte_cmdline/cmdline_parse_num.c:290:
+ else if ( nd.type == RTE_UINT64 ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3919: FILE: lib/librte_cmdline/cmdline_parse_num.c:290:
+ else if ( nd.type == RTE_UINT64 ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3919: FILE: lib/librte_cmdline/cmdline_parse_num.c:290:
}
+ else if ( nd.type == RTE_UINT64 ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3928: FILE: lib/librte_cmdline/cmdline_parse_num.c:300:
+ if ( nd.type == RTE_INT8 && res1 <= INT8_MAX + 1 ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3928: FILE: lib/librte_cmdline/cmdline_parse_num.c:300:
+ if ( nd.type == RTE_INT8 && res1 <= INT8_MAX + 1 ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3933: FILE: lib/librte_cmdline/cmdline_parse_num.c:304:
+ else if ( nd.type == RTE_INT16 && res1 <= (uint16_t)INT16_MAX + 1 ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3933: FILE: lib/librte_cmdline/cmdline_parse_num.c:304:
+ else if ( nd.type == RTE_INT16 && res1 <= (uint16_t)INT16_MAX + 1 ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3933: FILE: lib/librte_cmdline/cmdline_parse_num.c:304:
}
+ else if ( nd.type == RTE_INT16 && res1 <= (uint16_t)INT16_MAX + 1 ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3938: FILE: lib/librte_cmdline/cmdline_parse_num.c:308:
+ else if ( nd.type == RTE_INT32 && res1 <= (uint32_t)INT32_MAX + 1 ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3938: FILE: lib/librte_cmdline/cmdline_parse_num.c:308:
+ else if ( nd.type == RTE_INT32 && res1 <= (uint32_t)INT32_MAX + 1 ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3938: FILE: lib/librte_cmdline/cmdline_parse_num.c:308:
}
+ else if ( nd.type == RTE_INT32 && res1 <= (uint32_t)INT32_MAX + 1 ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3943: FILE: lib/librte_cmdline/cmdline_parse_num.c:312:
+ else if ( nd.type == RTE_INT64 && res1 <= (uint64_t)INT64_MAX + 1 ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3943: FILE: lib/librte_cmdline/cmdline_parse_num.c:312:
+ else if ( nd.type == RTE_INT64 && res1 <= (uint64_t)INT64_MAX + 1 ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3943: FILE: lib/librte_cmdline/cmdline_parse_num.c:312:
}
+ else if ( nd.type == RTE_INT64 && res1 <= (uint64_t)INT64_MAX + 1 ) {
total: 50 errors, 18 warnings, 3595 lines checked
parent reply other threads:[~2019-04-11 10:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190411104118.3221-1-bruce.richardson@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411104300.111164F9C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=bruce.richardson@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).