From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4EC20A0096 for ; Fri, 12 Apr 2019 09:05:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD2FA6833; Fri, 12 Apr 2019 09:05:20 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 4AA254F9A; Fri, 12 Apr 2019 09:05:17 +0200 (CEST) In-Reply-To: <1555075598-4988-10-git-send-email-g.singh@nxp.com> References: <1555075598-4988-10-git-send-email-g.singh@nxp.com> To: test-report@dpdk.org Cc: Gagandeep Singh Message-Id: <20190412070517.4AA254F9A@dpdk.org> Date: Fri, 12 Apr 2019 09:05:17 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw52674 [PATCH v2 09/13] net/enetc: add MTU update and jumbo frames support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/52674 _coding style issues_ ERROR:DOS_LINE_ENDINGS: DOS line endings #38: FILE: doc/guides/nics/enetc.rst:52: +- Jumbo packets^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #50: FILE: doc/guides/nics/features/enetc.ini:12: +MTU update = Y^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #51: FILE: doc/guides/nics/features/enetc.ini:13: +Jumbo frame = Y^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #64: FILE: drivers/net/enetc/base/enetc_hw.h:102: +#define ENETC_SET_TX_MTU(val)^I^I((val) << 16)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #65: FILE: drivers/net/enetc/base/enetc_hw.h:103: +#define ENETC_SET_MAXFRM(val)^I^I((val) & 0xffff)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #66: FILE: drivers/net/enetc/base/enetc_hw.h:104: +#define ENETC_PTXMBAR^I^I^I0x0608^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #67: FILE: drivers/net/enetc/base/enetc_hw.h:105: +/* n = TC index [0..7] */^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #68: FILE: drivers/net/enetc/base/enetc_hw.h:106: +#define ENETC_PTCMSDUR(n)^I^I(0x2020 + (n) * 4)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #80: FILE: drivers/net/enetc/enetc.h:27: +/* minimum frame size supported */^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #81: FILE: drivers/net/enetc/enetc.h:28: +#define ENETC_MAC_MINFRM_SIZE^I68^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #82: FILE: drivers/net/enetc/enetc.h:29: +/* maximum frame size supported */^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #83: FILE: drivers/net/enetc/enetc.h:30: +#define ENETC_MAC_MAXFRM_SIZE^I9600^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #84: FILE: drivers/net/enetc/enetc.h:31: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #111: FILE: drivers/net/enetc/enetc_ethdev.c:164: +^Idev_info->max_rx_pktlen = ENETC_MAC_MAXFRM_SIZE;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #112: FILE: drivers/net/enetc/enetc_ethdev.c:165: +^Idev_info->rx_offload_capa = DEV_RX_OFFLOAD_JUMBO_FRAME;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #120: FILE: drivers/net/enetc/enetc_ethdev.c:594: +static int^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #121: FILE: drivers/net/enetc/enetc_ethdev.c:595: +enetc_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #122: FILE: drivers/net/enetc/enetc_ethdev.c:596: +{^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #123: FILE: drivers/net/enetc/enetc_ethdev.c:597: +^Istruct enetc_eth_hw *hw =^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #124: FILE: drivers/net/enetc/enetc_ethdev.c:598: +^I^IENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #125: FILE: drivers/net/enetc/enetc_ethdev.c:599: +^Istruct enetc_hw *enetc_hw = &hw->hw;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #126: FILE: drivers/net/enetc/enetc_ethdev.c:600: +^Iuint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #127: FILE: drivers/net/enetc/enetc_ethdev.c:601: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #128: FILE: drivers/net/enetc/enetc_ethdev.c:602: +^I/* check that mtu is within the allowed range */^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #129: FILE: drivers/net/enetc/enetc_ethdev.c:603: +^Iif (mtu < ENETC_MAC_MINFRM_SIZE || frame_size > ENETC_MAC_MAXFRM_SIZE)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #130: FILE: drivers/net/enetc/enetc_ethdev.c:604: +^I^Ireturn -EINVAL;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #131: FILE: drivers/net/enetc/enetc_ethdev.c:605: +^M$ ERROR:TRAILING_WHITESPACE: trailing whitespace #132: FILE: drivers/net/enetc/enetc_ethdev.c:606: +^I/*^M$ ERROR:TRAILING_WHITESPACE: trailing whitespace #133: FILE: drivers/net/enetc/enetc_ethdev.c:607: +^I * Refuse mtu that requires the support of scattered packets^M$ ERROR:TRAILING_WHITESPACE: trailing whitespace #134: FILE: drivers/net/enetc/enetc_ethdev.c:608: +^I * when this feature has not been enabled before.^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #135: FILE: drivers/net/enetc/enetc_ethdev.c:609: +^I */^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #136: FILE: drivers/net/enetc/enetc_ethdev.c:610: +^Iif (dev->data->min_rx_buf_size &&^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #137: FILE: drivers/net/enetc/enetc_ethdev.c:611: +^I^I!dev->data->scattered_rx && frame_size >^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #138: FILE: drivers/net/enetc/enetc_ethdev.c:612: +^I^Idev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM) {^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #139: FILE: drivers/net/enetc/enetc_ethdev.c:613: +^I^IENETC_PMD_ERR("SG not enabled, will not fit in one buffer");^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #140: FILE: drivers/net/enetc/enetc_ethdev.c:614: +^I^Ireturn -EINVAL;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #141: FILE: drivers/net/enetc/enetc_ethdev.c:615: +^I}^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #142: FILE: drivers/net/enetc/enetc_ethdev.c:616: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #143: FILE: drivers/net/enetc/enetc_ethdev.c:617: +^Iif (frame_size > ETHER_MAX_LEN)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #144: FILE: drivers/net/enetc/enetc_ethdev.c:618: +^I^Idev->data->dev_conf.rxmode.offloads &=^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #145: FILE: drivers/net/enetc/enetc_ethdev.c:619: +^I^I^I^I^I^IDEV_RX_OFFLOAD_JUMBO_FRAME;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #146: FILE: drivers/net/enetc/enetc_ethdev.c:620: +^Ielse^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #147: FILE: drivers/net/enetc/enetc_ethdev.c:621: +^I^Idev->data->dev_conf.rxmode.offloads &=^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #148: FILE: drivers/net/enetc/enetc_ethdev.c:622: +^I^I^I^I^I^I~DEV_RX_OFFLOAD_JUMBO_FRAME;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #149: FILE: drivers/net/enetc/enetc_ethdev.c:623: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #150: FILE: drivers/net/enetc/enetc_ethdev.c:624: +^Ienetc_port_wr(enetc_hw, ENETC_PTCMSDUR(0), ENETC_MAC_MAXFRM_SIZE);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #151: FILE: drivers/net/enetc/enetc_ethdev.c:625: +^Ienetc_port_wr(enetc_hw, ENETC_PTXMBAR, 2 * ENETC_MAC_MAXFRM_SIZE);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #152: FILE: drivers/net/enetc/enetc_ethdev.c:626: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #153: FILE: drivers/net/enetc/enetc_ethdev.c:627: +^Idev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #154: FILE: drivers/net/enetc/enetc_ethdev.c:628: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #155: FILE: drivers/net/enetc/enetc_ethdev.c:629: +^I/*setting the MTU*/^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #156: FILE: drivers/net/enetc/enetc_ethdev.c:630: +^Ienetc_port_wr(enetc_hw, ENETC_PM0_MAXFRM, ENETC_SET_MAXFRM(frame_size) |^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #157: FILE: drivers/net/enetc/enetc_ethdev.c:631: +^I^I ENETC_SET_TX_MTU(ENETC_MAC_MAXFRM_SIZE));^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #158: FILE: drivers/net/enetc/enetc_ethdev.c:632: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #159: FILE: drivers/net/enetc/enetc_ethdev.c:633: +^Ireturn 0;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #160: FILE: drivers/net/enetc/enetc_ethdev.c:634: +}^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #161: FILE: drivers/net/enetc/enetc_ethdev.c:635: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #162: FILE: drivers/net/enetc/enetc_ethdev.c:636: +static int^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #163: FILE: drivers/net/enetc/enetc_ethdev.c:637: +enetc_dev_configure(struct rte_eth_dev *dev)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #164: FILE: drivers/net/enetc/enetc_ethdev.c:638: +{^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #165: FILE: drivers/net/enetc/enetc_ethdev.c:639: +^Istruct rte_eth_conf *eth_conf = &dev->data->dev_conf;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #166: FILE: drivers/net/enetc/enetc_ethdev.c:640: +^Iuint64_t rx_offloads = eth_conf->rxmode.offloads;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #167: FILE: drivers/net/enetc/enetc_ethdev.c:641: +^Istruct enetc_eth_hw *hw =^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #168: FILE: drivers/net/enetc/enetc_ethdev.c:642: +^I^IENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #169: FILE: drivers/net/enetc/enetc_ethdev.c:643: +^Istruct enetc_hw *enetc_hw = &hw->hw;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #170: FILE: drivers/net/enetc/enetc_ethdev.c:644: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #171: FILE: drivers/net/enetc/enetc_ethdev.c:645: +^IPMD_INIT_FUNC_TRACE();^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #172: FILE: drivers/net/enetc/enetc_ethdev.c:646: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #173: FILE: drivers/net/enetc/enetc_ethdev.c:647: +^Iif (rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #174: FILE: drivers/net/enetc/enetc_ethdev.c:648: +^I^Iuint32_t max_len;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #175: FILE: drivers/net/enetc/enetc_ethdev.c:649: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #176: FILE: drivers/net/enetc/enetc_ethdev.c:650: +^I^Imax_len = dev->data->dev_conf.rxmode.max_rx_pkt_len;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #177: FILE: drivers/net/enetc/enetc_ethdev.c:651: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #178: FILE: drivers/net/enetc/enetc_ethdev.c:652: +^I^Ienetc_port_wr(enetc_hw, ENETC_PM0_MAXFRM,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #179: FILE: drivers/net/enetc/enetc_ethdev.c:653: +^I^I^I ENETC_SET_MAXFRM(max_len));^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #180: FILE: drivers/net/enetc/enetc_ethdev.c:654: +^I^Ienetc_port_wr(enetc_hw, ENETC_PTCMSDUR(0),^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #181: FILE: drivers/net/enetc/enetc_ethdev.c:655: +^I^I^I ENETC_MAC_MAXFRM_SIZE);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #182: FILE: drivers/net/enetc/enetc_ethdev.c:656: +^I^Ienetc_port_wr(enetc_hw, ENETC_PTXMBAR,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #183: FILE: drivers/net/enetc/enetc_ethdev.c:657: +^I^I^I 2 * ENETC_MAC_MAXFRM_SIZE);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #184: FILE: drivers/net/enetc/enetc_ethdev.c:658: +^I^Idev->data->mtu = ETHER_MAX_LEN - ETHER_HDR_LEN - ETHER_CRC_LEN;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #185: FILE: drivers/net/enetc/enetc_ethdev.c:659: +^I}^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #186: FILE: drivers/net/enetc/enetc_ethdev.c:660: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #187: FILE: drivers/net/enetc/enetc_ethdev.c:661: +^Ireturn 0;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #188: FILE: drivers/net/enetc/enetc_ethdev.c:662: +}^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #189: FILE: drivers/net/enetc/enetc_ethdev.c:663: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #197: FILE: drivers/net/enetc/enetc_ethdev.c:687: +^I.mtu_set = enetc_mtu_set,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #205: FILE: drivers/net/enetc/enetc_ethdev.c:742: +^I/* Set MTU */^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #206: FILE: drivers/net/enetc/enetc_ethdev.c:743: +^Ienetc_port_wr(&hw->hw, ENETC_PM0_MAXFRM,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #207: FILE: drivers/net/enetc/enetc_ethdev.c:744: +^I^I ENETC_SET_MAXFRM(ETHER_MAX_LEN));^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #208: FILE: drivers/net/enetc/enetc_ethdev.c:745: +^Ieth_dev->data->mtu = ETHER_MAX_LEN - ETHER_HDR_LEN - ETHER_CRC_LEN;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #209: FILE: drivers/net/enetc/enetc_ethdev.c:746: +^M$ total: 91 errors, 0 warnings, 0 checks, 154 lines checked