[dpdk-test-report] |WARNING| pw52949 [PATCH v2] net/vmxnet3: v4 boot and guest UDP RSS configuration

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Eduard Serra Miralles <eserra@vmware.com>
Subject: [dpdk-test-report] |WARNING| pw52949 [PATCH v2] net/vmxnet3: v4 boot and guest UDP RSS configuration
Date: Thu, 18 Apr 2019 23:01:14 +0200 (CEST)	[thread overview]
Message-ID: <20190418210114.BE65C1BCA6@dpdk.org> (raw)
In-Reply-To: <1555621175-103437-1-git-send-email-eserra@vmware.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52949

_coding style issues_


ERROR:DOS_LINE_ENDINGS: DOS line endings
#57: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:92:
+   VMXNET3_CMD_SET_RSS_FIELDS,^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#57: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:92:
+   VMXNET3_CMD_SET_RSS_FIELDS,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#65: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:753:
+typedef enum Vmxnet3_RSSField {^M$

CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_RSSField>
#65: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:753:
+typedef enum Vmxnet3_RSSField {

ERROR:DOS_LINE_ENDINGS: DOS line endings
#66: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:754:
+   VMXNET3_RSS_FIELDS_TCPIP4 = 0x0001,^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#66: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:754:
+   VMXNET3_RSS_FIELDS_TCPIP4 = 0x0001,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#67: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:755:
+   VMXNET3_RSS_FIELDS_TCPIP6 = 0x0002,^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#67: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:755:
+   VMXNET3_RSS_FIELDS_TCPIP6 = 0x0002,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#68: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:756:
+   VMXNET3_RSS_FIELDS_UDPIP4 = 0x0004,^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#68: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:756:
+   VMXNET3_RSS_FIELDS_UDPIP4 = 0x0004,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#69: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:757:
+   VMXNET3_RSS_FIELDS_UDPIP6 = 0x0008,^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#69: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:757:
+   VMXNET3_RSS_FIELDS_UDPIP6 = 0x0008,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#70: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:758:
+   VMXNET3_RSS_FIELDS_ESPIP4 = 0x0010,^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#70: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:758:
+   VMXNET3_RSS_FIELDS_ESPIP4 = 0x0010,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#71: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:759:
+   VMXNET3_RSS_FIELDS_ESPIP6 = 0x0020,^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#71: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:759:
+   VMXNET3_RSS_FIELDS_ESPIP6 = 0x0020,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#72: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:760:
+} Vmxnet3_RSSField;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#73: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:761:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#81: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:771:
+   Vmxnet3_RSSField            setRSSFields;^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#81: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:771:
+   Vmxnet3_RSSField            setRSSFields;^M$

CHECK:CAMELCASE: Avoid CamelCase: <setRSSFields>
#81: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:771:
+   Vmxnet3_RSSField            setRSSFields;

ERROR:DOS_LINE_ENDINGS: DOS line endings
#82: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:772:
+   __le16                      reserved[2];^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#82: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:772:
+   __le16                      reserved[2];^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#95: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:269:
+^Iif (ver & (1 << VMXNET3_REV_4)) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#96: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:270:
+^I^IVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_VRRS,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#97: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:271:
+^I^I^I^I       1 << VMXNET3_REV_4);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#98: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:272:
+^I^Ihw->version = VMXNET3_REV_4 + 1;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#99: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:273:
+^I} else if (ver & (1 << VMXNET3_REV_3)) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#107: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:771:
+^Iif (VMXNET3_VERSION_GE_4(hw)) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#108: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:772:
+^I^I/* Check for additional RSS  */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#109: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:773:
+^I^Iret = vmxnet3_v4_rss_configure(dev);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#110: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:774:
+^I^Iif (ret != VMXNET3_SUCCESS) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#111: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:775:
+^I^I^IPMD_INIT_LOG(ERR, "Failed to configure v4 RSS");^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#112: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:776:
+^I^I^Ireturn ret;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#113: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:777:
+^I^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#114: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:778:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#115: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:779:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#123: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1157:
+^Istruct vmxnet3_hw *hw = dev->data->dev_private;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#124: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1158:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#132: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1168:
+^Iif (VMXNET3_VERSION_GE_4(hw)) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#133: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1169:
+^I^Idev_info->flow_type_rss_offloads |= VMXNET3_V4_RSS_MASK;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#134: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1170:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#135: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1171:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#147: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:37:
+#define VMXNET3_V4_RSS_MASK ( \^M$

ERROR:SPACING: space prohibited after that open parenthesis '('
#147: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:37:
+#define VMXNET3_V4_RSS_MASK ( \

WARNING:WHITESPACE_AFTER_LINE_CONTINUATION: Whitespace after \ makes next lines useless
#147: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:37:
+#define VMXNET3_V4_RSS_MASK ( \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#147: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:37:
+#define VMXNET3_V4_RSS_MASK ( \

ERROR:DOS_LINE_ENDINGS: DOS line endings
#148: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:38:
+^IETH_RSS_NONFRAG_IPV4_UDP | \^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#149: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:39:
+^IETH_RSS_NONFRAG_IPV6_UDP)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#150: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:40:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#158: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:110:
+#define VMXNET3_REV_4^I^I3^I^I/* Vmxnet3 Rev. 4 */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#163: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:115:
+#define VMXNET3_VERSION_GE_4(hw) ((hw)->version >= VMXNET3_REV_4 + 1)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#171: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:171:
+int vmxnet3_v4_rss_configure(struct rte_eth_dev *dev);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#172: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:172:
+^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#184: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1295:
+ * Additional RSS configurations based on vmxnet v4+ APIs^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#185: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1296:
+ */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#186: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1297:
+int^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#187: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1298:
+vmxnet3_v4_rss_configure(struct rte_eth_dev *dev)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#188: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1299:
+{^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#189: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1300:
+^Istruct vmxnet3_hw *hw = dev->data->dev_private;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#190: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1301:
+^IVmxnet3_DriverShared *shared = hw->shared;^M$

CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_DriverShared>
#190: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1301:
+	Vmxnet3_DriverShared *shared = hw->shared;

ERROR:DOS_LINE_ENDINGS: DOS line endings
#191: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1302:
+^IVmxnet3_CmdInfo *cmdInfo = &shared->cu.cmdInfo;^M$

CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_CmdInfo>
#191: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1302:
+	Vmxnet3_CmdInfo *cmdInfo = &shared->cu.cmdInfo;

CHECK:CAMELCASE: Avoid CamelCase: <cmdInfo>
#191: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1302:
+	Vmxnet3_CmdInfo *cmdInfo = &shared->cu.cmdInfo;

ERROR:DOS_LINE_ENDINGS: DOS line endings
#192: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1303:
+^Istruct rte_eth_rss_conf *port_rss_conf;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#193: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1304:
+^Iuint64_t rss_hf;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#194: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1305:
+^Iuint32_t ret;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#195: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1306:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#196: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1307:
+^IPMD_INIT_FUNC_TRACE();^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#197: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1308:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#198: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1309:
+^IcmdInfo->setRSSFields = 0;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#199: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1310:
+^Iport_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#200: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1311:
+^Irss_hf = port_rss_conf->rss_hf &^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#201: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1312:
+^I^I(VMXNET3_V4_RSS_MASK | VMXNET3_RSS_OFFLOAD_ALL);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#202: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1313:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#203: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1314:
+^Iif (rss_hf & ETH_RSS_NONFRAG_IPV4_TCP)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#204: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1315:
+^I^IcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_TCPIP4;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#205: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1316:
+^Iif (rss_hf & ETH_RSS_NONFRAG_IPV6_TCP)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#206: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1317:
+^I^IcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_TCPIP6;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#207: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1318:
+^Iif (rss_hf & ETH_RSS_NONFRAG_IPV4_UDP)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#208: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1319:
+^I^IcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_UDPIP4;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#209: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1320:
+^Iif (rss_hf & ETH_RSS_NONFRAG_IPV6_UDP)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#210: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1321:
+^I^IcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_UDPIP6;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#211: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1322:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#212: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1323:
+^IVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#213: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1324:
+^I^I^I       VMXNET3_CMD_SET_RSS_FIELDS);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#214: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1325:
+^Iret = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#215: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1326:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#216: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1327:
+^Iif (ret != VMXNET3_SUCCESS) {^M$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#216: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1327:
+	if (ret != VMXNET3_SUCCESS) {
+		PMD_DRV_LOG(ERR, "Set RSS fields (v4) failed: %d", ret);
+	}

ERROR:DOS_LINE_ENDINGS: DOS line endings
#217: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1328:
+^I^IPMD_DRV_LOG(ERR, "Set RSS fields (v4) failed: %d", ret);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#218: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1329:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#219: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1330:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#220: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1331:
+^Ireturn ret;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#221: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1332:
+}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#222: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1333:
+^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#223: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1334:
+/*^M$

total: 82 errors, 11 warnings, 5 checks, 151 lines checked

          parent reply	other threads:[~2019-04-18 21:01 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1555621175-103437-1-git-send-email-eserra@vmware.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190418210114.BE65C1BCA6@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=eserra@vmware.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).