From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EC44CA0679 for ; Mon, 29 Apr 2019 10:20:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D9CB1B3FD; Mon, 29 Apr 2019 10:20:54 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id EDE9F1B29A; Mon, 29 Apr 2019 10:20:34 +0200 (CEST) In-Reply-To: <8daab002f486a50a0ad1aa02cd39513c732c94b8.1556525874.git.igor.russkikh@aquantia.com> References: <8daab002f486a50a0ad1aa02cd39513c732c94b8.1556525874.git.igor.russkikh@aquantia.com> To: test-report@dpdk.org Cc: Igor Russkikh Message-Id: <20190429082034.EDE9F1B29A@dpdk.org> Date: Mon, 29 Apr 2019 10:20:34 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw53134 [PATCH 04/11] net/atlantic: eeprom get/set should consider offset X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/53134 _coding style issues_ ERROR:DOS_LINE_ENDINGS: DOS line endings #46: FILE: drivers/net/atlantic/atl_ethdev.c:1451: +^Iif (eeprom->length + eeprom->offset > SFP_EEPROM_SIZE ||^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #47: FILE: drivers/net/atlantic/atl_ethdev.c:1452: +^I eeprom->data == NULL)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #55: FILE: drivers/net/atlantic/atl_ethdev.c:1458: +^Ireturn hw->aq_fw_ops->set_eeprom(hw, dev_addr, eeprom->data,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #56: FILE: drivers/net/atlantic/atl_ethdev.c:1459: +^I^I^I^I^I eeprom->length, eeprom->offset);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #69: FILE: drivers/net/atlantic/atl_types.h:180: +^I^I^I u32 *data, u32 len, u32 offset);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #90: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:340: +struct smbus_request {^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #91: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:341: +^Iu32 msg_id; /* not used */^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #106: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:501: +^Iu32 bytes_remains = len % sizeof(u32);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #107: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:502: +^Iu32 num_dwords = len / sizeof(u32);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #108: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:503: +^Istruct smbus_request request;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #110: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:505: +^Iu32 mpi_opts;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #111: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:506: +^Iint err = 0;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #116: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:511: +^Irequest.msg_id = 0;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #127: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:546: +^Iif (result)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #128: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:547: +^I^Ireturn -EIO;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #135: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:549: +^Iif (num_dwords) {^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #136: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:550: +^I^Ierr = hw_atl_utils_fw_downld_dwords(self,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #137: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:551: +^I^I^Iself->rpc_addr + sizeof(u32) * 2,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #138: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:552: +^I^I^Idata,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #139: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:553: +^I^I^Inum_dwords);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #144: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:555: +^I^Iif (err < 0)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #145: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:556: +^I^I^Ireturn err;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #146: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:557: +^I}^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #150: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:559: +^Iif (bytes_remains) {^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #151: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:560: +^I^Iu32 val = 0;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #157: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:562: +^I^Ierr = hw_atl_utils_fw_downld_dwords(self,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #158: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:563: +^I^I^Iself->rpc_addr + (sizeof(u32) * 2) +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #159: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:564: +^I^I^I(num_dwords * sizeof(u32)),^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #160: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:565: +^I^I^I&val,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #161: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:566: +^I^I^I1);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #165: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:568: +^I^Iif (err < 0)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #166: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:569: +^I^I^Ireturn err;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #171: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:571: +^I^Irte_memcpy((u8 *)data + len - bytes_remains,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #172: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:572: +^I^I^I^I&val, bytes_remains);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #181: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:580: +^I^I^I u32 *data, u32 len, u32 offset)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #184: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:582: +^Istruct smbus_request request;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #191: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:589: +^Irequest.msg_id = 0;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #194: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:591: +^Irequest.address = offset;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #206: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:603: +^Iu32 num_dwords = len / sizeof(u32);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #207: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:604: +^Iu32 bytes_remains = len % sizeof(u32);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #211: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:606: +^Iif (num_dwords) {^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #212: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:607: +^I^Ierr = hw_atl_utils_fw_upload_dwords(self,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #213: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:608: +^I^I^Iself->rpc_addr + sizeof(request),^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #214: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:609: +^I^I^I(u32 *)(void *)data,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #215: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:610: +^I^I^Inum_dwords);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #216: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:611: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #217: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:612: +^I^Iif (err < 0)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #218: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:613: +^I^I^Ireturn err;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #219: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:614: +^I}^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #220: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:615: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #221: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:616: +^Iif (bytes_remains) {^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #222: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:617: +^I^Iu32 val = 0;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #223: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:618: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #224: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:619: +^I^Irte_memcpy(&val, (u8 *)data + (sizeof(u32) * num_dwords),^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #225: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:620: +^I^I^I bytes_remains);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #226: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:621: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #227: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:622: +^I^Ierr = hw_atl_utils_fw_upload_dwords(self,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #228: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:623: +^I^I^Iself->rpc_addr + sizeof(request) +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #229: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:624: +^I^I^I(num_dwords * sizeof(u32)),^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #230: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:625: +^I^I^I&val,^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #231: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:626: +^I^I^I1);^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #232: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:627: +^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #233: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:628: +^I^Iif (err < 0)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #234: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:629: +^I^I^Ireturn err;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #235: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:630: +^I}^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #243: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:654: +^Iif (result)^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #244: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:655: +^I^Ireturn -EIO;^M$ ERROR:DOS_LINE_ENDINGS: DOS line endings #245: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:656: +^M$ total: 68 errors, 0 warnings, 0 checks, 188 lines checked