From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ziyang Xuan <xuanziyang2@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw53563 [PATCH 05/11] net/hinic/base: add eqs and context code
Date: Tue, 21 May 2019 10:10:48 +0200 (CEST) [thread overview]
Message-ID: <20190521081048.BCEB74C96@dpdk.org> (raw)
In-Reply-To: <1558426836-187132-1-git-send-email-xuanziyang2@huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53563
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'max_sge' - possible side-effects?
#58: FILE: drivers/net/hinic/base/hinic_ctx_def.h:20:
+#define MAX_WQE_SIZE(max_sge, wqebb_size) \
+ ((max_sge <= 2) ? (wqebb_size) : \
+ ((ALIGN(((max_sge) - 2), 4) / 4 + 1) * (wqebb_size)))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'max_sge' may be better as '(max_sge)' to avoid precedence issues
#58: FILE: drivers/net/hinic/base/hinic_ctx_def.h:20:
+#define MAX_WQE_SIZE(max_sge, wqebb_size) \
+ ((max_sge <= 2) ? (wqebb_size) : \
+ ((ALIGN(((max_sge) - 2), 4) / 4 + 1) * (wqebb_size)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wqebb_size' - possible side-effects?
#58: FILE: drivers/net/hinic/base/hinic_ctx_def.h:20:
+#define MAX_WQE_SIZE(max_sge, wqebb_size) \
+ ((max_sge <= 2) ? (wqebb_size) : \
+ ((ALIGN(((max_sge) - 2), 4) / 4 + 1) * (wqebb_size)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'max_sqs' - possible side-effects?
#81: FILE: drivers/net/hinic/base/hinic_ctx_def.h:43:
+#define RQ_CTXT_OFFSET(max_sqs, max_rqs, q_id) \
+ (((max_rqs) + (max_sqs)) * TSO_LRO_CTXT_SIZE \
+ + (max_sqs) * Q_CTXT_SIZE + (q_id) * Q_CTXT_SIZE)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#499: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:99:
+#define EQ_CONS_IDX(eq) ((eq)->cons_idx | \
+ ((u32)(eq)->wrapped << EQ_WRAPPED_SHIFT))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#502: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:102:
+#define EQ_CONS_IDX_REG_ADDR(eq) (((eq)->type == HINIC_AEQ) ? \
+ HINIC_CSR_AEQ_CONS_IDX_ADDR((eq)->q_id) :\
+ HINIC_CSR_CEQ_CONS_IDX_ADDR((eq)->q_id))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#506: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:106:
+#define EQ_PROD_IDX_REG_ADDR(eq) (((eq)->type == HINIC_AEQ) ? \
+ HINIC_CSR_AEQ_PROD_IDX_ADDR((eq)->q_id) :\
+ HINIC_CSR_CEQ_PROD_IDX_ADDR((eq)->q_id))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#510: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:110:
+#define GET_EQ_NUM_PAGES(eq, size) \
+ ((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \
+ / (size)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects?
#510: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:110:
+#define GET_EQ_NUM_PAGES(eq, size) \
+ ((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \
+ / (size)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#516: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:116:
+#define GET_EQ_ELEMENT(eq, idx) \
+ (((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+ (((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#516: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:116:
+#define GET_EQ_ELEMENT(eq, idx) \
+ (((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+ (((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#525: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:125:
+#define GET_CURR_AEQ_ELEM(eq) GET_AEQ_ELEM((eq), (eq)->cons_idx)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#527: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:127:
+#define GET_CURR_CEQ_ELEM(eq) GET_CEQ_ELEM((eq), (eq)->cons_idx)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#553: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:153:
+#define aeq_to_aeqs(eq) \
+ container_of((eq) - (eq)->q_id, struct hinic_aeqs, aeq[0])
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#767: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:367:
+ eq->virt_addr[pg_num] = (u8 *)dma_zalloc_coherent_aligned(
total: 0 errors, 0 warnings, 15 checks, 1180 lines checked
parent reply other threads:[~2019-05-21 8:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1558426836-187132-1-git-send-email-xuanziyang2@huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521081048.BCEB74C96@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=xuanziyang2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).