From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ziyang Xuan <xuanziyang2@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw53568 [PATCH 10/11] net/hinic: add TX module
Date: Tue, 21 May 2019 10:14:23 +0200 (CEST) [thread overview]
Message-ID: <20190521081423.2E1AC5B38@dpdk.org> (raw)
In-Reply-To: <1558427054-187378-1-git-send-email-xuanziyang2@huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53568
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw_ci == sw_ci'
#469: FILE: drivers/net/hinic/hinic_pmd_tx.c:424:
+ if ((hw_ci == sw_ci) ||
+ (((hw_ci - sw_ci) & sq_mask) < tx_info->wqebb_cnt))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->pool != mbuf_free[0]->pool'
#491: FILE: drivers/net/hinic/hinic_pmd_tx.c:446:
+ if (unlikely((m->pool != mbuf_free[0]->pool) ||
+ (nb_free >= HINIC_MAX_TX_FREE_BULK))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_free >= HINIC_MAX_TX_FREE_BULK'
#491: FILE: drivers/net/hinic/hinic_pmd_tx.c:446:
+ if (unlikely((m->pool != mbuf_free[0]->pool) ||
+ (nb_free >= HINIC_MAX_TX_FREE_BULK))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->tso_segsz == 0'
#579: FILE: drivers/net/hinic/hinic_pmd_tx.c:534:
+ if ((m->tso_segsz == 0) ||
+ ((ol_flags & PKT_TX_IPV4) &&
+ !(ol_flags & PKT_TX_IP_CKSUM)))
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#617: FILE: drivers/net/hinic/hinic_pmd_tx.c:572:
+ rte_cpu_to_be_16(
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#715: FILE: drivers/net/hinic/hinic_pmd_tx.c:670:
+ if (eth_type == ETHER_TYPE_IPv4) {
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#725: FILE: drivers/net/hinic/hinic_pmd_tx.c:680:
+ } else if (eth_type == ETHER_TYPE_IPv6) {
total: 0 errors, 0 warnings, 7 checks, 1044 lines checked
parent reply other threads:[~2019-05-21 8:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1558427054-187378-1-git-send-email-xuanziyang2@huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521081423.2E1AC5B38@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=xuanziyang2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).