From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D556EA05D3 for ; Tue, 21 May 2019 10:14:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C9E705B1E; Tue, 21 May 2019 10:14:24 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 2E1AC5B38; Tue, 21 May 2019 10:14:23 +0200 (CEST) In-Reply-To: <1558427054-187378-1-git-send-email-xuanziyang2@huawei.com> References: <1558427054-187378-1-git-send-email-xuanziyang2@huawei.com> To: test-report@dpdk.org Cc: Ziyang Xuan Message-Id: <20190521081423.2E1AC5B38@dpdk.org> Date: Tue, 21 May 2019 10:14:23 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw53568 [PATCH 10/11] net/hinic: add TX module X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/53568 _coding style issues_ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw_ci == sw_ci' #469: FILE: drivers/net/hinic/hinic_pmd_tx.c:424: + if ((hw_ci == sw_ci) || + (((hw_ci - sw_ci) & sq_mask) < tx_info->wqebb_cnt)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->pool != mbuf_free[0]->pool' #491: FILE: drivers/net/hinic/hinic_pmd_tx.c:446: + if (unlikely((m->pool != mbuf_free[0]->pool) || + (nb_free >= HINIC_MAX_TX_FREE_BULK))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_free >= HINIC_MAX_TX_FREE_BULK' #491: FILE: drivers/net/hinic/hinic_pmd_tx.c:446: + if (unlikely((m->pool != mbuf_free[0]->pool) || + (nb_free >= HINIC_MAX_TX_FREE_BULK))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->tso_segsz == 0' #579: FILE: drivers/net/hinic/hinic_pmd_tx.c:534: + if ((m->tso_segsz == 0) || + ((ol_flags & PKT_TX_IPV4) && + !(ol_flags & PKT_TX_IP_CKSUM))) CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #617: FILE: drivers/net/hinic/hinic_pmd_tx.c:572: + rte_cpu_to_be_16( CHECK:CAMELCASE: Avoid CamelCase: #715: FILE: drivers/net/hinic/hinic_pmd_tx.c:670: + if (eth_type == ETHER_TYPE_IPv4) { CHECK:CAMELCASE: Avoid CamelCase: #725: FILE: drivers/net/hinic/hinic_pmd_tx.c:680: + } else if (eth_type == ETHER_TYPE_IPv6) { total: 0 errors, 0 warnings, 7 checks, 1044 lines checked