[dpdk-test-report] |WARNING| pw53577 [PATCH 04/15] net: add rte prefix to ether functions

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw53577 [PATCH 04/15] net: add rte prefix to ether functions
Date: Tue, 21 May 2019 18:15:17 +0200 (CEST)	[thread overview]
Message-ID: <20190521161517.7ACF95B2E@dpdk.org> (raw)
In-Reply-To: <20190521161315.25500-5-olivier.matz@6wind.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53577

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25: 
- rename is_valid_assigned_ether_addr() as rte_is_valid_assigned_ether_addr().

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#963: FILE: drivers/net/bonding/rte_eth_bond_alb.c:163:
+				if (!rte_is_broadcast_ether_addr(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#965: FILE: drivers/net/bonding/rte_eth_bond_alb.c:165:
+					rte_ether_addr_copy(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1346: FILE: drivers/net/failsafe/failsafe.c:256:
+				rte_ether_addr_copy(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1586: FILE: drivers/net/i40e/i40e_ethdev_vf.c:1277:
+	if (rte_is_valid_assigned_ether_addr(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1826: FILE: drivers/net/iavf/iavf_ethdev.c:1320:
+	if (!rte_is_valid_assigned_ether_addr(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1873: FILE: drivers/net/ice/ice_ethdev.c:489:
+	rte_ether_addr_copy(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1884: FILE: drivers/net/ice/ice_ethdev.c:501:
+	rte_ether_addr_copy(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2032: FILE: drivers/net/ixgbe/ixgbe_pf.c:466:
+	if (rte_is_valid_assigned_ether_addr(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2046: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:38:
+	if (rte_is_valid_assigned_ether_addr(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2307: FILE: drivers/net/nfp/nfp_net.c:2965:
+	if (!rte_is_valid_assigned_ether_addr(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2436: FILE: drivers/net/qede/qede_ethdev.c:2571:
+				rte_ether_addr_copy(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2441: FILE: drivers/net/qede/qede_ethdev.c:2574:
+				rte_ether_addr_copy(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2584: FILE: drivers/net/tap/rte_eth_tap.c:1175:
+	if (rte_is_same_ether_addr(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2593: FILE: drivers/net/tap/rte_eth_tap.c:1183:
+	if (!rte_is_same_ether_addr(

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#2702: FILE: drivers/net/virtio/virtio_ethdev.c:1167:
 		struct virtio_net_ctrl_mac *tbl
+			= rte_is_multicast_ether_addr(addr) ? mc : uc;

WARNING:LONG_LINE: line over 90 characters
#2774: FILE: examples/bond/main.c:393:
+						rte_ether_addr_copy(&eth_hdr->s_addr, &eth_hdr->d_addr);

WARNING:LONG_LINE: line over 90 characters
#2777: FILE: examples/bond/main.c:395:
+						rte_ether_addr_copy(&arp_hdr->arp_data.arp_sha,

WARNING:LONG_LINE: line over 90 characters
#2778: FILE: examples/bond/main.c:396:
+								&arp_hdr->arp_data.arp_tha);

WARNING:LONG_LINE: line over 90 characters
#2782: FILE: examples/bond/main.c:399:
+						rte_ether_addr_copy(&d_addr, &arp_hdr->arp_data.arp_sha);

WARNING:LONG_LINE: line over 90 characters
#2791: FILE: examples/bond/main.c:414:
+					rte_ether_addr_copy(&eth_hdr->s_addr, &eth_hdr->d_addr);

total: 0 errors, 6 warnings, 2879 lines checked

          parent reply	other threads:[~2019-05-21 16:15 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20190521161315.25500-5-olivier.matz@6wind.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521161517.7ACF95B2E@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).