[dpdk-test-report] |WARNING| pw53762 [PATCH 25/27] examples/qos_sched: update qos sched sample app

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Subject: [dpdk-test-report] |WARNING| pw53762 [PATCH 25/27] examples/qos_sched: update qos sched sample app
Date: Tue, 28 May 2019 14:15:05 +0200 (CEST)	[thread overview]
Message-ID: <20190528121505.1E0561BBDF@dpdk.org> (raw)
In-Reply-To: <20190528120553.2992-26-lukaszx.krakowiak@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53762

_coding style issues_


WARNING:LONG_LINE_COMMENT: line over 90 characters
#65: FILE: examples/qos_sched/app_thread.c:40:
+			(subport_params[*subport].n_subport_pipes - 1); /* Inner VLAN ID */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#68: FILE: examples/qos_sched/app_thread.c:43:
+			(RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE - 1) : *queue); /* Destination IP */

WARNING:LONG_LINE: line over 90 characters
#270: FILE: examples/qos_sched/cfg_file.c:146:
+		struct rte_red_params red_params[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE][RTE_COLORS];

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (32, 32)
#353: FILE: examples/qos_sched/cfg_file.c:229:
+				for (j = 0; j < RTE_SCHED_QUEUES_PER_PIPE; j++) {
+				subport_params[i].qsize[j] =

WARNING:LONG_LINE: line over 90 characters
#444: FILE: examples/qos_sched/init.c:173:
+		.tc_rate = {305175, 305175, 305175, 305175, 305175, 305175, 305175, 305175, 305175},

WARNING:LONG_LINE: line over 90 characters
#457: FILE: examples/qos_sched/init.c:188:
+		.tc_rate = {1250000000, 1250000000, 1250000000, 1250000000, 1250000000, 1250000000, 1250000000, 1250000000, 1250000000},

WARNING:LONG_LINE: line over 90 characters
#462: FILE: examples/qos_sched/init.c:193:
+		.n_pipe_profiles = sizeof(pipe_profiles) / sizeof(struct rte_sched_pipe_params),

WARNING:LONG_LINE: line over 90 characters
#467: FILE: examples/qos_sched/init.c:198:
+			[0][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#468: FILE: examples/qos_sched/init.c:199:
+			[0][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#469: FILE: examples/qos_sched/init.c:200:
+			[0][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#472: FILE: examples/qos_sched/init.c:203:
+			[1][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#473: FILE: examples/qos_sched/init.c:204:
+			[1][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#474: FILE: examples/qos_sched/init.c:205:
+			[1][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#477: FILE: examples/qos_sched/init.c:208:
+			[2][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#478: FILE: examples/qos_sched/init.c:209:
+			[2][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#479: FILE: examples/qos_sched/init.c:210:
+			[2][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#482: FILE: examples/qos_sched/init.c:213:
+			[3][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#483: FILE: examples/qos_sched/init.c:214:
+			[3][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#484: FILE: examples/qos_sched/init.c:215:
+			[3][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9}

WARNING:LONG_LINE: line over 90 characters
#487: FILE: examples/qos_sched/init.c:218:
+			[4][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#488: FILE: examples/qos_sched/init.c:219:
+			[4][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#489: FILE: examples/qos_sched/init.c:220:
+			[4][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9}

WARNING:LONG_LINE: line over 90 characters
#492: FILE: examples/qos_sched/init.c:223:
+			[5][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#493: FILE: examples/qos_sched/init.c:224:
+			[5][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#494: FILE: examples/qos_sched/init.c:225:
+			[5][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9}

WARNING:LONG_LINE: line over 90 characters
#497: FILE: examples/qos_sched/init.c:228:
+			[6][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#498: FILE: examples/qos_sched/init.c:229:
+			[6][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#499: FILE: examples/qos_sched/init.c:230:
+			[6][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9}

WARNING:LONG_LINE: line over 90 characters
#502: FILE: examples/qos_sched/init.c:233:
+			[7][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#503: FILE: examples/qos_sched/init.c:234:
+			[7][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#504: FILE: examples/qos_sched/init.c:235:
+			[7][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9}

WARNING:LONG_LINE: line over 90 characters
#507: FILE: examples/qos_sched/init.c:238:
+			[8][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#508: FILE: examples/qos_sched/init.c:239:
+			[8][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9},

WARNING:LONG_LINE: line over 90 characters
#509: FILE: examples/qos_sched/init.c:240:
+			[8][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 = 9}

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#804: FILE: examples/qos_sched/stats.c:24:
+	if (i == nb_pfc || subport_id >= port_params.n_subports_per_port ||
[...]
+			return -1;

WARNING:LONG_LINE: line over 90 characters
#873: FILE: examples/qos_sched/stats.c:90:
+				rte_sched_queue_read_stats(port, queue_id + i, &stats, &qlen);

WARNING:LONG_LINE: line over 90 characters
#953: FILE: examples/qos_sched/stats.c:171:
+		subport_queue_id += subport_params[i].n_subport_pipes * RTE_SCHED_QUEUES_PER_PIPE;

WARNING:LONG_LINE: line over 90 characters
#963: FILE: examples/qos_sched/stats.c:179:
+				queue_id = subport_queue_id + i * RTE_SCHED_QUEUES_PER_PIPE + tc;

WARNING:LONG_LINE: line over 90 characters
#969: FILE: examples/qos_sched/stats.c:185:
+							i * RTE_SCHED_QUEUES_PER_PIPE + tc + j;

WARNING:LONG_LINE: line over 90 characters
#970: FILE: examples/qos_sched/stats.c:186:
+					rte_sched_queue_read_stats(port, queue_id, &stats, &qlen);

WARNING:LONG_LINE: line over 90 characters
#977: FILE: examples/qos_sched/stats.c:193:
+			average += part_average / (subport_params[subport_id].n_subport_pipes);

WARNING:LONG_LINE: line over 90 characters
#979: FILE: examples/qos_sched/stats.c:195:
+			average += part_average / (subport_params[subport_id].n_subport_pipes) * RTE_SCHED_WRR_QUEUES_PER_PIPE;

WARNING:LONG_LINE: line over 90 characters
#1012: FILE: examples/qos_sched/stats.c:227:
+		subport_queue_id += subport_params[i].n_subport_pipes * RTE_SCHED_QUEUES_PER_PIPE;

WARNING:LONG_LINE: line over 90 characters
#1031: FILE: examples/qos_sched/stats.c:242:
+		average += part_average / (subport_params[subport_id].n_subport_pipes * RTE_SCHED_QUEUES_PER_PIPE);

WARNING:LONG_LINE: line over 90 characters
#1075: FILE: examples/qos_sched/stats.c:320:
+			printf("|  %d |   %d   | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11i |
", i, j,

WARNING:LONG_LINE: line over 90 characters
#1076: FILE: examples/qos_sched/stats.c:321:
+				stats.n_pkts, stats.n_pkts_dropped, stats.n_bytes, stats.n_bytes_dropped, qlen);

WARNING:LONG_LINE: line over 90 characters
#1080: FILE: examples/qos_sched/stats.c:325:
+				rte_sched_queue_read_stats(port, queue_id + i + j, &stats, &qlen);

WARNING:LONG_LINE: line over 90 characters
#1081: FILE: examples/qos_sched/stats.c:326:
+				printf("|  %d |   %d   | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11i |
", i, j,

WARNING:LONG_LINE: line over 90 characters
#1082: FILE: examples/qos_sched/stats.c:327:
+					stats.n_pkts, stats.n_pkts_dropped, stats.n_bytes, stats.n_bytes_dropped, qlen);

total: 0 errors, 49 warnings, 993 lines checked

          parent reply	other threads:[~2019-05-28 12:15 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20190528120553.2992-26-lukaszx.krakowiak@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528121505.1E0561BBDF@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=lukaszx.krakowiak@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).