From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EFDEEA046B for ; Tue, 28 May 2019 15:13:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9384F1B9C3; Tue, 28 May 2019 15:13:48 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 6C2411B9B8; Tue, 28 May 2019 15:13:43 +0200 (CEST) In-Reply-To: <20190528115158.73245-3-ray.kinsella@intel.com> References: <20190528115158.73245-3-ray.kinsella@intel.com> To: test-report@dpdk.org Cc: Ray Kinsella Message-Id: <20190528131343.6C2411B9B8@dpdk.org> Date: Tue, 28 May 2019 15:13:43 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw53769 [PATCH 2/2] app/test: LPMv4 ABI Version Testing X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/53769 _coding style issues_ WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #738: FILE: app/test/test_lpm_routes.c:270: + printf("Route distribution per prefix width: "); ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #800: FILE: app/test/v16.04/dcompat.h:8: +#define ABI_VERSION DPDK_16.04 WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #873: FILE: app/test/v16.04/rte_lpm.h:52: +#define RTE_LPM_RETURN_IF_TRUE(cond, retval) do { \ + if (cond) \ + return (retval); \ +} while (0) WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #989: FILE: app/test/v16.04/rte_lpm.h:168: + struct rte_lpm_rule_v20 rules_tbl[0] \ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1162: FILE: app/test/v16.04/rte_lpm.h:341: + unsigned tbl24_index = (ip >> 8); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1177: FILE: app/test/v16.04/rte_lpm.h:356: + unsigned tbl8_index = (uint8_t)ip + WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1214: FILE: app/test/v16.04/rte_lpm.h:393: + uint32_t *next_hops, const unsigned n) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1216: FILE: app/test/v16.04/rte_lpm.h:395: + unsigned i; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1217: FILE: app/test/v16.04/rte_lpm.h:396: + unsigned tbl24_indexes[n]; WARNING:BRACES: braces {} are not necessary for single statement blocks #1224: FILE: app/test/v16.04/rte_lpm.h:403: + for (i = 0; i < n; i++) { + tbl24_indexes[i] = ips[i] >> 8; + } WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1237: FILE: app/test/v16.04/rte_lpm.h:416: + unsigned tbl8_index = (uint8_t)ips[i] + WARNING:TYPO_SPELLING: 'compability' may be misspelled - perhaps 'compatibility'? #1545: FILE: app/test/v16.04/test_lpm.c:4: + * LPM Autotests from DPDK v16.04 for abi compability testing. WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #1572: FILE: app/test/v16.04/test_lpm.c:31: +#define TEST_LPM_ASSERT(cond) do { \ + if (!(cond)) { \ + printf("Error at line %d: ", __LINE__); \ + return -1; \ + } \ +} while (0) WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #1574: FILE: app/test/v16.04/test_lpm.c:33: + printf("Error at line %d: ", __LINE__); \ WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(tests) #1624: FILE: app/test/v16.04/test_lpm.c:83: +#define NUM_LPM_TESTS (sizeof(tests)/sizeof(tests[0])) WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #1665: FILE: app/test/v16.04/test_lpm.c:124: + * */ WARNING:TYPO_SPELLING: 'vaild' may be misspelled - perhaps 'valid'? #1733: FILE: app/test/v16.04/test_lpm.c:192: + /*Create vaild lpm to use in rest of test. */ WARNING:TYPO_SPELLING: 'vaild' may be misspelled - perhaps 'valid'? #1771: FILE: app/test/v16.04/test_lpm.c:230: + /*Create vaild lpm to use in rest of test. */ WARNING:TYPO_SPELLING: 'vaild' may be misspelled - perhaps 'valid'? #1809: FILE: app/test/v16.04/test_lpm.c:268: + /*Create vaild lpm to use in rest of test. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2074: FILE: app/test/v16.04/test_lpm.c:533: + * entry */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2117: FILE: app/test/v16.04/test_lpm.c:576: + * entry */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2185: FILE: app/test/v16.04/test_lpm.c:644: + * (& delete & lookup) */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2223: FILE: app/test/v16.04/test_lpm.c:682: + * (& delete & lookup) */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2269: FILE: app/test/v16.04/test_lpm.c:728: + * (& delete & lookup) */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2298: FILE: app/test/v16.04/test_lpm.c:757: + * (& delete & lookup) */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2360: FILE: app/test/v16.04/test_lpm.c:819: + * */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2429: FILE: app/test/v16.04/test_lpm.c:888: + * */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2486: FILE: app/test/v16.04/test_lpm.c:945: + * */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2550: FILE: app/test/v16.04/test_lpm.c:1009: + * */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2556: FILE: app/test/v16.04/test_lpm.c:1015: + * that we have enough storage for all rules at that depth*/ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2587: FILE: app/test/v16.04/test_lpm.c:1046: + * we get a fail */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #2654: FILE: app/test/v16.04/test_lpm.c:1113: + * depth >24 and the top 24 bits are different */ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #2662: FILE: app/test/v16.04/test_lpm.c:1121: + (unsigned)ip, (unsigned)NUMBER_TBL8S); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #2662: FILE: app/test/v16.04/test_lpm.c:1121: + (unsigned)ip, (unsigned)NUMBER_TBL8S); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #2768: FILE: app/test/v16.04/test_lpm.c:1227: + unsigned i, j; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #2779: FILE: app/test/v16.04/test_lpm.c:1238: + printf("No. routes = %u ", (unsigned) NUM_ROUTE_ENTRIES); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #2813: FILE: app/test/v16.04/test_lpm.c:1272: + (unsigned) lpm_used_entries, WARNING:LONG_LINE: line over 90 characters #2816: FILE: app/test/v16.04/test_lpm.c:1275: + (unsigned) cache_line_counter, (unsigned) cache_line_counter * 64); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #2816: FILE: app/test/v16.04/test_lpm.c:1275: + (unsigned) cache_line_counter, (unsigned) cache_line_counter * 64); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #2816: FILE: app/test/v16.04/test_lpm.c:1275: + (unsigned) cache_line_counter, (unsigned) cache_line_counter * 64); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #2860: FILE: app/test/v16.04/test_lpm.c:1319: + unsigned k; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #2887: FILE: app/test/v16.04/test_lpm.c:1346: + unsigned k; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #2932: FILE: app/test/v16.04/test_lpm.c:1391: + unsigned i; ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2980: FILE: app/test/v2.0/dcompat.h:8: +#define ABI_VERSION DPDK_2.0 WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #3032: FILE: app/test/v2.0/rte_lpm.h:31: + * allocated in memory using librte_malloc which uses a memzone. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #3037: FILE: app/test/v2.0/rte_lpm.h:36: + * allocated in memory using librte_malloc which uses a memzone. */ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #3058: FILE: app/test/v2.0/rte_lpm.h:57: +#define RTE_LPM_RETURN_IF_TRUE(cond, retval) do { \ + if (cond) \ + return (retval); \ +} while (0) WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #3115: FILE: app/test/v2.0/rte_lpm.h:114: + struct rte_lpm_tbl24_entry tbl24[RTE_LPM_TBL24_NUM_ENTRIES] \ WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #3117: FILE: app/test/v2.0/rte_lpm.h:116: + struct rte_lpm_tbl8_entry tbl8[RTE_LPM_TBL8_NUM_ENTRIES] \ WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #3119: FILE: app/test/v2.0/rte_lpm.h:118: + struct rte_lpm_rule rules_tbl[0] \ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #3246: FILE: app/test/v2.0/rte_lpm.h:245: + unsigned tbl24_index = (ip >> 8); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #3259: FILE: app/test/v2.0/rte_lpm.h:258: + unsigned tbl8_index = (uint8_t)ip + WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #3294: FILE: app/test/v2.0/rte_lpm.h:293: + uint16_t *next_hops, const unsigned n) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #3296: FILE: app/test/v2.0/rte_lpm.h:295: + unsigned i; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #3297: FILE: app/test/v2.0/rte_lpm.h:296: + unsigned tbl24_indexes[n]; WARNING:BRACES: braces {} are not necessary for single statement blocks #3303: FILE: app/test/v2.0/rte_lpm.h:302: + for (i = 0; i < n; i++) { + tbl24_indexes[i] = ips[i] >> 8; + } WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #3315: FILE: app/test/v2.0/rte_lpm.h:314: + unsigned tbl8_index = (uint8_t)ips[i] + WARNING:TYPO_SPELLING: 'compability' may be misspelled - perhaps 'compatibility'? #3454: FILE: app/test/v2.0/test_lpm.c:4: + * LPM Autotests from DPDK v2.0 for abi compability testing. WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #3480: FILE: app/test/v2.0/test_lpm.c:30: +#define TEST_LPM_ASSERT(cond) do { \ + if (!(cond)) { \ + printf("Error at line %d: ", __LINE__); \ + return -1; \ + } \ +} while (0) WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(tests) #3532: FILE: app/test/v2.0/test_lpm.c:82: +#define NUM_LPM_TESTS (sizeof(tests)/sizeof(tests[0])) WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #3565: FILE: app/test/v2.0/test_lpm.c:115: + * */ WARNING:TYPO_SPELLING: 'vaild' may be misspelled - perhaps 'valid'? #3618: FILE: app/test/v2.0/test_lpm.c:168: + /*Create vaild lpm to use in rest of test. */ WARNING:TYPO_SPELLING: 'vaild' may be misspelled - perhaps 'valid'? #3651: FILE: app/test/v2.0/test_lpm.c:201: + /*Create vaild lpm to use in rest of test. */ WARNING:TYPO_SPELLING: 'vaild' may be misspelled - perhaps 'valid'? #3685: FILE: app/test/v2.0/test_lpm.c:235: + /*Create vaild lpm to use in rest of test. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #3929: FILE: app/test/v2.0/test_lpm.c:479: + * entry */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #3972: FILE: app/test/v2.0/test_lpm.c:522: + * entry */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #4035: FILE: app/test/v2.0/test_lpm.c:585: + * (& delete & lookup) */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #4073: FILE: app/test/v2.0/test_lpm.c:623: + * (& delete & lookup) */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #4119: FILE: app/test/v2.0/test_lpm.c:669: + * (& delete & lookup) */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #4148: FILE: app/test/v2.0/test_lpm.c:698: + * (& delete & lookup) */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #4210: FILE: app/test/v2.0/test_lpm.c:760: + * */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #4274: FILE: app/test/v2.0/test_lpm.c:824: + * */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #4326: FILE: app/test/v2.0/test_lpm.c:876: + * */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #4385: FILE: app/test/v2.0/test_lpm.c:935: + * */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #4391: FILE: app/test/v2.0/test_lpm.c:941: + * that we have enough storage for all rules at that depth*/ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #4417: FILE: app/test/v2.0/test_lpm.c:967: + * we get a fail */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #4475: FILE: app/test/v2.0/test_lpm.c:1025: + * depth >24 and the top 24 bits are different */ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #4483: FILE: app/test/v2.0/test_lpm.c:1033: + (unsigned)ip, (unsigned)RTE_LPM_TBL8_NUM_GROUPS); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #4483: FILE: app/test/v2.0/test_lpm.c:1033: + (unsigned)ip, (unsigned)RTE_LPM_TBL8_NUM_GROUPS); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #4579: FILE: app/test/v2.0/test_lpm.c:1129: + unsigned i, j; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #4590: FILE: app/test/v2.0/test_lpm.c:1140: + printf("No. routes = %u ", (unsigned) NUM_ROUTE_ENTRIES); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #4624: FILE: app/test/v2.0/test_lpm.c:1174: + (unsigned) lpm_used_entries, WARNING:LONG_LINE: line over 90 characters #4627: FILE: app/test/v2.0/test_lpm.c:1177: + (unsigned) cache_line_counter, (unsigned) cache_line_counter * 64); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #4627: FILE: app/test/v2.0/test_lpm.c:1177: + (unsigned) cache_line_counter, (unsigned) cache_line_counter * 64); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #4627: FILE: app/test/v2.0/test_lpm.c:1177: + (unsigned) cache_line_counter, (unsigned) cache_line_counter * 64); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #4670: FILE: app/test/v2.0/test_lpm.c:1220: + unsigned k; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #4697: FILE: app/test/v2.0/test_lpm.c:1247: + unsigned k; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #4742: FILE: app/test/v2.0/test_lpm.c:1292: + unsigned i; total: 2 errors, 86 warnings, 4618 lines checked