automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ziyang Xuan <xuanziyang2@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw53790 [PATCH v2 05/11] net/hinic/base: add eqs and context code
Date: Wed, 29 May 2019 05:39:08 +0200 (CEST)	[thread overview]
Message-ID: <20190529033908.6AABE1B959@dpdk.org> (raw)
In-Reply-To: <e4a15599df58f21618320c2a61a580a13440c2bf.1559100649.git.xuanziyang2@huawei.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53790

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'max_sqs' - possible side-effects?
#75: FILE: drivers/net/hinic/base/hinic_ctx_def.h:37:
+#define RQ_CTXT_OFFSET(max_sqs, max_rqs, q_id)	\
+			(((max_rqs) + (max_sqs)) * TSO_LRO_CTXT_SIZE \
+			+ (max_sqs) * Q_CTXT_SIZE + (q_id) * Q_CTXT_SIZE)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#493: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:99:
+#define EQ_CONS_IDX(eq)		((eq)->cons_idx | \
+				((u32)(eq)->wrapped << EQ_WRAPPED_SHIFT))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#496: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:102:
+#define EQ_CONS_IDX_REG_ADDR(eq)	(((eq)->type == HINIC_AEQ) ? \
+				HINIC_CSR_AEQ_CONS_IDX_ADDR((eq)->q_id) :\
+				HINIC_CSR_CEQ_CONS_IDX_ADDR((eq)->q_id))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#500: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:106:
+#define EQ_PROD_IDX_REG_ADDR(eq)	(((eq)->type == HINIC_AEQ) ? \
+				HINIC_CSR_AEQ_PROD_IDX_ADDR((eq)->q_id) :\
+				HINIC_CSR_CEQ_PROD_IDX_ADDR((eq)->q_id))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#504: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:110:
+#define GET_EQ_NUM_PAGES(eq, size)		\
+		((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \
+		/ (size)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects?
#504: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:110:
+#define GET_EQ_NUM_PAGES(eq, size)		\
+		((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \
+		/ (size)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#510: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:116:
+#define GET_EQ_ELEMENT(eq, idx)		\
+		(((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+		(((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#510: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:116:
+#define GET_EQ_ELEMENT(eq, idx)		\
+		(((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+		(((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#519: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:125:
+#define GET_CURR_AEQ_ELEM(eq)		GET_AEQ_ELEM((eq), (eq)->cons_idx)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#536: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:142:
+#define aeq_to_aeqs(eq) \
+		container_of((eq) - (eq)->q_id, struct hinic_aeqs, aeq[0])

total: 0 errors, 0 warnings, 10 checks, 1163 lines checked

           reply	other threads:[~2019-05-29  3:39 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <e4a15599df58f21618320c2a61a580a13440c2bf.1559100649.git.xuanziyang2@huawei.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190529033908.6AABE1B959@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=xuanziyang2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).