From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-test-report] |WARNING| pw53934 [PATCH 7/8] raw/ioat: add statistics functions
Date: Thu, 30 May 2019 23:27:23 +0200 (CEST) [thread overview]
Message-ID: <20190530212723.CDF355680@dpdk.org> (raw)
In-Reply-To: <20190530212525.40370-8-bruce.richardson@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53934
_coding style issues_
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#121: FILE: drivers/raw/ioat/ioat_rawdev.c:110:
+static const char *xstat_names[] = {
ERROR:SPACING: space required before the open brace '{'
#134: FILE: drivers/raw/ioat/ioat_rawdev.c:123:
+ switch (ids[i]){
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#135: FILE: drivers/raw/ioat/ioat_rawdev.c:124:
+ case 0: values[i] = ioat->enqueue_failed; break;
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#136: FILE: drivers/raw/ioat/ioat_rawdev.c:125:
+ case 1: values[i] = ioat->enqueued; break;
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#137: FILE: drivers/raw/ioat/ioat_rawdev.c:126:
+ case 2: values[i] = ioat->started; break;
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#138: FILE: drivers/raw/ioat/ioat_rawdev.c:127:
+ case 3: values[i] = ioat->completed; break;
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#139: FILE: drivers/raw/ioat/ioat_rawdev.c:128:
+ default: values[i] = 0; break;
total: 6 errors, 1 warnings, 141 lines checked
parent reply other threads:[~2019-05-30 21:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190530212525.40370-8-bruce.richardson@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530212723.CDF355680@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=bruce.richardson@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).