* [dpdk-test-report] |WARNING| pw53964 [RFC 2/5] app/testpmd: macsec on command draft via security context
[not found] <a49e7420fe45b0308b9ccf98e0c74925b9d78a68.1559319237.git.igor.russkikh@aquantia.com>
@ 2019-05-31 16:16 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-05-31 16:16 UTC (permalink / raw)
To: test-report; +Cc: Igor Russkikh
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53964
_coding style issues_
ERROR:DOS_LINE_ENDINGS: DOS line endings
#43: FILE: app/test-pmd/cmdline.c:49:
+#include <rte_security.h>^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#51: FILE: app/test-pmd/cmdline.c:13995:
+/* Temporary static storage until testpmd macsec commands get reformatted */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#52: FILE: app/test-pmd/cmdline.c:13996:
+int macsec_encrypt;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#53: FILE: app/test-pmd/cmdline.c:13997:
+int macsec_replay_protection;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#54: FILE: app/test-pmd/cmdline.c:13998:
+struct rte_security_session_conf macsec_conf;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#55: FILE: app/test-pmd/cmdline.c:13999:
+struct rte_security_session *macsec_session;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#56: FILE: app/test-pmd/cmdline.c:14000:
+^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#64: FILE: app/test-pmd/cmdline.c:14039:
+static struct rte_mempool *get_security_pool()^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#65: FILE: app/test-pmd/cmdline.c:14040:
+{^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#66: FILE: app/test-pmd/cmdline.c:14041:
+^Istruct rte_mempool *pool = rte_mempool_lookup("testpmd_security_pool");^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#67: FILE: app/test-pmd/cmdline.c:14042:
+^Iint session_size = 256;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#68: FILE: app/test-pmd/cmdline.c:14043:
+^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#69: FILE: app/test-pmd/cmdline.c:14044:
+^Iif (!pool) {^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#70: FILE: app/test-pmd/cmdline.c:14045:
+^I^Ipool = rte_mempool_create("testpmd_security_pool",^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#71: FILE: app/test-pmd/cmdline.c:14046:
+^I^I^I^I256,^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#72: FILE: app/test-pmd/cmdline.c:14047:
+^I^I^I^Isession_size,^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#73: FILE: app/test-pmd/cmdline.c:14048:
+^I^I^I^I256,^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#74: FILE: app/test-pmd/cmdline.c:14049:
+^I^I^I^I0, NULL, NULL, NULL,^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#75: FILE: app/test-pmd/cmdline.c:14050:
+^I^I^I^INULL, SOCKET_ID_ANY,^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#76: FILE: app/test-pmd/cmdline.c:14051:
+^I^I^I^I0);^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#77: FILE: app/test-pmd/cmdline.c:14052:
+^I}^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#78: FILE: app/test-pmd/cmdline.c:14053:
+^Ireturn pool;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#79: FILE: app/test-pmd/cmdline.c:14054:
+}^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#80: FILE: app/test-pmd/cmdline.c:14055:
+^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#89: FILE: app/test-pmd/cmdline.c:14063:
+^Iint ret = 0;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#90: FILE: app/test-pmd/cmdline.c:14064:
+^Istruct rte_security_ctx *ctx;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#95: FILE: app/test-pmd/cmdline.c:14069:
+^Istruct rte_security_session_conf macsec_conf;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#108: FILE: app/test-pmd/cmdline.c:14078:
+^Ictx = rte_eth_dev_get_sec_ctx(port_id);^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#109: FILE: app/test-pmd/cmdline.c:14079:
+^Iif (!ctx) {^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#110: FILE: app/test-pmd/cmdline.c:14080:
+^I^Iret = ENOTSUP;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#111: FILE: app/test-pmd/cmdline.c:14081:
+^I^Igoto done;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#112: FILE: app/test-pmd/cmdline.c:14082:
+^I}^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#113: FILE: app/test-pmd/cmdline.c:14083:
+^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#114: FILE: app/test-pmd/cmdline.c:14084:
+^Imacsec_conf.action_type = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#115: FILE: app/test-pmd/cmdline.c:14085:
+^Imacsec_conf.protocol = RTE_SECURITY_PROTOCOL_MACSEC;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#116: FILE: app/test-pmd/cmdline.c:14086:
+^I/** should be moved to SC properties */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#117: FILE: app/test-pmd/cmdline.c:14087:
+^Imacsec_encrypt = en;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#118: FILE: app/test-pmd/cmdline.c:14088:
+^Imacsec_replay_protection = rp;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#119: FILE: app/test-pmd/cmdline.c:14089:
+^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#120: FILE: app/test-pmd/cmdline.c:14090:
+^I/* Use of the same mempool for session header and private data */^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#121: FILE: app/test-pmd/cmdline.c:14091:
+^Imacsec_session = rte_security_session_create(ctx, &macsec_conf, get_security_pool());^M$
WARNING:LONG_LINE: line over 90 characters
#121: FILE: app/test-pmd/cmdline.c:14091:
+ macsec_session = rte_security_session_create(ctx, &macsec_conf, get_security_pool());
ERROR:DOS_LINE_ENDINGS: DOS line endings
#122: FILE: app/test-pmd/cmdline.c:14092:
+^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#123: FILE: app/test-pmd/cmdline.c:14093:
+^Iif (macsec_session == NULL) {^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#124: FILE: app/test-pmd/cmdline.c:14094:
+^I^Iret = -ENOTSUP;^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#129: FILE: app/test-pmd/cmdline.c:14097:
+done:^M$
ERROR:DOS_LINE_ENDINGS: DOS line endings
#132: FILE: app/test-pmd/cmdline.c:14100:
+^I^I/* TBD: To delete? */^M$
total: 46 errors, 1 warnings, 92 lines checked
^ permalink raw reply [flat|nested] only message in thread