From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D5F00A0096 for ; Mon, 3 Jun 2019 11:07:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C9EE62BEA; Mon, 3 Jun 2019 11:07:43 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 29C784F91; Mon, 3 Jun 2019 11:07:42 +0200 (CEST) In-Reply-To: <1559552722-8970-2-git-send-email-qiming.yang@intel.com> References: <1559552722-8970-2-git-send-email-qiming.yang@intel.com> To: test-report@dpdk.org Cc: Qiming Yang Message-Id: <20190603090742.29C784F91@dpdk.org> Date: Mon, 3 Jun 2019 11:07:42 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw54143 [PATCH 1/2] net/ice: enable switch filter X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/54143 _coding style issues_ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #92: FILE: drivers/net/ice/ice_switch_filter.c:23: +ice_parse_switch_filter( WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[i].h_u.eth_hdr.src_addr[j]' #150: FILE: drivers/net/ice/ice_switch_filter.c:81: + list[i].h_u.eth_hdr. + src_addr[j] = WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[i].m_u.eth_hdr.src_addr[j]' #153: FILE: drivers/net/ice/ice_switch_filter.c:84: + list[i].m_u.eth_hdr. + src_addr[j] = WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[i].h_u.eth_hdr.dst_addr[j]' #159: FILE: drivers/net/ice/ice_switch_filter.c:90: + list[i].h_u.eth_hdr. + dst_addr[j] = WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[i].m_u.eth_hdr.dst_addr[j]' #162: FILE: drivers/net/ice/ice_switch_filter.c:93: + list[i].m_u.eth_hdr. + dst_addr[j] = WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[i].h_u.ice_ipv6_ofos_hdr.src_addr[j]' #232: FILE: drivers/net/ice/ice_switch_filter.c:163: + list[i].h_u.ice_ipv6_ofos_hdr. + src_addr[j] = WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[i].m_u.ice_ipv6_ofos_hdr.src_addr[j]' #235: FILE: drivers/net/ice/ice_switch_filter.c:166: + list[i].m_u.ice_ipv6_ofos_hdr. + src_addr[j] = WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[i].h_u.ice_ipv6_ofos_hdr.dst_addr[j]' #241: FILE: drivers/net/ice/ice_switch_filter.c:172: + list[i].h_u.ice_ipv6_ofos_hdr. + dst_addr[j] = WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[i].m_u.ice_ipv6_ofos_hdr.dst_addr[j]' #244: FILE: drivers/net/ice/ice_switch_filter.c:175: + list[i].m_u.ice_ipv6_ofos_hdr. + dst_addr[j] = WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[i].h_u.ice_ipv6_ofos_hdr.hop_limit' #256: FILE: drivers/net/ice/ice_switch_filter.c:187: + list[i].h_u.ice_ipv6_ofos_hdr. + hop_limit = ipv6_spec->hdr.hop_limits; WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[i].m_u.ice_ipv6_ofos_hdr.hop_limit' #258: FILE: drivers/net/ice/ice_switch_filter.c:189: + list[i].m_u.ice_ipv6_ofos_hdr. + hop_limit = UINT8_MAX; WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #399: FILE: drivers/net/ice/ice_switch_filter.c:330: +/* By now ice switch filter action code implement only +* supports QUEUE or DROP. CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects? #585: FILE: drivers/net/ice/ice_switch_filter.h:8: +#define NEXT_ITEM_OF_ACTION(act, actions, index) \ + do { \ + act = actions + index; \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \ + index++; \ + act = actions + index; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects? #585: FILE: drivers/net/ice/ice_switch_filter.h:8: +#define NEXT_ITEM_OF_ACTION(act, actions, index) \ + do { \ + act = actions + index; \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \ + index++; \ + act = actions + index; \ + } \ + } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues #585: FILE: drivers/net/ice/ice_switch_filter.h:8: +#define NEXT_ITEM_OF_ACTION(act, actions, index) \ + do { \ + act = actions + index; \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \ + index++; \ + act = actions + index; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #585: FILE: drivers/net/ice/ice_switch_filter.h:8: +#define NEXT_ITEM_OF_ACTION(act, actions, index) \ + do { \ + act = actions + index; \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \ + index++; \ + act = actions + index; \ + } \ + } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues #585: FILE: drivers/net/ice/ice_switch_filter.h:8: +#define NEXT_ITEM_OF_ACTION(act, actions, index) \ + do { \ + act = actions + index; \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \ + index++; \ + act = actions + index; \ + } \ + } while (0) total: 0 errors, 11 warnings, 6 checks, 556 lines checked