From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8499BA0096 for ; Thu, 6 Jun 2019 12:56:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7167D1B9AC; Thu, 6 Jun 2019 12:56:07 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 119741B9B3; Thu, 6 Jun 2019 12:56:06 +0200 (CEST) In-Reply-To: <5b9735bd135cf6a2ad23cdd77228427ed6c6388d.1559818024.git.xuanziyang2@huawei.com> References: <5b9735bd135cf6a2ad23cdd77228427ed6c6388d.1559818024.git.xuanziyang2@huawei.com> To: test-report@dpdk.org Cc: Ziyang Xuan Message-Id: <20190606105606.119741B9B3@dpdk.org> Date: Thu, 6 Jun 2019 12:56:06 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw54469 [PATCH v4 05/11] net/hinic/base: add eqs and context code X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/54469 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'max_sqs' - possible side-effects? #70: FILE: drivers/net/hinic/base/hinic_ctx_def.h:31: +#define RQ_CTXT_OFFSET(max_sqs, max_rqs, q_id) \ + (((max_rqs) + (max_sqs)) * TSO_LRO_CTXT_SIZE \ + + (max_sqs) * Q_CTXT_SIZE + (q_id) * Q_CTXT_SIZE) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #480: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:99: +#define EQ_CONS_IDX(eq) ((eq)->cons_idx | \ + ((u32)(eq)->wrapped << EQ_WRAPPED_SHIFT)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #483: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:102: +#define EQ_CONS_IDX_REG_ADDR(eq) (((eq)->type == HINIC_AEQ) ? \ + HINIC_CSR_AEQ_CONS_IDX_ADDR((eq)->q_id) :\ + HINIC_CSR_CEQ_CONS_IDX_ADDR((eq)->q_id)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #487: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:106: +#define EQ_PROD_IDX_REG_ADDR(eq) (((eq)->type == HINIC_AEQ) ? \ + HINIC_CSR_AEQ_PROD_IDX_ADDR((eq)->q_id) :\ + HINIC_CSR_CEQ_PROD_IDX_ADDR((eq)->q_id)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #491: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:110: +#define GET_EQ_NUM_PAGES(eq, size) \ + ((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \ + / (size))) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects? #491: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:110: +#define GET_EQ_NUM_PAGES(eq, size) \ + ((u16)(ALIGN((eq)->eq_len * (u32)(eq)->elem_size, (size)) \ + / (size))) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #497: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:116: +#define GET_EQ_ELEMENT(eq, idx) \ + (((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \ + (((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects? #497: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:116: +#define GET_EQ_ELEMENT(eq, idx) \ + (((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \ + (((u32)(idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #506: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:125: +#define GET_CURR_AEQ_ELEM(eq) GET_AEQ_ELEM((eq), (eq)->cons_idx) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects? #523: FILE: drivers/net/hinic/base/hinic_pmd_eqs.c:142: +#define aeq_to_aeqs(eq) \ + container_of((eq) - (eq)->q_id, struct hinic_aeqs, aeq[0]) total: 0 errors, 0 warnings, 10 checks, 1149 lines checked