From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 1205AA0096
	for <public@inbox.dpdk.org>; Thu,  6 Jun 2019 13:04:49 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 01D421B95D;
	Thu,  6 Jun 2019 13:04:49 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 22E011B9B2; Thu,  6 Jun 2019 13:04:47 +0200 (CEST)
In-Reply-To: <ea888d7b179837e74206e476fb3c25059c222e3f.1559818024.git.xuanziyang2@huawei.com>
References: <ea888d7b179837e74206e476fb3c25059c222e3f.1559818024.git.xuanziyang2@huawei.com>
To: test-report@dpdk.org
Cc: Ziyang Xuan <xuanziyang2@huawei.com>
Message-Id: <20190606110447.22E011B9B2@dpdk.org>
Date: Thu,  6 Jun 2019 13:04:47 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw54476 [PATCH v4 03/11]
	net/hinic/base: add mgmt module interactive code
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54476

_coding style issues_


CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#83: FILE: drivers/net/hinic/base/hinic_pmd_hw_mgmt.h:43:
+	bool lro_en;    /* LRO feature enable bit */

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pf_to_mgmt' - possible side-effects?
#164: FILE: drivers/net/hinic/base/hinic_pmd_mgmt.c:33:
+#define SYNC_MSG_ID_INC(pf_to_mgmt)	(SYNC_MSG_ID(pf_to_mgmt) = \
+			(SYNC_MSG_ID(pf_to_mgmt) + 1) & SYNC_MSG_ID_MASK)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pf_to_mgmt' - possible side-effects?
#169: FILE: drivers/net/hinic/base/hinic_pmd_mgmt.c:38:
+#define ASYNC_MSG_ID_INC(pf_to_mgmt)	(ASYNC_MSG_ID(pf_to_mgmt) = \
+			((ASYNC_MSG_ID(pf_to_mgmt) + 1) & ASYNC_MSG_ID_MASK) \
+			| ASYNC_MSG_FLAG)

total: 0 errors, 0 warnings, 3 checks, 1330 lines checked