From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id F18EEA00E6
	for <public@inbox.dpdk.org>; Thu, 13 Jun 2019 15:54:06 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D2EF81D449;
	Thu, 13 Jun 2019 15:54:06 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 8B96C1D475; Thu, 13 Jun 2019 15:53:47 +0200 (CEST)
In-Reply-To: <1560152324-20538-2-git-send-email-arybchenko@solarflare.com>
References: <1560152324-20538-2-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20190613135347.8B96C1D475@dpdk.org>
Date: Thu, 13 Jun 2019 15:53:47 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw54586 [PATCH 01/29] net/sfc/base:
	enable chained multicast on all EF10 cards
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54586

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#48: FILE: drivers/net/sfc/base/ef10_nic.c:1756:
+ef10_set_workaround_bug26807(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#51: FILE: drivers/net/sfc/base/ef10_nic.c:1759:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#94: FILE: drivers/net/sfc/base/ef10_nic.c:1802:
+	return (rc);

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#97: FILE: drivers/net/sfc/base/ef10_nic.c:1805:
+static	__checkReturn	efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#105: FILE: drivers/net/sfc/base/ef10_nic.c:1963:
+	if ((rc = ef10_set_workaround_bug26807(enp)) != 0)

total: 2 errors, 0 warnings, 3 checks, 160 lines checked