From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 2BCBCA00E6
	for <public@inbox.dpdk.org>; Thu, 13 Jun 2019 15:54:07 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 00E4D1D452;
	Thu, 13 Jun 2019 15:54:07 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 0D4BD1D42E; Thu, 13 Jun 2019 15:53:50 +0200 (CEST)
In-Reply-To: <1560152324-20538-9-git-send-email-arybchenko@solarflare.com>
References: <1560152324-20538-9-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20190613135350.0D4BD1D42E@dpdk.org>
Date: Thu, 13 Jun 2019 15:53:50 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw54588 [PATCH 08/29] net/sfc/base:
	add extensible NVRAM info function
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54588

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#60: FILE: drivers/net/sfc/base/efx_impl.h:571:
+efx_mcdi_nvram_info_ex(

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#65: FILE: drivers/net/sfc/base/efx_impl.h:576:
+	__checkReturn		efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#78: FILE: drivers/net/sfc/base/efx_nvram.c:660:
+efx_mcdi_nvram_info_ex(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#130: FILE: drivers/net/sfc/base/efx_nvram.c:722:
+efx_mcdi_nvram_info(

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#141: FILE: drivers/net/sfc/base/efx_nvram.c:733:
+	if ((rc = efx_mcdi_nvram_info_ex(enp, partn, &eni)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#156: FILE: drivers/net/sfc/base/efx_nvram.c:748:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#161: FILE: drivers/net/sfc/base/efx_nvram.c:753:
+	return (rc);

total: 3 errors, 0 warnings, 4 checks, 120 lines checked