[dpdk-test-report] |WARNING| pw54595 [PATCH 20/29] net/sfc/base: add EVB module vSwitch/vPort/vAdaptor ops

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw54595 [PATCH 20/29] net/sfc/base: add EVB module vSwitch/vPort/vAdaptor ops
Date: Thu, 13 Jun 2019 15:53:57 +0200 (CEST)	[thread overview]
Message-ID: <20190613135357.E0FF21D431@dpdk.org> (raw)
In-Reply-To: <1560152324-20538-21-git-send-email-arybchenko@solarflare.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54595

_coding style issues_


WARNING:TYPO_SPELLING: 'paramter' may be misspelled - perhaps 'parameter'?
#26: 
identifier and hence this paramter is unused for EF10 architecture

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#65: FILE: drivers/net/sfc/base/ef10_evb.c:226:
+	__checkReturn			efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#105: FILE: drivers/net/sfc/base/ef10_evb.c:334:
+ef10_evb_vswitch_alloc(

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#115: FILE: drivers/net/sfc/base/ef10_evb.c:344:
+	if ((rc = efx_mcdi_vswitch_alloc(enp, EVB_PORT_ID_ASSIGNED,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#121: FILE: drivers/net/sfc/base/ef10_evb.c:350:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#127: FILE: drivers/net/sfc/base/ef10_evb.c:356:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#131: FILE: drivers/net/sfc/base/ef10_evb.c:360:
+ef10_evb_vswitch_free(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#141: FILE: drivers/net/sfc/base/ef10_evb.c:370:
+ef10_evb_vport_alloc(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#157: FILE: drivers/net/sfc/base/ef10_evb.c:386:
+ef10_evb_vport_free(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#168: FILE: drivers/net/sfc/base/ef10_evb.c:397:
+ef10_evb_vport_mac_addr_add(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#177: FILE: drivers/net/sfc/base/ef10_evb.c:406:
+	return (efx_mcdi_vport_mac_addr_add(enp, vport_id, addrp));

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#181: FILE: drivers/net/sfc/base/ef10_evb.c:410:
+ef10_evb_vport_mac_addr_del(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#190: FILE: drivers/net/sfc/base/ef10_evb.c:419:
+	return (efx_mcdi_vport_mac_addr_del(enp, vport_id, addrp));

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#194: FILE: drivers/net/sfc/base/ef10_evb.c:423:
+ef10_evb_vadaptor_alloc(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#205: FILE: drivers/net/sfc/base/ef10_evb.c:434:
+ef10_evb_vadaptor_free(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#216: FILE: drivers/net/sfc/base/ef10_evb.c:445:
+ef10_evb_vport_assign(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#237: FILE: drivers/net/sfc/base/ef10_impl.h:198:
+efx_mcdi_vadaptor_alloc(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#242: FILE: drivers/net/sfc/base/ef10_impl.h:203:
+efx_mcdi_vadaptor_free(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#260: FILE: drivers/net/sfc/base/ef10_impl.h:1285:
+ef10_evb_vswitch_alloc(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#266: FILE: drivers/net/sfc/base/ef10_impl.h:1291:
+ef10_evb_vswitch_free(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#271: FILE: drivers/net/sfc/base/ef10_impl.h:1296:
+ef10_evb_vport_alloc(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#281: FILE: drivers/net/sfc/base/ef10_impl.h:1306:
+ef10_evb_vport_free(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#287: FILE: drivers/net/sfc/base/ef10_impl.h:1312:
+ef10_evb_vport_mac_addr_add(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#294: FILE: drivers/net/sfc/base/ef10_impl.h:1319:
+ef10_evb_vport_mac_addr_del(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#301: FILE: drivers/net/sfc/base/ef10_impl.h:1326:
+ef10_evb_vadaptor_alloc(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#308: FILE: drivers/net/sfc/base/ef10_impl.h:1333:
+ef10_evb_vadaptor_free(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#314: FILE: drivers/net/sfc/base/ef10_impl.h:1339:
+ef10_evb_vport_assign(

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#428: FILE: drivers/net/sfc/base/efx_impl.h:658:
+	efx_rc_t	(*eeo_vswitch_alloc)(efx_nic_t *, efx_vswitch_id_t *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t *' should also have an identifier name
#428: FILE: drivers/net/sfc/base/efx_impl.h:658:
+	efx_rc_t	(*eeo_vswitch_alloc)(efx_nic_t *, efx_vswitch_id_t *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#429: FILE: drivers/net/sfc/base/efx_impl.h:659:
+	efx_rc_t	(*eeo_vswitch_free)(efx_nic_t *, efx_vswitch_id_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t' should also have an identifier name
#429: FILE: drivers/net/sfc/base/efx_impl.h:659:
+	efx_rc_t	(*eeo_vswitch_free)(efx_nic_t *, efx_vswitch_id_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#430: FILE: drivers/net/sfc/base/efx_impl.h:660:
+	efx_rc_t	(*eeo_vport_alloc)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t' should also have an identifier name
#430: FILE: drivers/net/sfc/base/efx_impl.h:660:
+	efx_rc_t	(*eeo_vport_alloc)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vport_type_t' should also have an identifier name
#430: FILE: drivers/net/sfc/base/efx_impl.h:660:
+	efx_rc_t	(*eeo_vport_alloc)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#430: FILE: drivers/net/sfc/base/efx_impl.h:660:
+	efx_rc_t	(*eeo_vport_alloc)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'boolean_t' should also have an identifier name
#430: FILE: drivers/net/sfc/base/efx_impl.h:660:
+	efx_rc_t	(*eeo_vport_alloc)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vport_id_t *' should also have an identifier name
#430: FILE: drivers/net/sfc/base/efx_impl.h:660:
+	efx_rc_t	(*eeo_vport_alloc)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#433: FILE: drivers/net/sfc/base/efx_impl.h:663:
+	efx_rc_t	(*eeo_vport_free)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t' should also have an identifier name
#433: FILE: drivers/net/sfc/base/efx_impl.h:663:
+	efx_rc_t	(*eeo_vport_free)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vport_id_t' should also have an identifier name
#433: FILE: drivers/net/sfc/base/efx_impl.h:663:
+	efx_rc_t	(*eeo_vport_free)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#435: FILE: drivers/net/sfc/base/efx_impl.h:665:
+	efx_rc_t	(*eeo_vport_mac_addr_add)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t' should also have an identifier name
#435: FILE: drivers/net/sfc/base/efx_impl.h:665:
+	efx_rc_t	(*eeo_vport_mac_addr_add)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vport_id_t' should also have an identifier name
#435: FILE: drivers/net/sfc/base/efx_impl.h:665:
+	efx_rc_t	(*eeo_vport_mac_addr_add)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t *' should also have an identifier name
#435: FILE: drivers/net/sfc/base/efx_impl.h:665:
+	efx_rc_t	(*eeo_vport_mac_addr_add)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#437: FILE: drivers/net/sfc/base/efx_impl.h:667:
+	efx_rc_t	(*eeo_vport_mac_addr_del)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t' should also have an identifier name
#437: FILE: drivers/net/sfc/base/efx_impl.h:667:
+	efx_rc_t	(*eeo_vport_mac_addr_del)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vport_id_t' should also have an identifier name
#437: FILE: drivers/net/sfc/base/efx_impl.h:667:
+	efx_rc_t	(*eeo_vport_mac_addr_del)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t *' should also have an identifier name
#437: FILE: drivers/net/sfc/base/efx_impl.h:667:
+	efx_rc_t	(*eeo_vport_mac_addr_del)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#439: FILE: drivers/net/sfc/base/efx_impl.h:669:
+	efx_rc_t	(*eeo_vadaptor_alloc)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t' should also have an identifier name
#439: FILE: drivers/net/sfc/base/efx_impl.h:669:
+	efx_rc_t	(*eeo_vadaptor_alloc)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vport_id_t' should also have an identifier name
#439: FILE: drivers/net/sfc/base/efx_impl.h:669:
+	efx_rc_t	(*eeo_vadaptor_alloc)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#441: FILE: drivers/net/sfc/base/efx_impl.h:671:
+	efx_rc_t	(*eeo_vadaptor_free)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t' should also have an identifier name
#441: FILE: drivers/net/sfc/base/efx_impl.h:671:
+	efx_rc_t	(*eeo_vadaptor_free)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vport_id_t' should also have an identifier name
#441: FILE: drivers/net/sfc/base/efx_impl.h:671:
+	efx_rc_t	(*eeo_vadaptor_free)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#443: FILE: drivers/net/sfc/base/efx_impl.h:673:
+	efx_rc_t	(*eeo_vport_assign)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t' should also have an identifier name
#443: FILE: drivers/net/sfc/base/efx_impl.h:673:
+	efx_rc_t	(*eeo_vport_assign)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vport_id_t' should also have an identifier name
#443: FILE: drivers/net/sfc/base/efx_impl.h:673:
+	efx_rc_t	(*eeo_vport_assign)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name
#443: FILE: drivers/net/sfc/base/efx_impl.h:673:
+	efx_rc_t	(*eeo_vport_assign)(efx_nic_t *, efx_vswitch_id_t,

total: 5 errors, 32 warnings, 21 checks, 371 lines checked

          parent reply	other threads:[~2019-06-13 13:54 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1560152324-20538-21-git-send-email-arybchenko@solarflare.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190613135357.E0FF21D431@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arybchenko@solarflare.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).