From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw54596 [PATCH 22/29] net/sfc/base: factor out upstream port vAdaptor allocation
Date: Thu, 13 Jun 2019 15:53:59 +0200 (CEST) [thread overview]
Message-ID: <20190613135359.421FC1D431@dpdk.org> (raw)
In-Reply-To: <1560152324-20538-23-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54596
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#38: FILE: drivers/net/sfc/base/ef10_nic.c:2223:
+static __checkReturn efx_rc_t
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#39: FILE: drivers/net/sfc/base/ef10_nic.c:2224:
+ef10_upstream_port_vadaptor_alloc(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rc != ENOENT'
#58: FILE: drivers/net/sfc/base/ef10_nic.c:2243:
+ if (EFX_PCI_FUNCTION_IS_PF(&enp->en_nic_cfg) ||
+ (rc != ENOENT)) {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#87: FILE: drivers/net/sfc/base/ef10_nic.c:2272:
+ return (rc);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'enp->en_vswitchp != NULL'
#155: FILE: drivers/net/sfc/base/ef10_nic.c:2394:
+ if ((enp->en_vswitchp != NULL) && (enp->en_vswitchp->ev_evcp != NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'enp->en_vswitchp->ev_evcp != NULL'
#155: FILE: drivers/net/sfc/base/ef10_nic.c:2394:
+ if ((enp->en_vswitchp != NULL) && (enp->en_vswitchp->ev_evcp != NULL)) {
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#163: FILE: drivers/net/sfc/base/ef10_nic.c:2402:
+ if ((rc = ef10_upstream_port_vadaptor_alloc(enp)) != 0)
total: 2 errors, 0 warnings, 5 checks, 138 lines checked
parent reply other threads:[~2019-06-13 13:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1560152324-20538-23-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613135359.421FC1D431@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).