From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 087C6A05DC
	for <public@inbox.dpdk.org>; Thu, 13 Jun 2019 15:54:07 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D1DB31D452;
	Thu, 13 Jun 2019 15:54:07 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 421FC1D431; Thu, 13 Jun 2019 15:53:59 +0200 (CEST)
In-Reply-To: <1560152324-20538-23-git-send-email-arybchenko@solarflare.com>
References: <1560152324-20538-23-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20190613135359.421FC1D431@dpdk.org>
Date: Thu, 13 Jun 2019 15:53:59 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw54596 [PATCH 22/29] net/sfc/base:
	factor out upstream port vAdaptor allocation
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54596

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#38: FILE: drivers/net/sfc/base/ef10_nic.c:2223:
+static	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#39: FILE: drivers/net/sfc/base/ef10_nic.c:2224:
+ef10_upstream_port_vadaptor_alloc(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rc != ENOENT'
#58: FILE: drivers/net/sfc/base/ef10_nic.c:2243:
+		if (EFX_PCI_FUNCTION_IS_PF(&enp->en_nic_cfg) ||
+		    (rc != ENOENT)) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#87: FILE: drivers/net/sfc/base/ef10_nic.c:2272:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'enp->en_vswitchp != NULL'
#155: FILE: drivers/net/sfc/base/ef10_nic.c:2394:
+	if ((enp->en_vswitchp != NULL) && (enp->en_vswitchp->ev_evcp != NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'enp->en_vswitchp->ev_evcp != NULL'
#155: FILE: drivers/net/sfc/base/ef10_nic.c:2394:
+	if ((enp->en_vswitchp != NULL) && (enp->en_vswitchp->ev_evcp != NULL)) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#163: FILE: drivers/net/sfc/base/ef10_nic.c:2402:
+		if ((rc = ef10_upstream_port_vadaptor_alloc(enp)) != 0)

total: 2 errors, 0 warnings, 5 checks, 138 lines checked