* [dpdk-test-report] |WARNING| pw54598 [PATCH 21/29] net/sfc/base: implement vSwitch create/destroy
[not found] <1560152324-20538-22-git-send-email-arybchenko@solarflare.com>
@ 2019-06-13 13:54 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-06-13 13:54 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54598
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#85: FILE: drivers/net/sfc/base/efx.h:3408:
+extern __checkReturn efx_rc_t
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#86: FILE: drivers/net/sfc/base/efx.h:3409:
+efx_evb_vswitch_create(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#93: FILE: drivers/net/sfc/base/efx.h:3416:
+efx_evb_vswitch_destroy(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#126: FILE: drivers/net/sfc/base/efx_evb.c:137:
+efx_is_zero_eth_addr(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#134: FILE: drivers/net/sfc/base/efx_evb.c:145:
+efx_evb_free_vport(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'configp->evc_vport_id != EFX_VPORT_ID_INVALID'
#144: FILE: drivers/net/sfc/base/efx_evb.c:155:
+ if ((configp->evc_vport_id != EFX_VPORT_ID_INVALID) &&
+ (eeop->eeo_vadaptor_free(enp, vswitch_id,
+ configp->evc_vport_id) != 0)) {
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#188: FILE: drivers/net/sfc/base/efx_evb.c:199:
+efx_evb_free_vports(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#209: FILE: drivers/net/sfc/base/efx_evb.c:220:
+efx_evb_configure_vport(
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#218: FILE: drivers/net/sfc/base/efx_evb.c:229:
+ if ((rc = eeop->eeo_vport_alloc(enp, vswitch_id,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#225: FILE: drivers/net/sfc/base/efx_evb.c:236:
+ if ((rc = eeop->eeo_vport_mac_addr_add(enp, vswitch_id,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#231: FILE: drivers/net/sfc/base/efx_evb.c:242:
+ if ((rc = eeop->eeo_vadaptor_alloc(enp, vswitch_id,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#235: FILE: drivers/net/sfc/base/efx_evb.c:246:
+ if ((rc = eeop->eeo_vport_assign(enp, vswitch_id,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#253: FILE: drivers/net/sfc/base/efx_evb.c:264:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#257: FILE: drivers/net/sfc/base/efx_evb.c:268:
+efx_evb_vswitch_create(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vswitch_alloc == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+ if ((eeop->eeo_vswitch_alloc == NULL) ||
+ (eeop->eeo_vport_alloc == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vport_mac_addr_add == NULL) ||
+ (eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_alloc == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_alloc == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+ if ((eeop->eeo_vswitch_alloc == NULL) ||
+ (eeop->eeo_vport_alloc == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vport_mac_addr_add == NULL) ||
+ (eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_alloc == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_free == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+ if ((eeop->eeo_vswitch_alloc == NULL) ||
+ (eeop->eeo_vport_alloc == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vport_mac_addr_add == NULL) ||
+ (eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_alloc == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_mac_addr_add == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+ if ((eeop->eeo_vswitch_alloc == NULL) ||
+ (eeop->eeo_vport_alloc == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vport_mac_addr_add == NULL) ||
+ (eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_alloc == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_mac_addr_del == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+ if ((eeop->eeo_vswitch_alloc == NULL) ||
+ (eeop->eeo_vport_alloc == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vport_mac_addr_add == NULL) ||
+ (eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_alloc == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vadaptor_alloc == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+ if ((eeop->eeo_vswitch_alloc == NULL) ||
+ (eeop->eeo_vport_alloc == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vport_mac_addr_add == NULL) ||
+ (eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_alloc == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vadaptor_free == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+ if ((eeop->eeo_vswitch_alloc == NULL) ||
+ (eeop->eeo_vport_alloc == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vport_mac_addr_add == NULL) ||
+ (eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_alloc == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_assign == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+ if ((eeop->eeo_vswitch_alloc == NULL) ||
+ (eeop->eeo_vport_alloc == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vport_mac_addr_add == NULL) ||
+ (eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_alloc == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vswitch_free == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+ if ((eeop->eeo_vswitch_alloc == NULL) ||
+ (eeop->eeo_vport_alloc == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vport_mac_addr_add == NULL) ||
+ (eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_alloc == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#293: FILE: drivers/net/sfc/base/efx_evb.c:304:
+ EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (efx_vswitch_t), evp);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#300: FILE: drivers/net/sfc/base/efx_evb.c:311:
+ if ((rc = eeop->eeo_vswitch_alloc(enp, &vswitch_id)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#311: FILE: drivers/net/sfc/base/efx_evb.c:322:
+ if ((rc = efx_evb_configure_vport(enp, vswitch_id, eeop,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#318: FILE: drivers/net/sfc/base/efx_evb.c:329:
+ return (0);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#329: FILE: drivers/net/sfc/base/efx_evb.c:340:
+ EFSYS_KMEM_FREE(enp->en_esip, sizeof (efx_vswitch_t), evp);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#337: FILE: drivers/net/sfc/base/efx_evb.c:348:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#342: FILE: drivers/net/sfc/base/efx_evb.c:353:
+efx_evb_vswitch_destroy(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_mac_addr_del == NULL'
#353: FILE: drivers/net/sfc/base/efx_evb.c:364:
+ if ((eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vadaptor_free == NULL'
#353: FILE: drivers/net/sfc/base/efx_evb.c:364:
+ if ((eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_assign == NULL'
#353: FILE: drivers/net/sfc/base/efx_evb.c:364:
+ if ((eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_free == NULL'
#353: FILE: drivers/net/sfc/base/efx_evb.c:364:
+ if ((eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vswitch_free == NULL'
#353: FILE: drivers/net/sfc/base/efx_evb.c:364:
+ if ((eeop->eeo_vport_mac_addr_del == NULL) ||
+ (eeop->eeo_vadaptor_free == NULL) ||
+ (eeop->eeo_vport_assign == NULL) ||
+ (eeop->eeo_vport_free == NULL) ||
+ (eeop->eeo_vswitch_free == NULL)) {
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#367: FILE: drivers/net/sfc/base/efx_evb.c:378:
+ EFSYS_KMEM_FREE(enp->en_esip, sizeof (efx_vswitch_t), evp);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#371: FILE: drivers/net/sfc/base/efx_evb.c:382:
+ if ((rc = eeop->eeo_vswitch_free(enp, vswitch_id)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#374: FILE: drivers/net/sfc/base/efx_evb.c:385:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#381: FILE: drivers/net/sfc/base/efx_evb.c:392:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#412: FILE: drivers/net/sfc/base/efx_impl.h:689:
+efx_is_zero_eth_addr(
total: 12 errors, 3 warnings, 25 checks, 371 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-06-13 13:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1560152324-20538-22-git-send-email-arybchenko@solarflare.com>
2019-06-13 13:54 ` [dpdk-test-report] |WARNING| pw54598 [PATCH 21/29] net/sfc/base: implement vSwitch create/destroy checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).