From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 391EEA00E6
	for <public@inbox.dpdk.org>; Thu, 13 Jun 2019 15:54:08 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 203321D47C;
	Thu, 13 Jun 2019 15:54:08 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id D8E151D431; Thu, 13 Jun 2019 15:54:01 +0200 (CEST)
In-Reply-To: <1560152324-20538-22-git-send-email-arybchenko@solarflare.com>
References: <1560152324-20538-22-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20190613135401.D8E151D431@dpdk.org>
Date: Thu, 13 Jun 2019 15:54:01 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw54598 [PATCH 21/29] net/sfc/base:
	implement vSwitch create/destroy
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54598

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#85: FILE: drivers/net/sfc/base/efx.h:3408:
+extern	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#86: FILE: drivers/net/sfc/base/efx.h:3409:
+efx_evb_vswitch_create(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#93: FILE: drivers/net/sfc/base/efx.h:3416:
+efx_evb_vswitch_destroy(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#126: FILE: drivers/net/sfc/base/efx_evb.c:137:
+efx_is_zero_eth_addr(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#134: FILE: drivers/net/sfc/base/efx_evb.c:145:
+efx_evb_free_vport(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'configp->evc_vport_id != EFX_VPORT_ID_INVALID'
#144: FILE: drivers/net/sfc/base/efx_evb.c:155:
+		if ((configp->evc_vport_id != EFX_VPORT_ID_INVALID) &&
+		    (eeop->eeo_vadaptor_free(enp, vswitch_id,
+		    configp->evc_vport_id) != 0)) {

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#188: FILE: drivers/net/sfc/base/efx_evb.c:199:
+efx_evb_free_vports(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#209: FILE: drivers/net/sfc/base/efx_evb.c:220:
+efx_evb_configure_vport(

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#218: FILE: drivers/net/sfc/base/efx_evb.c:229:
+	if ((rc = eeop->eeo_vport_alloc(enp, vswitch_id,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#225: FILE: drivers/net/sfc/base/efx_evb.c:236:
+	if ((rc = eeop->eeo_vport_mac_addr_add(enp, vswitch_id,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#231: FILE: drivers/net/sfc/base/efx_evb.c:242:
+		if ((rc = eeop->eeo_vadaptor_alloc(enp, vswitch_id,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#235: FILE: drivers/net/sfc/base/efx_evb.c:246:
+		if ((rc = eeop->eeo_vport_assign(enp, vswitch_id,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#253: FILE: drivers/net/sfc/base/efx_evb.c:264:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#257: FILE: drivers/net/sfc/base/efx_evb.c:268:
+efx_evb_vswitch_create(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vswitch_alloc == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+	if ((eeop->eeo_vswitch_alloc == NULL) ||
+	    (eeop->eeo_vport_alloc == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vport_mac_addr_add == NULL) ||
+	    (eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_alloc == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_alloc == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+	if ((eeop->eeo_vswitch_alloc == NULL) ||
+	    (eeop->eeo_vport_alloc == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vport_mac_addr_add == NULL) ||
+	    (eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_alloc == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_free == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+	if ((eeop->eeo_vswitch_alloc == NULL) ||
+	    (eeop->eeo_vport_alloc == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vport_mac_addr_add == NULL) ||
+	    (eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_alloc == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_mac_addr_add == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+	if ((eeop->eeo_vswitch_alloc == NULL) ||
+	    (eeop->eeo_vport_alloc == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vport_mac_addr_add == NULL) ||
+	    (eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_alloc == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_mac_addr_del == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+	if ((eeop->eeo_vswitch_alloc == NULL) ||
+	    (eeop->eeo_vport_alloc == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vport_mac_addr_add == NULL) ||
+	    (eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_alloc == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vadaptor_alloc == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+	if ((eeop->eeo_vswitch_alloc == NULL) ||
+	    (eeop->eeo_vport_alloc == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vport_mac_addr_add == NULL) ||
+	    (eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_alloc == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vadaptor_free == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+	if ((eeop->eeo_vswitch_alloc == NULL) ||
+	    (eeop->eeo_vport_alloc == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vport_mac_addr_add == NULL) ||
+	    (eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_alloc == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_assign == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+	if ((eeop->eeo_vswitch_alloc == NULL) ||
+	    (eeop->eeo_vport_alloc == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vport_mac_addr_add == NULL) ||
+	    (eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_alloc == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vswitch_free == NULL'
#279: FILE: drivers/net/sfc/base/efx_evb.c:290:
+	if ((eeop->eeo_vswitch_alloc == NULL) ||
+	    (eeop->eeo_vport_alloc == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vport_mac_addr_add == NULL) ||
+	    (eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_alloc == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#293: FILE: drivers/net/sfc/base/efx_evb.c:304:
+	EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (efx_vswitch_t), evp);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#300: FILE: drivers/net/sfc/base/efx_evb.c:311:
+	if ((rc = eeop->eeo_vswitch_alloc(enp, &vswitch_id)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#311: FILE: drivers/net/sfc/base/efx_evb.c:322:
+		if ((rc = efx_evb_configure_vport(enp, vswitch_id, eeop,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#318: FILE: drivers/net/sfc/base/efx_evb.c:329:
+	return (0);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#329: FILE: drivers/net/sfc/base/efx_evb.c:340:
+	EFSYS_KMEM_FREE(enp->en_esip, sizeof (efx_vswitch_t), evp);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#337: FILE: drivers/net/sfc/base/efx_evb.c:348:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#342: FILE: drivers/net/sfc/base/efx_evb.c:353:
+efx_evb_vswitch_destroy(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_mac_addr_del == NULL'
#353: FILE: drivers/net/sfc/base/efx_evb.c:364:
+	if ((eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vadaptor_free == NULL'
#353: FILE: drivers/net/sfc/base/efx_evb.c:364:
+	if ((eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_assign == NULL'
#353: FILE: drivers/net/sfc/base/efx_evb.c:364:
+	if ((eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vport_free == NULL'
#353: FILE: drivers/net/sfc/base/efx_evb.c:364:
+	if ((eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'eeop->eeo_vswitch_free == NULL'
#353: FILE: drivers/net/sfc/base/efx_evb.c:364:
+	if ((eeop->eeo_vport_mac_addr_del == NULL) ||
+	    (eeop->eeo_vadaptor_free == NULL) ||
+	    (eeop->eeo_vport_assign == NULL) ||
+	    (eeop->eeo_vport_free == NULL) ||
+	    (eeop->eeo_vswitch_free == NULL)) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#367: FILE: drivers/net/sfc/base/efx_evb.c:378:
+	EFSYS_KMEM_FREE(enp->en_esip, sizeof (efx_vswitch_t), evp);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#371: FILE: drivers/net/sfc/base/efx_evb.c:382:
+	if ((rc = eeop->eeo_vswitch_free(enp, vswitch_id)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#374: FILE: drivers/net/sfc/base/efx_evb.c:385:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#381: FILE: drivers/net/sfc/base/efx_evb.c:392:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#412: FILE: drivers/net/sfc/base/efx_impl.h:689:
+efx_is_zero_eth_addr(

total: 12 errors, 3 warnings, 25 checks, 371 lines checked