From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw54601 [PATCH 18/29] net/sfc/base: introduce of EVB module for SR-IOV support
Date: Thu, 13 Jun 2019 15:54:05 +0200 (CEST) [thread overview]
Message-ID: <20190613135405.8A5D41D431@dpdk.org> (raw)
In-Reply-To: <1560152324-20538-19-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54601
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#82: FILE: drivers/net/sfc/base/ef10_evb.c:14:
+ __checkReturn efx_rc_t
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#83: FILE: drivers/net/sfc/base/ef10_evb.c:15:
+ef10_evb_init(
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#90: FILE: drivers/net/sfc/base/ef10_evb.c:22:
+ return (0);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#94: FILE: drivers/net/sfc/base/ef10_evb.c:26:
+ef10_evb_fini(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#114: FILE: drivers/net/sfc/base/ef10_impl.h:1267:
+ef10_evb_init(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#118: FILE: drivers/net/sfc/base/ef10_impl.h:1271:
+ef10_evb_fini(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#136: FILE: drivers/net/sfc/base/efx.h:3353:
+efx_evb_init(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#140: FILE: drivers/net/sfc/base/efx.h:3357:
+efx_evb_fini(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#197: FILE: drivers/net/sfc/base/efx_evb.c:28:
+efx_evb_init(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#202: FILE: drivers/net/sfc/base/efx_evb.c:33:
+ efx_nic_cfg_t *encp = &(enp->en_nic_cfg);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#244: FILE: drivers/net/sfc/base/efx_evb.c:75:
+ if ((rc = eeop->eeo_init(enp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#249: FILE: drivers/net/sfc/base/efx_evb.c:80:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#258: FILE: drivers/net/sfc/base/efx_evb.c:89:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#262: FILE: drivers/net/sfc/base/efx_evb.c:93:
+efx_evb_fini(
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#299: FILE: drivers/net/sfc/base/efx_impl.h:656:
+ efx_rc_t (*eeo_init)(efx_nic_t *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#300: FILE: drivers/net/sfc/base/efx_impl.h:657:
+ void (*eeo_fini)(efx_nic_t *);
total: 4 errors, 2 warnings, 10 checks, 257 lines checked
parent reply other threads:[~2019-06-13 13:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1560152324-20538-19-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613135405.8A5D41D431@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).