From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 8A7EFA00E6
	for <public@inbox.dpdk.org>; Thu, 13 Jun 2019 15:54:08 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5CC991D488;
	Thu, 13 Jun 2019 15:54:08 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 8A5D41D431; Thu, 13 Jun 2019 15:54:05 +0200 (CEST)
In-Reply-To: <1560152324-20538-19-git-send-email-arybchenko@solarflare.com>
References: <1560152324-20538-19-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20190613135405.8A5D41D431@dpdk.org>
Date: Thu, 13 Jun 2019 15:54:05 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw54601 [PATCH 18/29] net/sfc/base:
	introduce of EVB module for SR-IOV support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54601

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#82: FILE: drivers/net/sfc/base/ef10_evb.c:14:
+	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#83: FILE: drivers/net/sfc/base/ef10_evb.c:15:
+ef10_evb_init(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#90: FILE: drivers/net/sfc/base/ef10_evb.c:22:
+	return (0);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#94: FILE: drivers/net/sfc/base/ef10_evb.c:26:
+ef10_evb_fini(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#114: FILE: drivers/net/sfc/base/ef10_impl.h:1267:
+ef10_evb_init(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#118: FILE: drivers/net/sfc/base/ef10_impl.h:1271:
+ef10_evb_fini(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#136: FILE: drivers/net/sfc/base/efx.h:3353:
+efx_evb_init(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#140: FILE: drivers/net/sfc/base/efx.h:3357:
+efx_evb_fini(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#197: FILE: drivers/net/sfc/base/efx_evb.c:28:
+efx_evb_init(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#202: FILE: drivers/net/sfc/base/efx_evb.c:33:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#244: FILE: drivers/net/sfc/base/efx_evb.c:75:
+	if ((rc = eeop->eeo_init(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#249: FILE: drivers/net/sfc/base/efx_evb.c:80:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#258: FILE: drivers/net/sfc/base/efx_evb.c:89:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#262: FILE: drivers/net/sfc/base/efx_evb.c:93:
+efx_evb_fini(

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#299: FILE: drivers/net/sfc/base/efx_impl.h:656:
+	efx_rc_t	(*eeo_init)(efx_nic_t *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#300: FILE: drivers/net/sfc/base/efx_impl.h:657:
+	void		(*eeo_fini)(efx_nic_t *);

total: 4 errors, 2 warnings, 10 checks, 257 lines checked