From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AE6F3A05DC for ; Thu, 13 Jun 2019 15:54:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A5361D44F; Thu, 13 Jun 2019 15:54:33 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 981521D47C; Thu, 13 Jun 2019 15:54:09 +0200 (CEST) In-Reply-To: <1560152324-20538-25-git-send-email-arybchenko@solarflare.com> References: <1560152324-20538-25-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20190613135409.981521D47C@dpdk.org> Date: Thu, 13 Jun 2019 15:54:09 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw54604 [PATCH 24/29] net/sfc/base: support proxy auth operations for SR-IOV X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/54604 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #72: FILE: drivers/net/sfc/base/ef10_impl.h:1348: +extern __checkReturn efx_rc_t CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #73: FILE: drivers/net/sfc/base/ef10_impl.h:1349: +ef10_proxy_auth_init( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #77: FILE: drivers/net/sfc/base/ef10_impl.h:1353: +ef10_proxy_auth_fini( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #81: FILE: drivers/net/sfc/base/ef10_impl.h:1357: +ef10_proxy_auth_mc_config( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #91: FILE: drivers/net/sfc/base/ef10_impl.h:1367: +ef10_proxy_auth_disable( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #95: FILE: drivers/net/sfc/base/ef10_impl.h:1371: +ef10_proxy_auth_privilege_modify( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #126: FILE: drivers/net/sfc/base/ef10_proxy.c:13: +ef10_proxy_auth_init( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #133: FILE: drivers/net/sfc/base/ef10_proxy.c:20: + return (0); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #137: FILE: drivers/net/sfc/base/ef10_proxy.c:24: +ef10_proxy_auth_fini( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #146: FILE: drivers/net/sfc/base/ef10_proxy.c:33: +efx_mcdi_proxy_configure( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #209: FILE: drivers/net/sfc/base/ef10_proxy.c:96: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #213: FILE: drivers/net/sfc/base/ef10_proxy.c:100: +efx_mcdi_privilege_modify( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fn_group == MC_CMD_PRIVILEGE_MODIFY_IN_ONE' #236: FILE: drivers/net/sfc/base/ef10_proxy.c:123: + if ((fn_group == MC_CMD_PRIVILEGE_MODIFY_IN_ONE) || + (fn_group == MC_CMD_PRIVILEGE_MODIFY_IN_VFS_OF_PF)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fn_group == MC_CMD_PRIVILEGE_MODIFY_IN_VFS_OF_PF' #236: FILE: drivers/net/sfc/base/ef10_proxy.c:123: + if ((fn_group == MC_CMD_PRIVILEGE_MODIFY_IN_ONE) || + (fn_group == MC_CMD_PRIVILEGE_MODIFY_IN_VFS_OF_PF)) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #260: FILE: drivers/net/sfc/base/ef10_proxy.c:147: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #264: FILE: drivers/net/sfc/base/ef10_proxy.c:151: +efx_proxy_auth_fill_op_mask( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'op_listp == NULL' #273: FILE: drivers/net/sfc/base/ef10_proxy.c:160: + if ((op_listp == NULL) || (op_maskp == NULL)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'op_maskp == NULL' #273: FILE: drivers/net/sfc/base/ef10_proxy.c:160: + if ((op_listp == NULL) || (op_maskp == NULL)) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #293: FILE: drivers/net/sfc/base/ef10_proxy.c:180: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #297: FILE: drivers/net/sfc/base/ef10_proxy.c:184: +ef10_proxy_auth_mc_config( WARNING:SPACING: space prohibited between function name and open parenthesis '(' #309: FILE: drivers/net/sfc/base/ef10_proxy.c:196: + sizeof (uint32_t))) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #315: FILE: drivers/net/sfc/base/ef10_proxy.c:202: + if ((rc = efx_proxy_auth_fill_op_mask(op_listp, op_count, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #319: FILE: drivers/net/sfc/base/ef10_proxy.c:206: + if ((rc = efx_mcdi_proxy_configure(enp, B_FALSE, WARNING:SPACING: space prohibited between function name and open parenthesis '(' #326: FILE: drivers/net/sfc/base/ef10_proxy.c:213: + sizeof (op_mask))) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #329: FILE: drivers/net/sfc/base/ef10_proxy.c:216: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #336: FILE: drivers/net/sfc/base/ef10_proxy.c:223: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #340: FILE: drivers/net/sfc/base/ef10_proxy.c:227: +ef10_proxy_auth_disable( ERROR:ASSIGN_IN_IF: do not use assignment in if condition #345: FILE: drivers/net/sfc/base/ef10_proxy.c:232: + if ((rc = efx_mcdi_proxy_configure(enp, B_TRUE, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #349: FILE: drivers/net/sfc/base/ef10_proxy.c:236: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #353: FILE: drivers/net/sfc/base/ef10_proxy.c:240: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #357: FILE: drivers/net/sfc/base/ef10_proxy.c:244: +ef10_proxy_auth_privilege_modify( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #390: FILE: drivers/net/sfc/base/efx.h:3435: +efx_proxy_auth_init( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #394: FILE: drivers/net/sfc/base/efx.h:3439: +efx_proxy_auth_fini( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #398: FILE: drivers/net/sfc/base/efx.h:3443: +efx_proxy_auth_configure( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #403: FILE: drivers/net/sfc/base/efx.h:3448: +efx_proxy_auth_destroy( WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name #434: FILE: drivers/net/sfc/base/efx_impl.h:701: + efx_rc_t (*epo_init)(efx_nic_t *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name #435: FILE: drivers/net/sfc/base/efx_impl.h:702: + void (*epo_fini)(efx_nic_t *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name #436: FILE: drivers/net/sfc/base/efx_impl.h:703: + efx_rc_t (*epo_mc_config)(efx_nic_t *, efsys_mem_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efsys_mem_t *' should also have an identifier name #436: FILE: drivers/net/sfc/base/efx_impl.h:703: + efx_rc_t (*epo_mc_config)(efx_nic_t *, efsys_mem_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efsys_mem_t *' should also have an identifier name #436: FILE: drivers/net/sfc/base/efx_impl.h:703: + efx_rc_t (*epo_mc_config)(efx_nic_t *, efsys_mem_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efsys_mem_t *' should also have an identifier name #436: FILE: drivers/net/sfc/base/efx_impl.h:703: + efx_rc_t (*epo_mc_config)(efx_nic_t *, efsys_mem_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #436: FILE: drivers/net/sfc/base/efx_impl.h:703: + efx_rc_t (*epo_mc_config)(efx_nic_t *, efsys_mem_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t *' should also have an identifier name #436: FILE: drivers/net/sfc/base/efx_impl.h:703: + efx_rc_t (*epo_mc_config)(efx_nic_t *, efsys_mem_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name #436: FILE: drivers/net/sfc/base/efx_impl.h:703: + efx_rc_t (*epo_mc_config)(efx_nic_t *, efsys_mem_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name #439: FILE: drivers/net/sfc/base/efx_impl.h:706: + efx_rc_t (*epo_disable)(efx_nic_t *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name #440: FILE: drivers/net/sfc/base/efx_impl.h:707: + efx_rc_t (*epo_privilege_modify)(efx_nic_t *, uint32_t, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #440: FILE: drivers/net/sfc/base/efx_impl.h:707: + efx_rc_t (*epo_privilege_modify)(efx_nic_t *, uint32_t, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #440: FILE: drivers/net/sfc/base/efx_impl.h:707: + efx_rc_t (*epo_privilege_modify)(efx_nic_t *, uint32_t, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #440: FILE: drivers/net/sfc/base/efx_impl.h:707: + efx_rc_t (*epo_privilege_modify)(efx_nic_t *, uint32_t, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #440: FILE: drivers/net/sfc/base/efx_impl.h:707: + efx_rc_t (*epo_privilege_modify)(efx_nic_t *, uint32_t, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #440: FILE: drivers/net/sfc/base/efx_impl.h:707: + efx_rc_t (*epo_privilege_modify)(efx_nic_t *, uint32_t, uint32_t, CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #497: FILE: drivers/net/sfc/base/efx_proxy.c:33: +efx_proxy_auth_init( ERROR:ASSIGN_IN_IF: do not use assignment in if condition #543: FILE: drivers/net/sfc/base/efx_proxy.c:79: + if ((rc = epop->epo_init(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #548: FILE: drivers/net/sfc/base/efx_proxy.c:84: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #557: FILE: drivers/net/sfc/base/efx_proxy.c:93: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #561: FILE: drivers/net/sfc/base/efx_proxy.c:97: +efx_proxy_auth_fini( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'epop != NULL' #570: FILE: drivers/net/sfc/base/efx_proxy.c:106: + if ((epop != NULL) && (epop->epo_fini != NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'epop->epo_fini != NULL' #570: FILE: drivers/net/sfc/base/efx_proxy.c:106: + if ((epop != NULL) && (epop->epo_fini != NULL)) CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #578: FILE: drivers/net/sfc/base/efx_proxy.c:114: +efx_proxy_auth_configure( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'configp == NULL' #587: FILE: drivers/net/sfc/base/efx_proxy.c:123: + if ((configp == NULL) || + (configp->request_bufferp == NULL) || + (configp->response_bufferp == NULL) || + (configp->status_bufferp == NULL) || + (configp->op_listp == NULL) || + (configp->block_cnt == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'configp->request_bufferp == NULL' #587: FILE: drivers/net/sfc/base/efx_proxy.c:123: + if ((configp == NULL) || + (configp->request_bufferp == NULL) || + (configp->response_bufferp == NULL) || + (configp->status_bufferp == NULL) || + (configp->op_listp == NULL) || + (configp->block_cnt == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'configp->response_bufferp == NULL' #587: FILE: drivers/net/sfc/base/efx_proxy.c:123: + if ((configp == NULL) || + (configp->request_bufferp == NULL) || + (configp->response_bufferp == NULL) || + (configp->status_bufferp == NULL) || + (configp->op_listp == NULL) || + (configp->block_cnt == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'configp->status_bufferp == NULL' #587: FILE: drivers/net/sfc/base/efx_proxy.c:123: + if ((configp == NULL) || + (configp->request_bufferp == NULL) || + (configp->response_bufferp == NULL) || + (configp->status_bufferp == NULL) || + (configp->op_listp == NULL) || + (configp->block_cnt == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'configp->op_listp == NULL' #587: FILE: drivers/net/sfc/base/efx_proxy.c:123: + if ((configp == NULL) || + (configp->request_bufferp == NULL) || + (configp->response_bufferp == NULL) || + (configp->status_bufferp == NULL) || + (configp->op_listp == NULL) || + (configp->block_cnt == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'configp->block_cnt == 0' #587: FILE: drivers/net/sfc/base/efx_proxy.c:123: + if ((configp == NULL) || + (configp->request_bufferp == NULL) || + (configp->response_bufferp == NULL) || + (configp->status_bufferp == NULL) || + (configp->op_listp == NULL) || + (configp->block_cnt == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'epop->epo_mc_config == NULL' #597: FILE: drivers/net/sfc/base/efx_proxy.c:133: + if ((epop->epo_mc_config == NULL) || + (epop->epo_privilege_modify == NULL)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'epop->epo_privilege_modify == NULL' #597: FILE: drivers/net/sfc/base/efx_proxy.c:133: + if ((epop->epo_mc_config == NULL) || + (epop->epo_privilege_modify == NULL)) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #615: FILE: drivers/net/sfc/base/efx_proxy.c:151: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #625: FILE: drivers/net/sfc/base/efx_proxy.c:161: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #629: FILE: drivers/net/sfc/base/efx_proxy.c:165: +efx_proxy_auth_destroy( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'epop->epo_disable == NULL' #638: FILE: drivers/net/sfc/base/efx_proxy.c:174: + if ((epop->epo_disable == NULL) || + (epop->epo_privilege_modify == NULL)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'epop->epo_privilege_modify == NULL' #638: FILE: drivers/net/sfc/base/efx_proxy.c:174: + if ((epop->epo_disable == NULL) || + (epop->epo_privilege_modify == NULL)) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #653: FILE: drivers/net/sfc/base/efx_proxy.c:189: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #661: FILE: drivers/net/sfc/base/efx_proxy.c:197: + return (rc); total: 18 errors, 18 warnings, 38 checks, 609 lines checked