From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D94FCA00E6 for ; Thu, 13 Jun 2019 15:54:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B04E71D456; Thu, 13 Jun 2019 15:54:33 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id D91B71D47F; Thu, 13 Jun 2019 15:54:10 +0200 (CEST) In-Reply-To: <1560152324-20538-28-git-send-email-arybchenko@solarflare.com> References: <1560152324-20538-28-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20190613135410.D91B71D47F@dpdk.org> Date: Thu, 13 Jun 2019 15:54:10 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw54605 [PATCH 27/29] net/sfc/base: provide APIs to configure and reset vPort X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/54605 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #41: FILE: drivers/net/sfc/base/ef10_evb.c:333: + __checkReturn efx_rc_t CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #42: FILE: drivers/net/sfc/base/ef10_evb.c:334: +efx_mcdi_vport_reconfigure( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'addrp != NULL' #75: FILE: drivers/net/sfc/base/ef10_evb.c:367: + if ((addrp != NULL) && (efx_is_zero_eth_addr(addrp) == B_FALSE)) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #100: FILE: drivers/net/sfc/base/ef10_evb.c:392: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #106: FILE: drivers/net/sfc/base/ef10_evb.c:398: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #117: FILE: drivers/net/sfc/base/ef10_evb.c:525: +ef10_evb_vport_reconfigure( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #142: FILE: drivers/net/sfc/base/ef10_impl.h:1346: +ef10_evb_vport_reconfigure( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #188: FILE: drivers/net/sfc/base/efx.h:3426: +efx_evb_vport_mac_set( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #195: FILE: drivers/net/sfc/base/efx.h:3433: +efx_evb_vport_vlan_set( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #202: FILE: drivers/net/sfc/base/efx.h:3440: +efx_evb_vport_reset( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #237: FILE: drivers/net/sfc/base/efx_evb.c:354: +efx_evb_vport_mac_set( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #263: FILE: drivers/net/sfc/base/efx_evb.c:380: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #271: FILE: drivers/net/sfc/base/efx_evb.c:388: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #275: FILE: drivers/net/sfc/base/efx_evb.c:392: +efx_evb_vport_vlan_set( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #296: FILE: drivers/net/sfc/base/efx_evb.c:413: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #302: FILE: drivers/net/sfc/base/efx_evb.c:419: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #306: FILE: drivers/net/sfc/base/efx_evb.c:423: +efx_evb_vport_reset( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #334: FILE: drivers/net/sfc/base/efx_evb.c:451: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #342: FILE: drivers/net/sfc/base/efx_evb.c:459: + return (rc); WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name #355: FILE: drivers/net/sfc/base/efx_impl.h:687: + efx_rc_t (*eeo_vport_reconfigure)(efx_nic_t *, efx_vswitch_id_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t' should also have an identifier name #355: FILE: drivers/net/sfc/base/efx_impl.h:687: + efx_rc_t (*eeo_vport_reconfigure)(efx_nic_t *, efx_vswitch_id_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vport_id_t' should also have an identifier name #355: FILE: drivers/net/sfc/base/efx_impl.h:687: + efx_rc_t (*eeo_vport_reconfigure)(efx_nic_t *, efx_vswitch_id_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t *' should also have an identifier name #355: FILE: drivers/net/sfc/base/efx_impl.h:687: + efx_rc_t (*eeo_vport_reconfigure)(efx_nic_t *, efx_vswitch_id_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t *' should also have an identifier name #355: FILE: drivers/net/sfc/base/efx_impl.h:687: + efx_rc_t (*eeo_vport_reconfigure)(efx_nic_t *, efx_vswitch_id_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'boolean_t *' should also have an identifier name #355: FILE: drivers/net/sfc/base/efx_impl.h:687: + efx_rc_t (*eeo_vport_reconfigure)(efx_nic_t *, efx_vswitch_id_t, total: 8 errors, 6 warnings, 11 checks, 295 lines checked