From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 18700A00E6 for ; Thu, 13 Jun 2019 15:54:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F385F1D446; Thu, 13 Jun 2019 15:54:33 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 7301F1D47F; Thu, 13 Jun 2019 15:54:16 +0200 (CEST) In-Reply-To: <1560152324-20538-27-git-send-email-arybchenko@solarflare.com> References: <1560152324-20538-27-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20190613135416.7301F1D47F@dpdk.org> Date: Thu, 13 Jun 2019 15:54:16 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw54607 [PATCH 26/29] net/sfc/base: provide proxy APIs to client drivers X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/54607 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #44: FILE: drivers/net/sfc/base/ef10_impl.h:1379: + __checkReturn efx_rc_t CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #45: FILE: drivers/net/sfc/base/ef10_impl.h:1380: +ef10_proxy_auth_set_privilege_mask( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #52: FILE: drivers/net/sfc/base/ef10_impl.h:1387: +ef10_proxy_auth_complete_request( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #59: FILE: drivers/net/sfc/base/ef10_impl.h:1394: +ef10_proxy_auth_exec_cmd( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #76: FILE: drivers/net/sfc/base/ef10_proxy.c:257: +efx_mcdi_privilege_mask_set( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #84: FILE: drivers/net/sfc/base/ef10_proxy.c:265: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #123: FILE: drivers/net/sfc/base/ef10_proxy.c:304: + memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #155: FILE: drivers/net/sfc/base/ef10_proxy.c:336: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #159: FILE: drivers/net/sfc/base/ef10_proxy.c:340: +ef10_proxy_auth_set_privilege_mask( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #170: FILE: drivers/net/sfc/base/ef10_proxy.c:351: +efx_mcdi_proxy_complete( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #202: FILE: drivers/net/sfc/base/ef10_proxy.c:383: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #206: FILE: drivers/net/sfc/base/ef10_proxy.c:387: +ef10_proxy_auth_complete_request( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #217: FILE: drivers/net/sfc/base/ef10_proxy.c:398: +efx_mcdi_proxy_cmd( WARNING:SPACING: space prohibited between function name and open parenthesis '(' #231: FILE: drivers/net/sfc/base/ef10_proxy.c:412: + if (request_size % sizeof (*inbufp) != 0) { CHECK:SPACING: No space is necessary after a cast #239: FILE: drivers/net/sfc/base/ef10_proxy.c:420: + req.emr_in_buf = (uint8_t *) inbufp; WARNING:SPACING: space prohibited between function name and open parenthesis '(' #249: FILE: drivers/net/sfc/base/ef10_proxy.c:430: + memcpy(&inbufp[MC_CMD_PROXY_CMD_IN_LEN / sizeof (*inbufp)], ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #263: FILE: drivers/net/sfc/base/ef10_proxy.c:444: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #269: FILE: drivers/net/sfc/base/ef10_proxy.c:450: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #273: FILE: drivers/net/sfc/base/ef10_proxy.c:454: +ef10_proxy_auth_exec_cmd( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #309: FILE: drivers/net/sfc/base/efx.h:3466: +efx_proxy_auth_complete_request( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #316: FILE: drivers/net/sfc/base/efx.h:3473: +efx_proxy_auth_exec_cmd( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #321: FILE: drivers/net/sfc/base/efx.h:3478: +efx_proxy_auth_set_privilege_mask( WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name #338: FILE: drivers/net/sfc/base/efx_impl.h:709: + efx_rc_t (*epo_set_privilege_mask)(efx_nic_t *, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #338: FILE: drivers/net/sfc/base/efx_impl.h:709: + efx_rc_t (*epo_set_privilege_mask)(efx_nic_t *, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #338: FILE: drivers/net/sfc/base/efx_impl.h:709: + efx_rc_t (*epo_set_privilege_mask)(efx_nic_t *, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #338: FILE: drivers/net/sfc/base/efx_impl.h:709: + efx_rc_t (*epo_set_privilege_mask)(efx_nic_t *, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name #340: FILE: drivers/net/sfc/base/efx_impl.h:711: + efx_rc_t (*epo_complete_request)(efx_nic_t *, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #340: FILE: drivers/net/sfc/base/efx_impl.h:711: + efx_rc_t (*epo_complete_request)(efx_nic_t *, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #340: FILE: drivers/net/sfc/base/efx_impl.h:711: + efx_rc_t (*epo_complete_request)(efx_nic_t *, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #340: FILE: drivers/net/sfc/base/efx_impl.h:711: + efx_rc_t (*epo_complete_request)(efx_nic_t *, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name #342: FILE: drivers/net/sfc/base/efx_impl.h:713: + efx_rc_t (*epo_exec_cmd)(efx_nic_t *, efx_proxy_cmd_params_t *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_proxy_cmd_params_t *' should also have an identifier name #342: FILE: drivers/net/sfc/base/efx_impl.h:713: + efx_rc_t (*epo_exec_cmd)(efx_nic_t *, efx_proxy_cmd_params_t *); ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #355: FILE: drivers/net/sfc/base/efx_mcdi.c:364: + if (((cmd != emrp->emr_cmd) && (emrp->emr_cmd != MC_CMD_PROXY_CMD)) || [...] (seq != ((emip->emi_seq - 1) & EFX_MASK32(MCDI_HEADER_SEQ)))) { CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #454: FILE: drivers/net/sfc/base/efx_proxy.c:207: +efx_proxy_auth_complete_request( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #474: FILE: drivers/net/sfc/base/efx_proxy.c:227: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #479: FILE: drivers/net/sfc/base/efx_proxy.c:232: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #483: FILE: drivers/net/sfc/base/efx_proxy.c:236: +efx_proxy_auth_exec_cmd( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #506: FILE: drivers/net/sfc/base/efx_proxy.c:259: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #513: FILE: drivers/net/sfc/base/efx_proxy.c:266: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #517: FILE: drivers/net/sfc/base/efx_proxy.c:270: +efx_proxy_auth_set_privilege_mask( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #537: FILE: drivers/net/sfc/base/efx_proxy.c:290: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #543: FILE: drivers/net/sfc/base/efx_proxy.c:296: + return (rc); total: 11 errors, 13 warnings, 18 checks, 472 lines checked