From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw54608 [PATCH 29/29] net/sfc/base: add APIs for PTP privilege configuration
Date: Thu, 13 Jun 2019 15:54:17 +0200 (CEST) [thread overview]
Message-ID: <20190613135417.87B131D43F@dpdk.org> (raw)
In-Reply-To: <1560152324-20538-30-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54608
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#42: FILE: drivers/net/sfc/base/ef10_impl.h:1414:
+ __checkReturn efx_rc_t
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#43: FILE: drivers/net/sfc/base/ef10_impl.h:1415:
+ef10_proxy_auth_get_privilege_mask(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#60: FILE: drivers/net/sfc/base/ef10_proxy.c:454:
+ef10_proxy_auth_get_privilege_mask(
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#66: FILE: drivers/net/sfc/base/ef10_proxy.c:460:
+ return (efx_mcdi_privilege_mask(enp, pf_index, vf_index, maskp));
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#83: FILE: drivers/net/sfc/base/efx.h:3517:
+efx_proxy_auth_privilege_mask_get(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#90: FILE: drivers/net/sfc/base/efx.h:3524:
+efx_proxy_auth_privilege_modify(
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#108: FILE: drivers/net/sfc/base/efx_impl.h:720:
+ efx_rc_t (*epo_get_privilege_mask)(efx_nic_t *, uint32_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name
#108: FILE: drivers/net/sfc/base/efx_impl.h:720:
+ efx_rc_t (*epo_get_privilege_mask)(efx_nic_t *, uint32_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name
#108: FILE: drivers/net/sfc/base/efx_impl.h:720:
+ efx_rc_t (*epo_get_privilege_mask)(efx_nic_t *, uint32_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t *' should also have an identifier name
#108: FILE: drivers/net/sfc/base/efx_impl.h:720:
+ efx_rc_t (*epo_get_privilege_mask)(efx_nic_t *, uint32_t,
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#138: FILE: drivers/net/sfc/base/efx_proxy.c:302:
+efx_proxy_auth_privilege_mask_get(
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#158: FILE: drivers/net/sfc/base/efx_proxy.c:322:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#164: FILE: drivers/net/sfc/base/efx_proxy.c:328:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#168: FILE: drivers/net/sfc/base/efx_proxy.c:332:
+efx_proxy_auth_privilege_modify(
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#191: FILE: drivers/net/sfc/base/efx_proxy.c:355:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#197: FILE: drivers/net/sfc/base/efx_proxy.c:361:
+ return (rc);
total: 5 errors, 4 warnings, 7 checks, 140 lines checked
parent reply other threads:[~2019-06-13 13:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1560152324-20538-30-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613135417.87B131D43F@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).