From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1F625A00E6 for ; Thu, 13 Jun 2019 15:54:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A5281D46D; Thu, 13 Jun 2019 15:54:34 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 87B131D43F; Thu, 13 Jun 2019 15:54:17 +0200 (CEST) In-Reply-To: <1560152324-20538-30-git-send-email-arybchenko@solarflare.com> References: <1560152324-20538-30-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20190613135417.87B131D43F@dpdk.org> Date: Thu, 13 Jun 2019 15:54:17 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw54608 [PATCH 29/29] net/sfc/base: add APIs for PTP privilege configuration X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/54608 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #42: FILE: drivers/net/sfc/base/ef10_impl.h:1414: + __checkReturn efx_rc_t CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #43: FILE: drivers/net/sfc/base/ef10_impl.h:1415: +ef10_proxy_auth_get_privilege_mask( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #60: FILE: drivers/net/sfc/base/ef10_proxy.c:454: +ef10_proxy_auth_get_privilege_mask( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #66: FILE: drivers/net/sfc/base/ef10_proxy.c:460: + return (efx_mcdi_privilege_mask(enp, pf_index, vf_index, maskp)); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #83: FILE: drivers/net/sfc/base/efx.h:3517: +efx_proxy_auth_privilege_mask_get( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #90: FILE: drivers/net/sfc/base/efx.h:3524: +efx_proxy_auth_privilege_modify( WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name #108: FILE: drivers/net/sfc/base/efx_impl.h:720: + efx_rc_t (*epo_get_privilege_mask)(efx_nic_t *, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #108: FILE: drivers/net/sfc/base/efx_impl.h:720: + efx_rc_t (*epo_get_privilege_mask)(efx_nic_t *, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name #108: FILE: drivers/net/sfc/base/efx_impl.h:720: + efx_rc_t (*epo_get_privilege_mask)(efx_nic_t *, uint32_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t *' should also have an identifier name #108: FILE: drivers/net/sfc/base/efx_impl.h:720: + efx_rc_t (*epo_get_privilege_mask)(efx_nic_t *, uint32_t, CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #138: FILE: drivers/net/sfc/base/efx_proxy.c:302: +efx_proxy_auth_privilege_mask_get( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #158: FILE: drivers/net/sfc/base/efx_proxy.c:322: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #164: FILE: drivers/net/sfc/base/efx_proxy.c:328: + return (rc); CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #168: FILE: drivers/net/sfc/base/efx_proxy.c:332: +efx_proxy_auth_privilege_modify( ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #191: FILE: drivers/net/sfc/base/efx_proxy.c:355: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #197: FILE: drivers/net/sfc/base/efx_proxy.c:361: + return (rc); total: 5 errors, 4 warnings, 7 checks, 140 lines checked