From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw54609 [PATCH 09/29] net/sfc/base: add NVRAM info to API
Date: Thu, 13 Jun 2019 15:54:19 +0200 (CEST) [thread overview]
Message-ID: <20190613135419.0C1984F94@dpdk.org> (raw)
In-Reply-To: <1560152324-20538-10-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54609
_coding style issues_
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#42: FILE: drivers/net/sfc/base/ef10_impl.h:455:
+ef10_nvram_partn_info(
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#45: FILE: drivers/net/sfc/base/ef10_impl.h:458:
+ __out efx_nvram_info_t * enip);
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#47: FILE: drivers/net/sfc/base/ef10_impl.h:460:
+extern __checkReturn efx_rc_t
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#59: FILE: drivers/net/sfc/base/ef10_nvram.c:1963:
+ef10_nvram_partn_info(
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#66: FILE: drivers/net/sfc/base/ef10_nvram.c:1970:
+ if ((rc = efx_mcdi_nvram_info_ex(enp, partn, enip)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#72: FILE: drivers/net/sfc/base/ef10_nvram.c:1976:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#77: FILE: drivers/net/sfc/base/ef10_nvram.c:1981:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#95: FILE: drivers/net/sfc/base/ef10_nvram.c:2468:
+ if ((rc = ef10_nvram_partn_info(enp, partn, &eni)) != 0)
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#120: FILE: drivers/net/sfc/base/efx.h:1638:
+efx_nvram_info(
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#138: FILE: drivers/net/sfc/base/efx_impl.h:504:
+ efx_rc_t (*envo_partn_info)(efx_nic_t *, uint32_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name
#138: FILE: drivers/net/sfc/base/efx_impl.h:504:
+ efx_rc_t (*envo_partn_info)(efx_nic_t *, uint32_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nvram_info_t *' should also have an identifier name
#138: FILE: drivers/net/sfc/base/efx_impl.h:504:
+ efx_rc_t (*envo_partn_info)(efx_nic_t *, uint32_t,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#178: FILE: drivers/net/sfc/base/efx_nvram.c:151:
+ if ((rc = envop->envo_partn_info(enp, partn, &eni)) != 0)
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#191: FILE: drivers/net/sfc/base/efx_nvram.c:168:
+efx_nvram_info(
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#203: FILE: drivers/net/sfc/base/efx_nvram.c:180:
+ if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#206: FILE: drivers/net/sfc/base/efx_nvram.c:183:
+ if ((rc = envop->envo_partn_info(enp, partn, enip)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#209: FILE: drivers/net/sfc/base/efx_nvram.c:186:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#216: FILE: drivers/net/sfc/base/efx_nvram.c:193:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#237: FILE: drivers/net/sfc/base/efx_nvram.c:353:
+ if ((rc = envop->envo_partn_info(enp, partn, &eni)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#241: FILE: drivers/net/sfc/base/efx_nvram.c:356:
+ if ((rc = envop->envo_partn_erase(enp, partn, offset,
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#254: FILE: drivers/net/sfc/base/siena_impl.h:195:
+siena_nvram_partn_info(
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#257: FILE: drivers/net/sfc/base/siena_impl.h:198:
+ __out efx_nvram_info_t * enip);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#271: FILE: drivers/net/sfc/base/siena_nvram.c:43:
+siena_nvram_partn_info(
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#274: FILE: drivers/net/sfc/base/siena_nvram.c:46:
+ __out efx_nvram_info_t * enip)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#278: FILE: drivers/net/sfc/base/siena_nvram.c:50:
+ if ((rc = efx_mcdi_nvram_info_ex(enp, partn, enip)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#284: FILE: drivers/net/sfc/base/siena_nvram.c:56:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#289: FILE: drivers/net/sfc/base/siena_nvram.c:61:
+ return (rc);
total: 17 errors, 3 warnings, 7 checks, 221 lines checked
parent reply other threads:[~2019-06-13 13:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1560152324-20538-10-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613135419.0C1984F94@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).