From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 4F8ADA00E6
	for <public@inbox.dpdk.org>; Thu, 13 Jun 2019 15:54:34 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 4AC3E1D479;
	Thu, 13 Jun 2019 15:54:34 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id D76FA1C4CE; Thu, 13 Jun 2019 15:54:20 +0200 (CEST)
In-Reply-To: <1560152324-20538-14-git-send-email-arybchenko@solarflare.com>
References: <1560152324-20538-14-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20190613135420.D76FA1C4CE@dpdk.org>
Date: Thu, 13 Jun 2019 15:54:20 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw54610 [PATCH 13/29] net/sfc/base:
	transition to the extensible NVRAM info API
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54610

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#44: FILE: drivers/net/sfc/base/ef10_nvram.c:1951:
+	if ((rc = efx_mcdi_nvram_info(enp, partn, &eni)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#57: FILE: drivers/net/sfc/base/ef10_nvram.c:1972:
+	if ((rc = efx_mcdi_nvram_info(enp, partn, enip)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#70: FILE: drivers/net/sfc/base/ef10_nvram.c:2088:
+	if ((rc = efx_mcdi_nvram_info(enp, partn, &eni)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#88: FILE: drivers/net/sfc/base/ef10_nvram.c:2137:
+	if ((rc = efx_mcdi_nvram_info(enp, partn, &eni)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#114: FILE: drivers/net/sfc/base/ef10_vpd.c:92:
+	if ((rc = efx_mcdi_nvram_info(enp,

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#152: FILE: drivers/net/sfc/base/efx_nvram.c:694:
+efx_mcdi_nvram_info(

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#216: FILE: drivers/net/sfc/base/siena_nvram.c:28:
+	if ((rc = efx_mcdi_nvram_info(enp, partn, &eni)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#229: FILE: drivers/net/sfc/base/siena_nvram.c:51:
+	if ((rc = efx_mcdi_nvram_info(enp, partn, enip)) != 0)

total: 7 errors, 0 warnings, 1 checks, 170 lines checked