* [dpdk-test-report] |WARNING| pw54610 [PATCH 13/29] net/sfc/base: transition to the extensible NVRAM info API
[not found] <1560152324-20538-14-git-send-email-arybchenko@solarflare.com>
@ 2019-06-13 13:54 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-06-13 13:54 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54610
_coding style issues_
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#44: FILE: drivers/net/sfc/base/ef10_nvram.c:1951:
+ if ((rc = efx_mcdi_nvram_info(enp, partn, &eni)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#57: FILE: drivers/net/sfc/base/ef10_nvram.c:1972:
+ if ((rc = efx_mcdi_nvram_info(enp, partn, enip)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#70: FILE: drivers/net/sfc/base/ef10_nvram.c:2088:
+ if ((rc = efx_mcdi_nvram_info(enp, partn, &eni)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#88: FILE: drivers/net/sfc/base/ef10_nvram.c:2137:
+ if ((rc = efx_mcdi_nvram_info(enp, partn, &eni)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#114: FILE: drivers/net/sfc/base/ef10_vpd.c:92:
+ if ((rc = efx_mcdi_nvram_info(enp,
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#152: FILE: drivers/net/sfc/base/efx_nvram.c:694:
+efx_mcdi_nvram_info(
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#216: FILE: drivers/net/sfc/base/siena_nvram.c:28:
+ if ((rc = efx_mcdi_nvram_info(enp, partn, &eni)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#229: FILE: drivers/net/sfc/base/siena_nvram.c:51:
+ if ((rc = efx_mcdi_nvram_info(enp, partn, enip)) != 0)
total: 7 errors, 0 warnings, 1 checks, 170 lines checked
^ permalink raw reply [flat|nested] only message in thread