From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 6A334A00E6
	for <public@inbox.dpdk.org>; Thu, 13 Jun 2019 15:54:34 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 64D2A1D465;
	Thu, 13 Jun 2019 15:54:34 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 6EE831C4CE; Thu, 13 Jun 2019 15:54:22 +0200 (CEST)
In-Reply-To: <1560152324-20538-29-git-send-email-arybchenko@solarflare.com>
References: <1560152324-20538-29-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20190613135422.6EE831C4CE@dpdk.org>
Date: Thu, 13 Jun 2019 15:54:22 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw54611 [PATCH 28/29] net/sfc/base:
	provide API to fetch vPort statistics
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54611

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#41: FILE: drivers/net/sfc/base/ef10_evb.c:539:
+	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#42: FILE: drivers/net/sfc/base/ef10_evb.c:540:
+ef10_evb_vport_stats(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#65: FILE: drivers/net/sfc/base/ef10_impl.h:1355:
+ef10_evb_vport_stats(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#84: FILE: drivers/net/sfc/base/efx.h:3449:
+efx_evb_vport_stats(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#118: FILE: drivers/net/sfc/base/efx_evb.c:507:
+efx_evb_vport_stats(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#144: FILE: drivers/net/sfc/base/efx_evb.c:533:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#152: FILE: drivers/net/sfc/base/efx_evb.c:541:
+	return (rc);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#164: FILE: drivers/net/sfc/base/efx_impl.h:691:
+	efx_rc_t	(*eeo_vport_stats)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vswitch_id_t' should also have an identifier name
#164: FILE: drivers/net/sfc/base/efx_impl.h:691:
+	efx_rc_t	(*eeo_vport_stats)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_vport_id_t' should also have an identifier name
#164: FILE: drivers/net/sfc/base/efx_impl.h:691:
+	efx_rc_t	(*eeo_vport_stats)(efx_nic_t *, efx_vswitch_id_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efsys_mem_t *' should also have an identifier name
#164: FILE: drivers/net/sfc/base/efx_impl.h:691:
+	efx_rc_t	(*eeo_vport_stats)(efx_nic_t *, efx_vswitch_id_t,

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#189: FILE: drivers/net/sfc/base/efx_impl.h:1379:
+efx_mcdi_mac_stats(

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#237: FILE: drivers/net/sfc/base/efx_mcdi.c:1939:
+	if ((rc = efx_mcdi_mac_stats(enp, enp->en_vport_id, NULL,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#247: FILE: drivers/net/sfc/base/efx_mcdi.c:1963:
+	if ((rc = efx_mcdi_mac_stats(enp, enp->en_vport_id, esmp,

total: 4 errors, 4 warnings, 6 checks, 201 lines checked