* [dpdk-test-report] |WARNING| pw54613 [PATCH 19/29] net/sfc/base: add MCDI wrappers for vPort and vSwitch in EVB
[not found] <1560152324-20538-20-git-send-email-arybchenko@solarflare.com>
@ 2019-06-13 13:54 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-06-13 13:54 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54613
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#37: FILE: drivers/net/sfc/base/ef10_evb.c:34:
+ __checkReturn efx_rc_t
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#38: FILE: drivers/net/sfc/base/ef10_evb.c:35:
+efx_mcdi_vswitch_alloc(
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#90: FILE: drivers/net/sfc/base/ef10_evb.c:87:
+ memset(payload, 0, sizeof (payload));
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#101: FILE: drivers/net/sfc/base/ef10_evb.c:98:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#105: FILE: drivers/net/sfc/base/ef10_evb.c:102:
+efx_mcdi_vswitch_free(
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#132: FILE: drivers/net/sfc/base/ef10_evb.c:129:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#136: FILE: drivers/net/sfc/base/ef10_evb.c:133:
+efx_mcdi_vport_alloc(
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#189: FILE: drivers/net/sfc/base/ef10_evb.c:186:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#195: FILE: drivers/net/sfc/base/ef10_evb.c:192:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#199: FILE: drivers/net/sfc/base/ef10_evb.c:196:
+efx_mcdi_vport_free(
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#226: FILE: drivers/net/sfc/base/ef10_evb.c:223:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#230: FILE: drivers/net/sfc/base/ef10_evb.c:227:
+efx_mcdi_vport_mac_addr_add(
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#261: FILE: drivers/net/sfc/base/ef10_evb.c:258:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#265: FILE: drivers/net/sfc/base/ef10_evb.c:262:
+efx_mcdi_vport_mac_addr_del(
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#296: FILE: drivers/net/sfc/base/ef10_evb.c:293:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#300: FILE: drivers/net/sfc/base/ef10_evb.c:297:
+efx_mcdi_port_assign(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#308: FILE: drivers/net/sfc/base/ef10_evb.c:305:
+ efx_nic_cfg_t *encp = &(enp->en_nic_cfg);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#333: FILE: drivers/net/sfc/base/ef10_evb.c:330:
+ return (rc);
total: 8 errors, 1 warnings, 9 checks, 328 lines checked
^ permalink raw reply [flat|nested] only message in thread