From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Qiming Yang <qiming.yang@intel.com>
Subject: [dpdk-test-report] |WARNING| pw54731 [PATCH v2 2/3] net/ice: add generic flow API
Date: Thu, 13 Jun 2019 15:57:09 +0200 (CEST) [thread overview]
Message-ID: <20190613135709.F22391D59D@dpdk.org> (raw)
In-Reply-To: <20190612075029.109914-3-qiming.yang@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54731
_coding style issues_
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 24)
#564: FILE: drivers/net/ice/ice_generic_flow.c:390:
+ if (icmp6_mask->type == UINT8_MAX)
+ input_set |= ICE_INSET_ICMP6;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!fields'
#585: FILE: drivers/net/ice/ice_generic_flow.c:411:
+ if ((!fields) || (fields && (!inset))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!inset'
#585: FILE: drivers/net/ice/ice_generic_flow.c:411:
+ if ((!fields) || (fields && (!inset))) {
CHECK:BRACES: Unbalanced braces around else statement
#714: FILE: drivers/net/ice/ice_generic_flow.c:540:
+ } else
total: 0 errors, 1 warnings, 3 checks, 1087 lines checked
parent reply other threads:[~2019-06-13 13:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190612075029.109914-3-qiming.yang@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613135709.F22391D59D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).