From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D67AAA00E6 for ; Thu, 13 Jun 2019 15:57:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF98A1D5D0; Thu, 13 Jun 2019 15:57:50 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id B90B01D549; Thu, 13 Jun 2019 15:57:35 +0200 (CEST) In-Reply-To: <20190613064248.4930-1-jgrajcia@cisco.com> References: <20190613064248.4930-1-jgrajcia@cisco.com> To: test-report@dpdk.org Cc: Jakub Grajciar Message-Id: <20190613135735.B90B01D549@dpdk.org> Date: Thu, 13 Jun 2019 15:57:35 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw54751 [PATCH v1] net/memif: multi-process support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/54751 _coding style issues_ WARNING:LONG_LINE: line over 90 characters #399: FILE: drivers/net/memif/rte_eth_memif.c:243: + struct pmd_process_private *proc_private = rte_eth_devices[mq->in_port].process_private; WARNING:LONG_LINE: line over 90 characters #436: FILE: drivers/net/memif/rte_eth_memif.c:322: + (uint8_t *)memif_get_buffer(proc_private, d0) + src_off, cp_len); WARNING:LONG_LINE: line over 90 characters #447: FILE: drivers/net/memif/rte_eth_memif.c:372: + struct pmd_process_private *proc_private = rte_eth_devices[mq->in_port].process_private; CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ring == NULL' #743: FILE: drivers/net/memif/rte_eth_memif.c:728: + if ((ring == NULL) || (ring->cookie != MEMIF_COOKIE)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ring->cookie != MEMIF_COOKIE' #743: FILE: drivers/net/memif/rte_eth_memif.c:728: + if ((ring == NULL) || (ring->cookie != MEMIF_COOKIE)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ring == NULL' #776: FILE: drivers/net/memif/rte_eth_memif.c:744: + if ((ring == NULL) || (ring->cookie != MEMIF_COOKIE)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ring->cookie != MEMIF_COOKIE' #776: FILE: drivers/net/memif/rte_eth_memif.c:744: + if ((ring == NULL) || (ring->cookie != MEMIF_COOKIE)) { CHECK:BRACES: braces {} should be used on all arms of this statement #815: FILE: drivers/net/memif/rte_eth_memif.c:794: + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { [...] - (*dev->dev_ops->rx_queue_release)(dev->data->rx_queues[i]); [...] CHECK:BRACES: Unbalanced braces around else statement #829: FILE: drivers/net/memif/rte_eth_memif.c:804: + } else WARNING:LONG_LINE: line over 90 characters #905: FILE: drivers/net/memif/rte_eth_memif.c:1051: + rte_zmalloc(name, sizeof(struct pmd_process_private), RTE_CACHE_LINE_SIZE); ERROR:CODE_INDENT: code indent should use tabs where possible #947: FILE: drivers/net/memif/rte_eth_memif.c:1264: + ^I^Iif (!eth_dev) {$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #947: FILE: drivers/net/memif/rte_eth_memif.c:1264: + ^I^Iif (!eth_dev) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #947: FILE: drivers/net/memif/rte_eth_memif.c:1264: + ^I^Iif (!eth_dev) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #948: FILE: drivers/net/memif/rte_eth_memif.c:1265: + ^I^I^IMIF_LOG(ERR, "Failed to probe %s", name);$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #948: FILE: drivers/net/memif/rte_eth_memif.c:1265: + ^I^I^IMIF_LOG(ERR, "Failed to probe %s", name);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #948: FILE: drivers/net/memif/rte_eth_memif.c:1265: + ^I^I^IMIF_LOG(ERR, "Failed to probe %s", name);$ ERROR:CODE_INDENT: code indent should use tabs where possible #949: FILE: drivers/net/memif/rte_eth_memif.c:1266: + ^I^I^Ireturn -1;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #949: FILE: drivers/net/memif/rte_eth_memif.c:1266: + ^I^I^Ireturn -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #949: FILE: drivers/net/memif/rte_eth_memif.c:1266: + ^I^I^Ireturn -1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #950: FILE: drivers/net/memif/rte_eth_memif.c:1267: + ^I^I}$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #950: FILE: drivers/net/memif/rte_eth_memif.c:1267: + ^I^I}$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #950: FILE: drivers/net/memif/rte_eth_memif.c:1267: + ^I^I}$ ERROR:CODE_INDENT: code indent should use tabs where possible #952: FILE: drivers/net/memif/rte_eth_memif.c:1269: + ^I^Ieth_dev->dev_ops = &ops;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #952: FILE: drivers/net/memif/rte_eth_memif.c:1269: + ^I^Ieth_dev->dev_ops = &ops;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #952: FILE: drivers/net/memif/rte_eth_memif.c:1269: + ^I^Ieth_dev->dev_ops = &ops;$ ERROR:CODE_INDENT: code indent should use tabs where possible #953: FILE: drivers/net/memif/rte_eth_memif.c:1270: + ^I^Ieth_dev->device = &vdev->device;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #953: FILE: drivers/net/memif/rte_eth_memif.c:1270: + ^I^Ieth_dev->device = &vdev->device;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #953: FILE: drivers/net/memif/rte_eth_memif.c:1270: + ^I^Ieth_dev->device = &vdev->device;$ ERROR:CODE_INDENT: code indent should use tabs where possible #954: FILE: drivers/net/memif/rte_eth_memif.c:1271: + ^I^Ieth_dev->rx_pkt_burst = eth_memif_rx;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #954: FILE: drivers/net/memif/rte_eth_memif.c:1271: + ^I^Ieth_dev->rx_pkt_burst = eth_memif_rx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #954: FILE: drivers/net/memif/rte_eth_memif.c:1271: + ^I^Ieth_dev->rx_pkt_burst = eth_memif_rx;$ ERROR:CODE_INDENT: code indent should use tabs where possible #955: FILE: drivers/net/memif/rte_eth_memif.c:1272: + ^I^Ieth_dev->tx_pkt_burst = eth_memif_rx;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #955: FILE: drivers/net/memif/rte_eth_memif.c:1272: + ^I^Ieth_dev->tx_pkt_burst = eth_memif_rx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #955: FILE: drivers/net/memif/rte_eth_memif.c:1272: + ^I^Ieth_dev->tx_pkt_burst = eth_memif_rx;$ ERROR:CODE_INDENT: code indent should use tabs where possible #957: FILE: drivers/net/memif/rte_eth_memif.c:1274: + ^I^Iif (!rte_eal_primary_proc_alive(NULL)) {$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #957: FILE: drivers/net/memif/rte_eth_memif.c:1274: + ^I^Iif (!rte_eal_primary_proc_alive(NULL)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #957: FILE: drivers/net/memif/rte_eth_memif.c:1274: + ^I^Iif (!rte_eal_primary_proc_alive(NULL)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #958: FILE: drivers/net/memif/rte_eth_memif.c:1275: + ^I^I^IMIF_LOG(ERR, "Primary process is missing");$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #958: FILE: drivers/net/memif/rte_eth_memif.c:1275: + ^I^I^IMIF_LOG(ERR, "Primary process is missing");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #958: FILE: drivers/net/memif/rte_eth_memif.c:1275: + ^I^I^IMIF_LOG(ERR, "Primary process is missing");$ ERROR:CODE_INDENT: code indent should use tabs where possible #959: FILE: drivers/net/memif/rte_eth_memif.c:1276: + ^I^I^Ireturn -1;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #959: FILE: drivers/net/memif/rte_eth_memif.c:1276: + ^I^I^Ireturn -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #959: FILE: drivers/net/memif/rte_eth_memif.c:1276: + ^I^I^Ireturn -1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #960: FILE: drivers/net/memif/rte_eth_memif.c:1277: + ^I^I}$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #960: FILE: drivers/net/memif/rte_eth_memif.c:1277: + ^I^I}$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #960: FILE: drivers/net/memif/rte_eth_memif.c:1277: + ^I^I}$ ERROR:CODE_INDENT: code indent should use tabs where possible #962: FILE: drivers/net/memif/rte_eth_memif.c:1279: + ^I^Ieth_dev->process_private = (struct pmd_process_private *)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #962: FILE: drivers/net/memif/rte_eth_memif.c:1279: + ^I^Ieth_dev->process_private = (struct pmd_process_private *)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #962: FILE: drivers/net/memif/rte_eth_memif.c:1279: + ^I^Ieth_dev->process_private = (struct pmd_process_private *)$ ERROR:CODE_INDENT: code indent should use tabs where possible #963: FILE: drivers/net/memif/rte_eth_memif.c:1280: + ^I^I^Irte_zmalloc(name,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #963: FILE: drivers/net/memif/rte_eth_memif.c:1280: + ^I^I^Irte_zmalloc(name,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #963: FILE: drivers/net/memif/rte_eth_memif.c:1280: + ^I^I^Irte_zmalloc(name,$ ERROR:CODE_INDENT: code indent should use tabs where possible #964: FILE: drivers/net/memif/rte_eth_memif.c:1281: + ^I^I^I^Isizeof(struct pmd_process_private),$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #964: FILE: drivers/net/memif/rte_eth_memif.c:1281: + ^I^I^I^Isizeof(struct pmd_process_private),$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #964: FILE: drivers/net/memif/rte_eth_memif.c:1281: + ^I^I^I^Isizeof(struct pmd_process_private),$ ERROR:CODE_INDENT: code indent should use tabs where possible #965: FILE: drivers/net/memif/rte_eth_memif.c:1282: + ^I^I^I^IRTE_CACHE_LINE_SIZE);$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #965: FILE: drivers/net/memif/rte_eth_memif.c:1282: + ^I^I^I^IRTE_CACHE_LINE_SIZE);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #965: FILE: drivers/net/memif/rte_eth_memif.c:1282: + ^I^I^I^IRTE_CACHE_LINE_SIZE);$ ERROR:CODE_INDENT: code indent should use tabs where possible #966: FILE: drivers/net/memif/rte_eth_memif.c:1283: + ^I^Iif (eth_dev->process_private == NULL) {$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #966: FILE: drivers/net/memif/rte_eth_memif.c:1283: + ^I^Iif (eth_dev->process_private == NULL) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #966: FILE: drivers/net/memif/rte_eth_memif.c:1283: + ^I^Iif (eth_dev->process_private == NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #967: FILE: drivers/net/memif/rte_eth_memif.c:1284: + ^I^I^IMIF_LOG(ERR,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #967: FILE: drivers/net/memif/rte_eth_memif.c:1284: + ^I^I^IMIF_LOG(ERR,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #967: FILE: drivers/net/memif/rte_eth_memif.c:1284: + ^I^I^IMIF_LOG(ERR,$ ERROR:CODE_INDENT: code indent should use tabs where possible #968: FILE: drivers/net/memif/rte_eth_memif.c:1285: + ^I^I^I^I"Failed to alloc memory for process private");$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #968: FILE: drivers/net/memif/rte_eth_memif.c:1285: + ^I^I^I^I"Failed to alloc memory for process private");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #968: FILE: drivers/net/memif/rte_eth_memif.c:1285: + ^I^I^I^I"Failed to alloc memory for process private");$ ERROR:CODE_INDENT: code indent should use tabs where possible #969: FILE: drivers/net/memif/rte_eth_memif.c:1286: + ^I^I^Ireturn -1;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #969: FILE: drivers/net/memif/rte_eth_memif.c:1286: + ^I^I^Ireturn -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #969: FILE: drivers/net/memif/rte_eth_memif.c:1286: + ^I^I^Ireturn -1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #970: FILE: drivers/net/memif/rte_eth_memif.c:1287: + ^I^I}$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #970: FILE: drivers/net/memif/rte_eth_memif.c:1287: + ^I^I}$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #970: FILE: drivers/net/memif/rte_eth_memif.c:1287: + ^I^I}$ ERROR:CODE_INDENT: code indent should use tabs where possible #972: FILE: drivers/net/memif/rte_eth_memif.c:1289: + ^I^Irte_eth_dev_probing_finish(eth_dev);$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #972: FILE: drivers/net/memif/rte_eth_memif.c:1289: + ^I^Irte_eth_dev_probing_finish(eth_dev);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #972: FILE: drivers/net/memif/rte_eth_memif.c:1289: + ^I^Irte_eth_dev_probing_finish(eth_dev);$ ERROR:CODE_INDENT: code indent should use tabs where possible #974: FILE: drivers/net/memif/rte_eth_memif.c:1291: + ^I^Ireturn 0;$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #974: FILE: drivers/net/memif/rte_eth_memif.c:1291: + ^I^Ireturn 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #974: FILE: drivers/net/memif/rte_eth_memif.c:1291: + ^I^Ireturn 0;$ total: 23 errors, 50 warnings, 6 checks, 924 lines checked