From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 69831A0471
	for <public@inbox.dpdk.org>; Wed, 19 Jun 2019 16:31:36 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 622441C339;
	Wed, 19 Jun 2019 16:31:36 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 47E331C30E; Wed, 19 Jun 2019 16:31:30 +0200 (CEST)
In-Reply-To: <20190618084851.5322-1-jgrajcia@cisco.com>
References: <20190618084851.5322-1-jgrajcia@cisco.com>
To: test-report@dpdk.org
Cc: Jakub Grajciar <jgrajcia@cisco.com>
Message-Id: <20190619143130.47E331C30E@dpdk.org>
Date: Wed, 19 Jun 2019 16:31:30 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw54904 [PATCH v2] net/memif:
	multi-process support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/54904

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#321: FILE: drivers/net/memif/rte_eth_memif.c:146:
+                                free(reply);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#321: FILE: drivers/net/memif/rte_eth_memif.c:146:
+                                free(reply);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#322: FILE: drivers/net/memif/rte_eth_memif.c:147:
+                                return -ENOMEM;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#322: FILE: drivers/net/memif/rte_eth_memif.c:147:
+                                return -ENOMEM;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#327: FILE: drivers/net/memif/rte_eth_memif.c:152:
+                                free(reply);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#327: FILE: drivers/net/memif/rte_eth_memif.c:152:
+                                free(reply);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#328: FILE: drivers/net/memif/rte_eth_memif.c:153:
+                                return -1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#328: FILE: drivers/net/memif/rte_eth_memif.c:153:
+                                return -1;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#338: FILE: drivers/net/memif/rte_eth_memif.c:163:
+        free(reply);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#338: FILE: drivers/net/memif/rte_eth_memif.c:163:
+        free(reply);$

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#341: FILE: drivers/net/memif/rte_eth_memif.c:166:
+
+}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#831: FILE: drivers/net/memif/rte_eth_memif.c:805:
+		for (i = 0; i < dev->data->nb_rx_queues; i++) {
+			(*dev->dev_ops->rx_queue_release)(dev->data->rx_queues[i]);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#834: FILE: drivers/net/memif/rte_eth_memif.c:808:
+		for (i = 0; i < dev->data->nb_tx_queues; i++) {
+			(*dev->dev_ops->tx_queue_release)(dev->data->tx_queues[i]);
+		}

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#987: FILE: drivers/net/memif/rte_eth_memif.c:1303:
+		return 0;
+	} else {

total: 5 errors, 8 warnings, 1 checks, 933 lines checked