From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ziyang Xuan <xuanziyang2@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw55069 [PATCH v5 14/15] net/hinic: add tx/rx package burst
Date: Thu, 20 Jun 2019 11:53:12 +0200 (CEST) [thread overview]
Message-ID: <20190620095312.3BE181D0CA@dpdk.org> (raw)
In-Reply-To: <691dcc833654d7e8a666e88ea07dae95a4951230.1560958308.git.xuanziyang2@huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/55069
_coding style issues_
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#283: FILE: drivers/net/hinic/hinic_pmd_rx.c:735:
+ volatile __m128i *wqe_be = (volatile __m128i *)src_be32;
^
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#717: FILE: drivers/net/hinic/hinic_pmd_tx.c:174:
+#define HINIC_GET_SQ_HW_CI(txq) \
+ ((be16_to_cpu(*(txq)->cons_idx_addr)) & HINIC_GET_SQ_WQE_MASK(txq))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#720: FILE: drivers/net/hinic/hinic_pmd_tx.c:177:
+#define HINIC_GET_SQ_LOCAL_CI(txq) \
+ (((txq)->wq->cons_idx) & HINIC_GET_SQ_WQE_MASK(txq))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#723: FILE: drivers/net/hinic/hinic_pmd_tx.c:180:
+#define HINIC_UPDATE_SQ_LOCAL_CI(txq, wqebb_cnt) \
+ do { \
+ (txq)->wq->cons_idx += wqebb_cnt; \
+ (txq)->wq->delta += wqebb_cnt; \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wqebb_cnt' - possible side-effects?
#723: FILE: drivers/net/hinic/hinic_pmd_tx.c:180:
+#define HINIC_UPDATE_SQ_LOCAL_CI(txq, wqebb_cnt) \
+ do { \
+ (txq)->wq->cons_idx += wqebb_cnt; \
+ (txq)->wq->delta += wqebb_cnt; \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#731: FILE: drivers/net/hinic/hinic_pmd_tx.c:188:
+#define HINIC_IS_SQ_EMPTY(txq) (((txq)->wq->delta) == ((txq)->q_depth))
total: 0 errors, 0 warnings, 6 checks, 1596 lines checked
parent reply other threads:[~2019-06-20 9:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <691dcc833654d7e8a666e88ea07dae95a4951230.1560958308.git.xuanziyang2@huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620095312.3BE181D0CA@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=xuanziyang2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).