From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 0DF7AA0471
	for <public@inbox.dpdk.org>; Thu, 20 Jun 2019 11:53:14 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 0863E1D001;
	Thu, 20 Jun 2019 11:53:14 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 3BE181D0CA; Thu, 20 Jun 2019 11:53:12 +0200 (CEST)
In-Reply-To: <691dcc833654d7e8a666e88ea07dae95a4951230.1560958308.git.xuanziyang2@huawei.com>
References: <691dcc833654d7e8a666e88ea07dae95a4951230.1560958308.git.xuanziyang2@huawei.com>
To: test-report@dpdk.org
Cc: Ziyang Xuan <xuanziyang2@huawei.com>
Message-Id: <20190620095312.3BE181D0CA@dpdk.org>
Date: Thu, 20 Jun 2019 11:53:12 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw55069 [PATCH v5 14/15] net/hinic:
	add tx/rx package burst
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/55069

_coding style issues_


CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#283: FILE: drivers/net/hinic/hinic_pmd_rx.c:735:
+	volatile __m128i *wqe_be = (volatile __m128i *)src_be32;
 	                 ^

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#717: FILE: drivers/net/hinic/hinic_pmd_tx.c:174:
+#define HINIC_GET_SQ_HW_CI(txq)	\
+	((be16_to_cpu(*(txq)->cons_idx_addr)) & HINIC_GET_SQ_WQE_MASK(txq))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#720: FILE: drivers/net/hinic/hinic_pmd_tx.c:177:
+#define HINIC_GET_SQ_LOCAL_CI(txq)	\
+	(((txq)->wq->cons_idx) & HINIC_GET_SQ_WQE_MASK(txq))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#723: FILE: drivers/net/hinic/hinic_pmd_tx.c:180:
+#define HINIC_UPDATE_SQ_LOCAL_CI(txq, wqebb_cnt)	\
+	do {						\
+		(txq)->wq->cons_idx += wqebb_cnt;	\
+		(txq)->wq->delta += wqebb_cnt;		\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wqebb_cnt' - possible side-effects?
#723: FILE: drivers/net/hinic/hinic_pmd_tx.c:180:
+#define HINIC_UPDATE_SQ_LOCAL_CI(txq, wqebb_cnt)	\
+	do {						\
+		(txq)->wq->cons_idx += wqebb_cnt;	\
+		(txq)->wq->delta += wqebb_cnt;		\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects?
#731: FILE: drivers/net/hinic/hinic_pmd_tx.c:188:
+#define HINIC_IS_SQ_EMPTY(txq)	(((txq)->wq->delta) == ((txq)->q_depth))

total: 0 errors, 0 warnings, 6 checks, 1596 lines checked